Don't use Zstandard bundles on Windows
In testing, gzip performs better than Zstandard on Windows.
This commit is contained in:
parent
9d1e406cd6
commit
eefb943f7e
7 changed files with 7 additions and 8 deletions
2
.github/workflows/__zstd-bundle-fallback.yml
generated
vendored
2
.github/workflows/__zstd-bundle-fallback.yml
generated
vendored
|
|
@ -29,8 +29,6 @@ jobs:
|
|||
include:
|
||||
- os: macos-latest
|
||||
version: linked
|
||||
- os: windows-latest
|
||||
version: linked
|
||||
- os: ubuntu-latest
|
||||
version: linked
|
||||
name: Zstandard bundle fallback
|
||||
|
|
|
|||
2
.github/workflows/__zstd-bundle.yml
generated
vendored
2
.github/workflows/__zstd-bundle.yml
generated
vendored
|
|
@ -29,8 +29,6 @@ jobs:
|
|||
include:
|
||||
- os: macos-latest
|
||||
version: linked
|
||||
- os: windows-latest
|
||||
version: linked
|
||||
- os: ubuntu-latest
|
||||
version: linked
|
||||
name: Zstandard bundle
|
||||
|
|
|
|||
5
lib/setup-codeql.js
generated
5
lib/setup-codeql.js
generated
|
|
@ -553,7 +553,10 @@ function sanitizeUrlForStatusReport(url) {
|
|||
: "sanitized-value";
|
||||
}
|
||||
async function useZstdBundle(cliVersion, features, tarSupportsZstd) {
|
||||
return (tarSupportsZstd &&
|
||||
return (
|
||||
// In testing, gzip performs better than zstd on Windows.
|
||||
process.platform !== "win32" &&
|
||||
tarSupportsZstd &&
|
||||
semver.gte(cliVersion, feature_flags_1.CODEQL_VERSION_ZSTD_BUNDLE) &&
|
||||
!!(await features.getValue(feature_flags_1.Feature.ZstdBundle)));
|
||||
}
|
||||
|
|
|
|||
File diff suppressed because one or more lines are too long
|
|
@ -4,7 +4,6 @@ versions:
|
|||
- linked
|
||||
operatingSystems:
|
||||
- macos
|
||||
- windows
|
||||
- ubuntu
|
||||
env:
|
||||
CODEQL_ACTION_ZSTD_BUNDLE: true
|
||||
|
|
|
|||
|
|
@ -4,7 +4,6 @@ versions:
|
|||
- linked
|
||||
operatingSystems:
|
||||
- macos
|
||||
- windows
|
||||
- ubuntu
|
||||
env:
|
||||
CODEQL_ACTION_ZSTD_BUNDLE: true
|
||||
|
|
|
|||
|
|
@ -823,6 +823,8 @@ async function useZstdBundle(
|
|||
tarSupportsZstd: boolean,
|
||||
): Promise<boolean> {
|
||||
return (
|
||||
// In testing, gzip performs better than zstd on Windows.
|
||||
process.platform !== "win32" &&
|
||||
tarSupportsZstd &&
|
||||
semver.gte(cliVersion, CODEQL_VERSION_ZSTD_BUNDLE) &&
|
||||
!!(await features.getValue(Feature.ZstdBundle))
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue