robojerk/codeql-action

Update error message and remove feature flag preloading

Browse source 
Discussion here https://github.com/github/codeql-action/pull/882#discussion_r789924177
shows that properly handling preloading feature flag errors is complex
and the benefit we get from it does not offset the complexity.
This commit is contained in:
Andrew Eisenberg 2022-01-21 11:20:48 -08:00
parent e175dea369
commit f18151cc59
13 changed files with 16 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/feature-flags.test.ts
View file

@ -102,26 +102,6 @@ test("Feature flags are disabled if they're not returned in API response", async
});
});
test("Feature flags exception is propagated if the API request errors", async (t) => {
await withTmpDir(async (tmpDir) => {
setupActionsVars(tmpDir, tmpDir);
const featureFlags = new GitHubFeatureFlags(
{ type: GitHubVariant.DOTCOM },
testApiDetails,
testRepositoryNwo,
getRunnerLogger(true)
);
mockFeatureFlagApiEndpoint(500, {});
await t.throwsAsync(async () => featureFlags.preloadFeatureFlags(), {
message:
"Encountered an error while trying to load feature flags: Error: some error message",
});
});
});
const FEATURE_FLAGS = [
"database_uploads_enabled",
"ml_powered_queries_enabled",