Rename defaultQueryFilters

This commit renames AugmentationProperties.defaultQueryFilters to
extraQueryExclusions, and changes its type to ExcludeQueryFilter[]. It
matters whether we are adding query inclusions or exclusions, and this
renaming makes that distinction clearer.
This commit is contained in:
Chuan-kai Lin 2025-06-19 12:19:28 -07:00
parent 1764e3d1c2
commit f5304e7bf5
2 changed files with 9 additions and 7 deletions

View file

@ -1266,7 +1266,7 @@ async function generateCodeScanningConfig(
}
augmentedConfig["query-filters"] = [
...(config.augmentationProperties.defaultQueryFilters || []),
...(config.augmentationProperties.extraQueryExclusions || []),
...(augmentedConfig["query-filters"] || []),
];
if (augmentedConfig["query-filters"]?.length === 0) {

View file

@ -186,9 +186,9 @@ export interface AugmentationProperties {
packsInput?: string[];
/**
* Default query filters to apply to the queries in the config.
* Extra query exclusions to append to the config.
*/
defaultQueryFilters?: QueryFilter[];
extraQueryExclusions?: ExcludeQueryFilter[];
}
/**
@ -201,7 +201,7 @@ export const defaultAugmentationProperties: AugmentationProperties = {
packsInput: undefined,
queriesInput: undefined,
qualityQueriesInput: undefined,
defaultQueryFilters: [],
extraQueryExclusions: [],
};
export type Packs = Partial<Record<Language, string[]>>;
@ -671,9 +671,11 @@ export async function calculateAugmentation(
false,
);
const defaultQueryFilters: QueryFilter[] = [];
const extraQueryExclusions: ExcludeQueryFilter[] = [];
if (await shouldPerformDiffInformedAnalysis(codeql, features, logger)) {
defaultQueryFilters.push({ exclude: { tags: "exclude-from-incremental" } });
extraQueryExclusions.push({
exclude: { tags: "exclude-from-incremental" },
});
}
return {
@ -682,7 +684,7 @@ export async function calculateAugmentation(
queriesInput,
queriesInputCombines,
qualityQueriesInput,
defaultQueryFilters,
extraQueryExclusions,
};
}