robojerk/codeql-action

Avoid fingerprinting directories

Browse source
This commit is contained in:
Andrew Eisenberg 2021-05-05 12:19:59 -07:00
parent 53210459f6
commit f584f94f3d
6 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/fingerprints.test.ts
View file

@ -163,6 +163,11 @@ test("resolveUriToFile", (t) => {
// Invalid indexes are discarded
t.is(testResolveUriToFile(undefined, 1, [filepath]), undefined);
t.is(testResolveUriToFile(undefined, "0", [filepath]), undefined);
// Directories are discarded
const dirpath = __dirname;
t.is(testResolveUriToFile(dirpath, undefined, []), undefined);
t.is(testResolveUriToFile(`file://${dirpath}`, undefined, []), undefined);
});
test("addFingerprints", (t) => {

5
src/fingerprints.ts
View file

@ -227,6 +227,11 @@ export function resolveUriToFile(
return undefined;
}
if (fs.statSync(uri).isDirectory()) {
logger.debug(`Unable to compute fingerprint for directory: ${uri}`);
return undefined;
}
return uri;
}