Merge pull request #1505 from github/henrymercer/more-node-12-cleanup

More cleanup as a result of dropping Node 12
This commit is contained in:
Henry Mercer 2023-01-23 20:11:32 +00:00 committed by GitHub
commit fa47d5ade1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 7 additions and 13 deletions

View file

@ -7,10 +7,9 @@ if [ ! -z "$(git status --porcelain)" ]; then
>&2 echo "Failed: Repo should be clean before testing!"
exit 1
fi
# Pin npm to v8 since v9 doesn't support Node 12.
# When updating this, make sure to update the npm version in
# `.github/workflows/update-dependencies.yml` too.
sudo npm install --force -g npm@^8.19.3
sudo npm install --force -g npm@9.2.0
# Reinstall modules and then clean to remove absolute paths
# Use 'npm ci' instead of 'npm install' as this is intended to be reproducible
npm ci

View file

@ -27,10 +27,9 @@ jobs:
run: |
git fetch origin "$BRANCH" --depth=1
git checkout "origin/$BRANCH"
# Pin npm to v8 since v9 doesn't support Node 12.
# When updating this, make sure to update the npm version in
# `.github/workflows/script/check-node-modules.sh` too.
sudo npm install --force -g npm@^8.19.3
sudo npm install --force -g npm@9.2.0
npm install
npm ci
npm run removeNPMAbsolutePaths