robojerk/codeql-action

Address PR comments from @henrymercer

Browse source
This commit is contained in:
Edoardo Pirovano 2021-08-18 16:39:00 +01:00
parent e70ec1d70e
commit fd45eac830
No known key found for this signature in database
GPG key ID: 047556B5D93FFE28
3 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/codeql.js generated
View file

@ -68,7 +68,8 @@ const CODEQL_MINIMUM_VERSION = "2.3.1";
const CODEQL_VERSION_RAM_FINALIZE = "2.5.8"; const CODEQL_VERSION_RAM_FINALIZE = "2.5.8";
const CODEQL_VERSION_DIAGNOSTICS = "2.5.6"; const CODEQL_VERSION_DIAGNOSTICS = "2.5.6";
const CODEQL_VERSION_METRICS = "2.5.5"; const CODEQL_VERSION_METRICS = "2.5.5";
const CODEQL_VERSION_GROUP_RULES = "2.5.1"; const CODEQL_VERSION_GROUP_RULES = "2.5.5";
const CODEQL_VERSION_SARIF_GROUP = "2.5.3";
function getCodeQLBundleName() { function getCodeQLBundleName() {
let platform; let platform;
if (process.platform === "win32") { if (process.platform === "win32") {
@ -526,7 +527,8 @@ async function getCodeQLForCmd(cmd, checkVersion) {
codeqlArgs.push("--print-metrics-summary"); codeqlArgs.push("--print-metrics-summary");
if (await util.codeQlVersionAbove(this, CODEQL_VERSION_GROUP_RULES)) if (await util.codeQlVersionAbove(this, CODEQL_VERSION_GROUP_RULES))
codeqlArgs.push("--sarif-group-rules-by-pack"); codeqlArgs.push("--sarif-group-rules-by-pack");
if (automationDetailsId !== undefined) { if (automationDetailsId !== undefined &&
(await util.codeQlVersionAbove(this, CODEQL_VERSION_SARIF_GROUP))) {
codeqlArgs.push("--sarif-category", automationDetailsId); codeqlArgs.push("--sarif-category", automationDetailsId);
} }
codeqlArgs.push(databasePath, ...querySuitePaths); codeqlArgs.push(databasePath, ...querySuitePaths);

2
lib/codeql.js.map
View file

File diff suppressed because one or more lines are too long

8
src/codeql.ts
View file

@ -196,7 +196,8 @@ const CODEQL_MINIMUM_VERSION = "2.3.1";
const CODEQL_VERSION_RAM_FINALIZE = "2.5.8"; const CODEQL_VERSION_RAM_FINALIZE = "2.5.8";
const CODEQL_VERSION_DIAGNOSTICS = "2.5.6"; const CODEQL_VERSION_DIAGNOSTICS = "2.5.6";
const CODEQL_VERSION_METRICS = "2.5.5"; const CODEQL_VERSION_METRICS = "2.5.5";
const CODEQL_VERSION_GROUP_RULES = "2.5.1"; const CODEQL_VERSION_GROUP_RULES = "2.5.5";
const CODEQL_VERSION_SARIF_GROUP = "2.5.3";
function getCodeQLBundleName(): string { function getCodeQLBundleName(): string {
let platform: string; let platform: string;
@ -811,7 +812,10 @@ async function getCodeQLForCmd(
codeqlArgs.push("--print-metrics-summary"); codeqlArgs.push("--print-metrics-summary");
if (await util.codeQlVersionAbove(this, CODEQL_VERSION_GROUP_RULES)) if (await util.codeQlVersionAbove(this, CODEQL_VERSION_GROUP_RULES))
codeqlArgs.push("--sarif-group-rules-by-pack"); codeqlArgs.push("--sarif-group-rules-by-pack");
if (automationDetailsId !== undefined) { if (
automationDetailsId !== undefined &&
(await util.codeQlVersionAbove(this, CODEQL_VERSION_SARIF_GROUP))
) {
codeqlArgs.push("--sarif-category", automationDetailsId); codeqlArgs.push("--sarif-category", automationDetailsId);
} }
codeqlArgs.push(databasePath, ...querySuitePaths); codeqlArgs.push(databasePath, ...querySuitePaths);