robojerk/codeql-action

Move uploading side-effect out of runAnalyze

Browse source 
https://github.com/github/codeql-action/pull/323#discussion_r530978010
This commit is contained in:
Sam Partington 2020-11-27 12:23:06 +00:00
parent 9532bda6e4
commit ff28c8d403
9 changed files with 57 additions and 90 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/runner.ts
View file

@ -372,17 +372,6 @@ program
};
await runAnalyze(
parseRepositoryNwo(cmd.repository),
cmd.commit,
parseRef(cmd.ref),
undefined,
undefined,
undefined,
cmd.checkoutPath || process.cwd(),
undefined,
apiDetails,
cmd.upload,
"runner",
outputDir,
getMemoryFlag(cmd.ram),
getAddSnippetsFlag(cmd.addSnippets),
@ -390,6 +379,21 @@ program
config,
logger
);
if (!cmd.upload) {
logger.info("Not uploading results");
return;
}
await upload_lib.uploadFromRunner(
outputDir,
parseRepositoryNwo(cmd.repository),
cmd.commit,
parseRef(cmd.ref),
cmd.checkoutPath || process.cwd(),
apiDetails,
logger
);
} catch (e) {
logger.error("Analyze failed");
logger.error(e);