bc50092bdb
* Bump the npm group with 4 updates Bumps the npm group with 4 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser), [eslint](https://github.com/eslint/eslint) and [nock](https://github.com/nock/nock). Updates `@typescript-eslint/eslint-plugin` from 6.13.0 to 6.13.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.13.2/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.13.0 to 6.13.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.13.2/packages/parser) Updates `eslint` from 8.54.0 to 8.55.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.54.0...v8.55.0) Updates `nock` from 13.3.8 to 13.4.0 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v13.3.8...v13.4.0) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm ... Signed-off-by: dependabot[bot] <support@github.com> * Update checked-in dependencies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
410 lines
17 KiB
JavaScript
410 lines
17 KiB
JavaScript
/**
|
|
* @fileoverview Restrict usage of specified node imports.
|
|
* @author Guy Ellis
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
const ignore = require("ignore");
|
|
|
|
const arrayOfStringsOrObjects = {
|
|
type: "array",
|
|
items: {
|
|
anyOf: [
|
|
{ type: "string" },
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
name: { type: "string" },
|
|
message: {
|
|
type: "string",
|
|
minLength: 1
|
|
},
|
|
importNames: {
|
|
type: "array",
|
|
items: {
|
|
type: "string"
|
|
}
|
|
}
|
|
},
|
|
additionalProperties: false,
|
|
required: ["name"]
|
|
}
|
|
]
|
|
},
|
|
uniqueItems: true
|
|
};
|
|
|
|
const arrayOfStringsOrObjectPatterns = {
|
|
anyOf: [
|
|
{
|
|
type: "array",
|
|
items: {
|
|
type: "string"
|
|
},
|
|
uniqueItems: true
|
|
},
|
|
{
|
|
type: "array",
|
|
items: {
|
|
type: "object",
|
|
properties: {
|
|
importNames: {
|
|
type: "array",
|
|
items: {
|
|
type: "string"
|
|
},
|
|
minItems: 1,
|
|
uniqueItems: true
|
|
},
|
|
group: {
|
|
type: "array",
|
|
items: {
|
|
type: "string"
|
|
},
|
|
minItems: 1,
|
|
uniqueItems: true
|
|
},
|
|
importNamePattern: {
|
|
type: "string"
|
|
},
|
|
message: {
|
|
type: "string",
|
|
minLength: 1
|
|
},
|
|
caseSensitive: {
|
|
type: "boolean"
|
|
}
|
|
},
|
|
additionalProperties: false,
|
|
required: ["group"]
|
|
},
|
|
uniqueItems: true
|
|
}
|
|
]
|
|
};
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow specified modules when loaded by `import`",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-restricted-imports"
|
|
},
|
|
|
|
messages: {
|
|
path: "'{{importSource}}' import is restricted from being used.",
|
|
// eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
|
|
pathWithCustomMessage: "'{{importSource}}' import is restricted from being used. {{customMessage}}",
|
|
|
|
patterns: "'{{importSource}}' import is restricted from being used by a pattern.",
|
|
// eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
|
|
patternWithCustomMessage: "'{{importSource}}' import is restricted from being used by a pattern. {{customMessage}}",
|
|
|
|
patternAndImportName: "'{{importName}}' import from '{{importSource}}' is restricted from being used by a pattern.",
|
|
// eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
|
|
patternAndImportNameWithCustomMessage: "'{{importName}}' import from '{{importSource}}' is restricted from being used by a pattern. {{customMessage}}",
|
|
|
|
patternAndEverything: "* import is invalid because '{{importNames}}' from '{{importSource}}' is restricted from being used by a pattern.",
|
|
|
|
patternAndEverythingWithRegexImportName: "* import is invalid because import name matching '{{importNames}}' pattern from '{{importSource}}' is restricted from being used.",
|
|
// eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
|
|
patternAndEverythingWithCustomMessage: "* import is invalid because '{{importNames}}' from '{{importSource}}' is restricted from being used by a pattern. {{customMessage}}",
|
|
// eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
|
|
patternAndEverythingWithRegexImportNameAndCustomMessage: "* import is invalid because import name matching '{{importNames}}' pattern from '{{importSource}}' is restricted from being used. {{customMessage}}",
|
|
|
|
everything: "* import is invalid because '{{importNames}}' from '{{importSource}}' is restricted.",
|
|
// eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
|
|
everythingWithCustomMessage: "* import is invalid because '{{importNames}}' from '{{importSource}}' is restricted. {{customMessage}}",
|
|
|
|
importName: "'{{importName}}' import from '{{importSource}}' is restricted.",
|
|
// eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
|
|
importNameWithCustomMessage: "'{{importName}}' import from '{{importSource}}' is restricted. {{customMessage}}"
|
|
},
|
|
|
|
schema: {
|
|
anyOf: [
|
|
arrayOfStringsOrObjects,
|
|
{
|
|
type: "array",
|
|
items: [{
|
|
type: "object",
|
|
properties: {
|
|
paths: arrayOfStringsOrObjects,
|
|
patterns: arrayOfStringsOrObjectPatterns
|
|
},
|
|
additionalProperties: false
|
|
}],
|
|
additionalItems: false
|
|
}
|
|
]
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
const options = Array.isArray(context.options) ? context.options : [];
|
|
const isPathAndPatternsObject =
|
|
typeof options[0] === "object" &&
|
|
(Object.prototype.hasOwnProperty.call(options[0], "paths") || Object.prototype.hasOwnProperty.call(options[0], "patterns"));
|
|
|
|
const restrictedPaths = (isPathAndPatternsObject ? options[0].paths : context.options) || [];
|
|
const restrictedPathMessages = restrictedPaths.reduce((memo, importSource) => {
|
|
if (typeof importSource === "string") {
|
|
memo[importSource] = { message: null };
|
|
} else {
|
|
memo[importSource.name] = {
|
|
message: importSource.message,
|
|
importNames: importSource.importNames
|
|
};
|
|
}
|
|
return memo;
|
|
}, {});
|
|
|
|
// Handle patterns too, either as strings or groups
|
|
let restrictedPatterns = (isPathAndPatternsObject ? options[0].patterns : []) || [];
|
|
|
|
// standardize to array of objects if we have an array of strings
|
|
if (restrictedPatterns.length > 0 && typeof restrictedPatterns[0] === "string") {
|
|
restrictedPatterns = [{ group: restrictedPatterns }];
|
|
}
|
|
|
|
// relative paths are supported for this rule
|
|
const restrictedPatternGroups = restrictedPatterns.map(({ group, message, caseSensitive, importNames, importNamePattern }) => ({
|
|
matcher: ignore({ allowRelativePaths: true, ignorecase: !caseSensitive }).add(group),
|
|
customMessage: message,
|
|
importNames,
|
|
importNamePattern
|
|
}));
|
|
|
|
// if no imports are restricted we don't need to check
|
|
if (Object.keys(restrictedPaths).length === 0 && restrictedPatternGroups.length === 0) {
|
|
return {};
|
|
}
|
|
|
|
/**
|
|
* Report a restricted path.
|
|
* @param {string} importSource path of the import
|
|
* @param {Map<string,Object[]>} importNames Map of import names that are being imported
|
|
* @param {node} node representing the restricted path reference
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function checkRestrictedPathAndReport(importSource, importNames, node) {
|
|
if (!Object.prototype.hasOwnProperty.call(restrictedPathMessages, importSource)) {
|
|
return;
|
|
}
|
|
|
|
const customMessage = restrictedPathMessages[importSource].message;
|
|
const restrictedImportNames = restrictedPathMessages[importSource].importNames;
|
|
|
|
if (restrictedImportNames) {
|
|
if (importNames.has("*")) {
|
|
const specifierData = importNames.get("*")[0];
|
|
|
|
context.report({
|
|
node,
|
|
messageId: customMessage ? "everythingWithCustomMessage" : "everything",
|
|
loc: specifierData.loc,
|
|
data: {
|
|
importSource,
|
|
importNames: restrictedImportNames,
|
|
customMessage
|
|
}
|
|
});
|
|
}
|
|
|
|
restrictedImportNames.forEach(importName => {
|
|
if (importNames.has(importName)) {
|
|
const specifiers = importNames.get(importName);
|
|
|
|
specifiers.forEach(specifier => {
|
|
context.report({
|
|
node,
|
|
messageId: customMessage ? "importNameWithCustomMessage" : "importName",
|
|
loc: specifier.loc,
|
|
data: {
|
|
importSource,
|
|
customMessage,
|
|
importName
|
|
}
|
|
});
|
|
});
|
|
}
|
|
});
|
|
} else {
|
|
context.report({
|
|
node,
|
|
messageId: customMessage ? "pathWithCustomMessage" : "path",
|
|
data: {
|
|
importSource,
|
|
customMessage
|
|
}
|
|
});
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Report a restricted path specifically for patterns.
|
|
* @param {node} node representing the restricted path reference
|
|
* @param {Object} group contains an Ignore instance for paths, the customMessage to show on failure,
|
|
* and any restricted import names that have been specified in the config
|
|
* @param {Map<string,Object[]>} importNames Map of import names that are being imported
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function reportPathForPatterns(node, group, importNames) {
|
|
const importSource = node.source.value.trim();
|
|
|
|
const customMessage = group.customMessage;
|
|
const restrictedImportNames = group.importNames;
|
|
const restrictedImportNamePattern = group.importNamePattern ? new RegExp(group.importNamePattern, "u") : null;
|
|
|
|
/*
|
|
* If we are not restricting to any specific import names and just the pattern itself,
|
|
* report the error and move on
|
|
*/
|
|
if (!restrictedImportNames && !restrictedImportNamePattern) {
|
|
context.report({
|
|
node,
|
|
messageId: customMessage ? "patternWithCustomMessage" : "patterns",
|
|
data: {
|
|
importSource,
|
|
customMessage
|
|
}
|
|
});
|
|
return;
|
|
}
|
|
|
|
importNames.forEach((specifiers, importName) => {
|
|
if (importName === "*") {
|
|
const [specifier] = specifiers;
|
|
|
|
if (restrictedImportNames) {
|
|
context.report({
|
|
node,
|
|
messageId: customMessage ? "patternAndEverythingWithCustomMessage" : "patternAndEverything",
|
|
loc: specifier.loc,
|
|
data: {
|
|
importSource,
|
|
importNames: restrictedImportNames,
|
|
customMessage
|
|
}
|
|
});
|
|
} else {
|
|
context.report({
|
|
node,
|
|
messageId: customMessage ? "patternAndEverythingWithRegexImportNameAndCustomMessage" : "patternAndEverythingWithRegexImportName",
|
|
loc: specifier.loc,
|
|
data: {
|
|
importSource,
|
|
importNames: restrictedImportNamePattern,
|
|
customMessage
|
|
}
|
|
});
|
|
}
|
|
|
|
return;
|
|
}
|
|
|
|
if (
|
|
(restrictedImportNames && restrictedImportNames.includes(importName)) ||
|
|
(restrictedImportNamePattern && restrictedImportNamePattern.test(importName))
|
|
) {
|
|
specifiers.forEach(specifier => {
|
|
context.report({
|
|
node,
|
|
messageId: customMessage ? "patternAndImportNameWithCustomMessage" : "patternAndImportName",
|
|
loc: specifier.loc,
|
|
data: {
|
|
importSource,
|
|
customMessage,
|
|
importName
|
|
}
|
|
});
|
|
});
|
|
}
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Check if the given importSource is restricted by a pattern.
|
|
* @param {string} importSource path of the import
|
|
* @param {Object} group contains a Ignore instance for paths, and the customMessage to show if it fails
|
|
* @returns {boolean} whether the variable is a restricted pattern or not
|
|
* @private
|
|
*/
|
|
function isRestrictedPattern(importSource, group) {
|
|
return group.matcher.ignores(importSource);
|
|
}
|
|
|
|
/**
|
|
* Checks a node to see if any problems should be reported.
|
|
* @param {ASTNode} node The node to check.
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function checkNode(node) {
|
|
const importSource = node.source.value.trim();
|
|
const importNames = new Map();
|
|
|
|
if (node.type === "ExportAllDeclaration") {
|
|
const starToken = sourceCode.getFirstToken(node, 1);
|
|
|
|
importNames.set("*", [{ loc: starToken.loc }]);
|
|
} else if (node.specifiers) {
|
|
for (const specifier of node.specifiers) {
|
|
let name;
|
|
const specifierData = { loc: specifier.loc };
|
|
|
|
if (specifier.type === "ImportDefaultSpecifier") {
|
|
name = "default";
|
|
} else if (specifier.type === "ImportNamespaceSpecifier") {
|
|
name = "*";
|
|
} else if (specifier.imported) {
|
|
name = astUtils.getModuleExportName(specifier.imported);
|
|
} else if (specifier.local) {
|
|
name = astUtils.getModuleExportName(specifier.local);
|
|
}
|
|
|
|
if (typeof name === "string") {
|
|
if (importNames.has(name)) {
|
|
importNames.get(name).push(specifierData);
|
|
} else {
|
|
importNames.set(name, [specifierData]);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
checkRestrictedPathAndReport(importSource, importNames, node);
|
|
restrictedPatternGroups.forEach(group => {
|
|
if (isRestrictedPattern(importSource, group)) {
|
|
reportPathForPatterns(node, group, importNames);
|
|
}
|
|
});
|
|
}
|
|
|
|
return {
|
|
ImportDeclaration: checkNode,
|
|
ExportNamedDeclaration(node) {
|
|
if (node.source) {
|
|
checkNode(node);
|
|
}
|
|
},
|
|
ExportAllDeclaration: checkNode
|
|
};
|
|
}
|
|
};
|