robojerk/tumbi-assembler
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

iso-wrapper: Handle wrong implant md5

Browse source 
If the checkisomd5 command exits successfully but returns a wrong value,
we should catch and log that. In theory this should be impossible, but
we have seen it in production.

Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
This commit is contained in:
Lubomír Sedlář 2017-03-02 09:10:27 +01:00
parent 1647f7612a
commit cd805a1e6d
4 changed files with 57 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/test_createiso_phase.py
View file

@ -258,7 +258,7 @@ class CreateisoThreadTest(helpers.PungiTestCase):
[mock.call(get_runroot_cmd.return_value,
log_file='%s/logs/x86_64/createiso-image-name.x86_64.log' % self.topdir)])
self.assertEqual(iso.get_implanted_md5.call_args_list,
[mock.call(cmd['iso_path'])])
[mock.call(cmd['iso_path'], logger=compose._logger)])
self.assertEqual(iso.get_volume_id.call_args_list,
[mock.call(cmd['iso_path'])])
@ -323,7 +323,7 @@ class CreateisoThreadTest(helpers.PungiTestCase):
[mock.call(get_runroot_cmd.return_value,
log_file='%s/logs/src/createiso-image-name.src.log' % self.topdir)])
self.assertEqual(iso.get_implanted_md5.call_args_list,
[mock.call(cmd['iso_path'])])
[mock.call(cmd['iso_path'], logger=compose._logger)])
self.assertEqual(iso.get_volume_id.call_args_list,
[mock.call(cmd['iso_path'])])
@ -389,7 +389,7 @@ class CreateisoThreadTest(helpers.PungiTestCase):
[mock.call(get_runroot_cmd.return_value,
log_file='%s/logs/x86_64/createiso-image-name.x86_64.log' % self.topdir)])
self.assertEqual(iso.get_implanted_md5.call_args_list,
[mock.call(cmd['iso_path'])])
[mock.call(cmd['iso_path'], logger=compose._logger)])
self.assertEqual(iso.get_volume_id.call_args_list,
[mock.call(cmd['iso_path'])])
@ -552,7 +552,7 @@ class CreateisoThreadTest(helpers.PungiTestCase):
[mock.call(cmd['cmd'], show_cmd=True,
logfile='%s/logs/x86_64/createiso-image-name.x86_64.log' % self.topdir)])
self.assertEqual(iso.get_implanted_md5.call_args_list,
[mock.call(cmd['iso_path'])])
[mock.call(cmd['iso_path'], logger=compose._logger)])
self.assertEqual(iso.get_volume_id.call_args_list,
[mock.call(cmd['iso_path'])])