robojerk/tumbi-assembler
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove buffering when running koji commands

Browse source 
If the compose is aborted while koji tasks are running, we can be
left with empty log files. That complicates debugging.

JIRA: RHELCMP-1218

Signed-off-by: Ondrej Nosek <onosek@redhat.com>
This commit is contained in:
Ondrej Nosek 2020-07-02 09:32:05 +02:00
parent 54882a0fc4
commit d9f111edae
2 changed files with 41 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

47
tests/test_koji_wrapper.py
View file

@ -625,7 +625,8 @@ class RunrootKojiWrapperTest(KojiWrapperBaseTestCase):
mock.call(
cmd,
can_fail=True,
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
logfile=None,
show_cmd=True,
universal_newlines=True,
@ -653,7 +654,8 @@ class RunrootKojiWrapperTest(KojiWrapperBaseTestCase):
mock.call(
cmd,
can_fail=True,
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
logfile=None,
show_cmd=True,
universal_newlines=True,
@ -682,7 +684,12 @@ class RunrootKojiWrapperTest(KojiWrapperBaseTestCase):
mock.call(
cmd,
can_fail=True,
env={"KRB5CCNAME": "DIR:/tmp/foo", "FOO": "BAR"},
env={
"KRB5CCNAME": "DIR:/tmp/foo",
"FOO": "BAR",
"PYTHONUNBUFFERED": "1",
},
buffer_size=-1,
logfile=None,
show_cmd=True,
universal_newlines=True,
@ -708,7 +715,8 @@ class RunBlockingCmdTest(KojiWrapperBaseTestCase):
"cmd",
can_fail=True,
logfile=None,
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
universal_newlines=True,
)
],
@ -734,7 +742,12 @@ class RunBlockingCmdTest(KojiWrapperBaseTestCase):
"cmd",
can_fail=True,
logfile=None,
env={"KRB5CCNAME": "DIR:/tmp/foo", "FOO": "BAR"},
env={
"KRB5CCNAME": "DIR:/tmp/foo",
"FOO": "BAR",
"PYTHONUNBUFFERED": "1",
},
buffer_size=-1,
universal_newlines=True,
)
],
@ -756,7 +769,8 @@ class RunBlockingCmdTest(KojiWrapperBaseTestCase):
"cmd",
can_fail=True,
logfile="logfile",
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
universal_newlines=True,
)
],
@ -778,7 +792,8 @@ class RunBlockingCmdTest(KojiWrapperBaseTestCase):
"cmd",
can_fail=True,
logfile=None,
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
universal_newlines=True,
)
],
@ -800,7 +815,8 @@ class RunBlockingCmdTest(KojiWrapperBaseTestCase):
"cmd",
can_fail=True,
logfile=None,
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
universal_newlines=True,
)
],
@ -823,7 +839,8 @@ class RunBlockingCmdTest(KojiWrapperBaseTestCase):
"cmd",
can_fail=True,
logfile=None,
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
universal_newlines=True,
),
mock.call(
@ -851,7 +868,8 @@ class RunBlockingCmdTest(KojiWrapperBaseTestCase):
"cmd",
can_fail=True,
logfile=None,
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
universal_newlines=True,
),
mock.call(
@ -880,7 +898,8 @@ class RunBlockingCmdTest(KojiWrapperBaseTestCase):
"cmd",
can_fail=True,
logfile=None,
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
universal_newlines=True,
),
mock.call(
@ -922,7 +941,8 @@ class RunBlockingCmdTest(KojiWrapperBaseTestCase):
"cmd",
can_fail=True,
logfile=None,
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
universal_newlines=True,
),
mock.call(
@ -957,7 +977,8 @@ class RunBlockingCmdTest(KojiWrapperBaseTestCase):
"cmd",
can_fail=True,
logfile=None,
env=None,
env={"PYTHONUNBUFFERED": "1"},
buffer_size=-1,
universal_newlines=True,
),
mock.call(