Commit graph

189 commits

Author SHA1 Message Date
Simon de Vlieger
3eecad6b30 doc: fix typo
Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-10 09:28:05 +00:00
Michael Vogt
c3ca146161 main: fix creating output dir for --with-buildlog
Trivial fix for the missing `mkdir()` call when `--with-buildlog`
is specified (and the matching test update).
2025-03-07 13:17:10 +00:00
Simon de Vlieger
3fd0373bc0 packit: enable epel-9 and epel-10
Let's ship our package in epel-9 and epel-10 as well as all the
supported Fedora branches. I've manually created, built, and created
updates for these branches already.

I'm not adding automation to the epel-10.0 branch in this PR as we need
to probably consider that more carefully. However, I *have* submitted
version 13 for epel-10.0 manually.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-07 11:56:32 +00:00
dependabot[bot]
1087fd7187 build(deps): bump github.com/cheggaaa/pb/v3 in the go-deps group
Bumps the go-deps group with 1 update: [github.com/cheggaaa/pb/v3](https://github.com/cheggaaa/pb).


Updates `github.com/cheggaaa/pb/v3` from 3.1.6 to 3.1.7
- [Commits](https://github.com/cheggaaa/pb/compare/v3.1.6...v3.1.7)

---
updated-dependencies:
- dependency-name: github.com/cheggaaa/pb/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-deps
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-03-05 08:28:39 +00:00
schutzbot
e03922e299 Post release version bump
[skip ci]
2025-03-05 08:19:49 +00:00
Simon de Vlieger
dfa58fd6b5 chore: bump deps
Bump to latest `images` to make Fedora Minimal work with all the new
bits and bobs. Manual PR because the other one was being weird.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-04 21:15:50 +00:00
Simon de Vlieger
0cc171e1f9 doc: build command
Introduce the `build` command.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-04 09:13:51 +00:00
Simon de Vlieger
ca7ea33765 doc: rename output -> format
Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-04 09:13:51 +00:00
Simon de Vlieger
08f8c13c5c doc: list-images
Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-04 09:13:51 +00:00
Simon de Vlieger
887d3fee22 doc: sudo for build
Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-04 09:13:51 +00:00
Simon de Vlieger
6b97573d2e doc: provide links in FAQ
Fill in the links that were placeholders to the appropriate places.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-04 09:13:51 +00:00
Simon de Vlieger
dd954a7c6b doc: fix up Go installation
The Go example had a superfluous build argument and a missing build
argument.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-04 09:13:51 +00:00
Simon de Vlieger
9064036048 doc: drop arguments from install examples
Drop the arguments from the install examples to keep the commands easier
to read. Arguments to be introduced under "usage".

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-04 09:13:51 +00:00
Simon de Vlieger
cefe2f8527 readme: update installation instructions
Mention installability in Fedora. Provide COPR enable instructions.
Mention the container.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-03-03 10:37:39 +00:00
Simon de Vlieger
4d9cf723fd main: rename output to format
We had a chat about this and we feel that `format` is less ambiguous a
name for this argument.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-02-27 10:58:11 +00:00
Simon de Vlieger
58aa0cf87b main: rename basedir -> base-dir
Rename the `basedir` argument to be consistent with `output-dir`
by hyphenation.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-02-27 10:58:11 +00:00
Michael Vogt
2e741a70ad main: add build --with-buildlog
This commit adds a new `--with-buildlog` option that will automatically
create a buildlog in the output directory.
2025-02-25 12:08:51 +00:00
Michael Vogt
55d3b4916a go.mod: update to latest "bib" version 2025-02-25 12:08:51 +00:00
schutzbot
444c6cf087 Post release version bump
[skip ci]
2025-02-19 08:19:11 +00:00
Lukas Zapletal
6dd8515801 main: simplify upload error handling 2025-02-18 09:49:16 +00:00
Lukas Zapletal
8d03b2215c build: add bin/ to gitignore 2025-02-18 09:49:16 +00:00
schutzbot
ef8b8328cb Post release version bump
[skip ci]
2025-02-14 11:25:17 +00:00
Michael Vogt
a8d6751e19 docs: describe the way to add/override repositories
This commit adds some documentation on how the repositories can
be manipulated.
2025-02-13 11:31:06 +00:00
Michael Vogt
bc5be2ba8a main: add --force-repo flag
This commit adds an `--force-repo` flag that can be used
to replace all the base repositories with a base url to
a repository. This is useful for testing but also dangerous
as it will not do any checks and happily use a fedora-42 repository
for centos-8 depsolving.

This will make the use-case of the koji builder easier and is
also something that the `build` tool in `images` supports.
2025-02-13 11:31:06 +00:00
Michael Vogt
e2aeecec8e repos: make clearer why newRepoRegistry is a var
This commit reworks the `newRepoRegistry` func so that its easier
to see that it is a variable so that it can be overriden by the
tests. In the tests we want to use the `testrepos` we get from
images and in the real implementation we want to use the full
repo loader with search-paths and extra repos.
2025-02-12 12:57:27 +01:00
Michael Vogt
5f6d59013f go.mod: update to latest images release to get images PR#1211 2025-02-12 12:57:27 +01:00
Michael Vogt
a11e124133 main: add new --extra-repo flag
This commit adds a  new flag `--extra-repo` that can be used
to point to a repository url that is added to the base
repositories when depsolving. Note that *no* gpg checking
will be performed for such repos as there is no way to
add gpg-keys (yet) via this mechanism.

This means that with a repo created with e.g. `createrepo_c` like
```console
$ mkdir repo
$ (cd repo && dnf download hello)
$ createrepo_c ./repo
```
and a blueprint like:
```toml
[[packages]]
name = "hello"
```
a manifest is generated that gets hello from this local repo:
```console
$ image-builder  --extra-repo file:$(pwd)/repo manifest qcow2 --distro centos-9 --blueprint ./bp.toml |jq|grep hello
          "path": "hello-2.12.1-5.fc41.x86_64.rpm",
```
Note that this is part of the base repositories so anything with a
higher version number will get pulled from the extra-repo, even
system libraries or kernels. Note also that this repository does
not become part of the image so after the image build all rpms
from there are not updated (unless of course the normal repos
have higher versions of them).

Note as well that there is no safeguard right now against adding
extra repos for the wrong version of the distro, i.e. one could
add an extra repo build against/for fedora-42 on a fedora-40 image
which most likely will break with bad depsolve errors. But that
is okay, this option is meant for advanced users and testing.
2025-02-12 12:57:21 +01:00
Michael Vogt
25f21a3205 main: add upload support directly to build
This commit adds support to upload the build image directly to
the target cloud. Currently only ami/AWS is supported.

If the cloud specific configuration is given at the commandline
and the image type is a cloud image the cloud upload will happen
automatically (just like with bib). Incomplete upload config is
an error.
2025-02-11 13:38:04 +01:00
Michael Vogt
e41377b82a main: add new upload command
This commit adds a new `upload` command that can be used to
upload a raw image to the cloud. Currently only AWS is
supported but as images adds more clouds to the uploader interfac
we can easily expand more.

The cloud is currently detected via the file extension, that
mapping probably should also go into the `images` library.
2025-02-11 13:38:04 +01:00
Michael Vogt
0678d8ddfd main: update for new reporegistry.New() api (c.f. pr#1179)
This commit updates ibcli for the new API in images for the
`reporegistry.New()`. The main incompatible change is that the
`/repositories` part is not longer automatically added inside
the library so we need to add it on the call-site.

This needs https://github.com/osbuild/images/pull/1179
2025-02-10 20:40:56 +01:00
Michael Vogt
1a14f5bae3 go.mod: update images to v0.116.0 2025-02-10 20:40:53 +01:00
Michael Vogt
0a3c642772 go.mod: update to get the latest progress fixes from bib
This commit updates the `progress` package to get the latest
fixes, most notably
https://github.com/osbuild/bootc-image-builder/pull/820
2025-02-10 11:46:55 +01:00
Simon de Vlieger
036de52a39
describeimg: typo in describe output
`os_vesion` -> `os_version`

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-02-06 20:00:49 +01:00
Michael Vogt
7c6db68c98 main: add -v,--verbose switch that enables verbose build logging
This commit adds a new `-v,--verbose` switch that enables verbose
build logging.

Closes: https://github.com/osbuild/image-builder-cli/issues/112
2025-02-05 09:36:38 +00:00
schutzbot
8b09755cab Post release version bump
[skip ci]
2025-02-05 08:17:38 +00:00
Michael Vogt
19ef77337a main: reset the terminal properly on SIGINT,SIGTERM
This commit fixes the issue that on `CTRL-C` (SIGINT) the progress
is not properly cleared. It also catches SIGTERM for good measure.

No test right now as this is hard to test automatically :/

Closes: https://github.com/osbuild/image-builder-cli/issues/123
2025-02-04 13:11:11 +00:00
Michael Vogt
24dc23ac3b main: fix auto-detected distro that is non-visible, tweak order
This commit fixes the issue that the auto-detect distro is not
visible in the progress message. It also tweaks the order of
the message to show:
```
Building manifest for <distro>-<img-type>
```
to be more conistent.

Closes: https://github.com/osbuild/image-builder-cli/issues/121
2025-02-04 12:21:13 +00:00
schutzbot
fdab539045 Post release version bump
[skip ci]
2025-02-03 13:23:26 +00:00
Simon de Vlieger
379c97456b ci/packit: set downstream name
Since our upstream repository name differs from the downstream name we
should set the `downstream_package_name` [1] config option.

[1]: https://packit.dev/docs/configuration#downstream_package_name

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-02-03 11:28:26 +00:00
Simon de Vlieger
f9ff8ffbf1 specfile: build requires libxcrypt-compat
We received a commit downstream by Björn Esser. After asking around for
the reasoning behind the commit it seems that we're likely assuming that
this package is available in the buildroot.

Let's depend on it explicitly instead of assuming it is there.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-02-03 11:27:37 +00:00
schutzbot
44d6622ba9 Post release version bump
[skip ci]
2025-02-03 08:38:08 +00:00
Simon de Vlieger
29e7814796 ci/packit: enable fedora PRs
Enable automatic builds and PR creation in Fedora since `image-builder`
has landed there.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-02-03 08:26:21 +00:00
Michael Vogt
3c2e8dd9af cmd: add new describe-image command
This commit adds a new `describe-image` comamnd that contains
the details about the given image type. The output is yaml as
it is both nicely human readable and also machine readable.

Note that this version carries an invalid yaml header on
purpose to avoid people replying on the feature for scripts
before it is stable.

The output looks like this:
```yaml
$ ./image-builder describe-image rhel-9.1 tar
@WARNING - the output format is not stable yet and may change
distro: rhel-9.1
type: tar
arch: x86_64
os_vesion: "9.1"
bootmode: none
partition_type: ""
default_filename: root.tar.xz
packages:
  include:
    - policycoreutils
    - selinux-policy-targeted
    - selinux-policy-targeted
  exclude:
    - rng-tools
```

Thanks to Ondrej Budai for the idea and the example.
2025-01-31 10:57:50 +00:00
Simon de Vlieger
2455b9d586 doc: initial documentation
Supply initial documentation for `image-builder`. This documentation
will be imported into the osbuild [1] website.

[1]: https://osbuild.org/

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-01-31 08:06:22 +00:00
Michael Vogt
c590c38d4f main: silence all logrus logging for now
This commit silences logrus logging for now by just dicarding
everything from it. The rational is that the underlying libraries
produce a lot of output, e.g. every build currently results in
```console
$ image-builder build qcow2
WARN[0000] Failed to load consumer certs: no consumer key found
...
```
which is confusing to our users. What is worse is that containers
also uses logrus so we can get random warnings without context
from there too. Until we have a way to filter log messages this
seems to be the most practical way.

We can add `--verbose` or `--debug` later to enable these kinds
of messages.
2025-01-30 17:30:31 +00:00
Michael Vogt
0f0815d268 main: tweak the help of manifest and build
This commit tweaks the help output for the manifest and build
commands to make clear that only the image type is a required
argument but the rest can be overriden via extra flags.

Thanks to Achilleas for noticing.
2025-01-29 20:50:47 +00:00
Michael Vogt
c72ed92a2f Containerfile: build without cgo to avoid arm64 crashing
This commit changes the build to not build with CGO. There is really
no need to build with CGO, we only need it for the `crypt()` version
in the images library. However since with the merge of
https://github.com/osbuild/images/pull/1114
that is no longer an issue.
2025-01-29 20:50:10 +00:00
Michael Vogt
f46ca14f85 image-builder: update TestBuildIntegrationErrors tests
This commit updates the tests for the error reporting. Since
we are now using the new "progress" module we can no longer
directly mock osStderr. So this now uses the new testutil
helper `CaptureStdio`.

Note also that the behavior of `verbose` and `term` is slightly
different - for backward compatibility in `verbose` mode the
stderr from osbuild is directly connected to the caller stderr.

For term mode this is not done to prevent spurious message from
leaking into the terminal progress and the full error is available
from the actual go error as captured output.
2025-01-29 15:21:33 +00:00
Michael Vogt
e41cf0e429 testutil: add new CaptureStdio helper
This commit adds a new testutil.CaptureStdio helper so that we
can test external go modules that use os.Std{out,err} but now
allow mocking or overwriting.
2025-01-29 15:21:33 +00:00
Michael Vogt
c78ea5f2b2 test: add test that checks that --progress works correctly
This commit checks that the `--progress` argument generates the
expected output, i.e. with `term` we will not get any osbuild
output and the spinner. And with `verbose` we will not get a
spinner and the osbuild output.
2025-01-29 15:21:33 +00:00