particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

internal/container: delete leftover dead code

Browse source 
This issue was found by Coverity:

Error: DEADCODE (CWE-561): [#def1]
osbuild-composer-58/_build/src/github.com/osbuild/osbuild-composer/internal/container/client.go:386: cond_null: Condition "err != nil", taking false branch. Now the value of "err" is "nil".
osbuild-composer-58/_build/src/github.com/osbuild/osbuild-composer/internal/container/client.go:390: null: At condition "err != nil", the value of "err" must be "nil".
osbuild-composer-58/_build/src/github.com/osbuild/osbuild-composer/internal/container/client.go:390: dead_error_condition: The condition "err != nil" cannot be true.
osbuild-composer-58/_build/src/github.com/osbuild/osbuild-composer/internal/container/client.go:391: dead_error_line: Execution cannot reach this statement: "<temporary>.$0 = container....".
  389|
  390|   	if err != nil {
  391|-> 		return resolvedIds{}, nil
  392|   	}
  393|
This commit is contained in:
Tomas Hozza 2022-07-29 10:37:28 +02:00 • committed by Christian Kellner
parent e3de1d03c0
commit 322ae02f73
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
internal/container/client.go
View file

@ -387,10 +387,6 @@ func (cl *Client) resolveManifestList(ctx context.Context, list manifestList) (r
return resolvedIds{}, fmt.Errorf("error getting manifest: %w", err)
}
if err != nil {
return resolvedIds{}, nil
}
return cl.resolveRawManifest(ctx, raw)
}