When the worker executor starts up, many error messages and warnings are
shown in the system logs, worker-initialization.service should actually
not run at all. The service crashes and functionally that's fine, but
it just messes up the log, raises questions and can be avoided by just
not running it.
The test was importing `distro/rhel/rhel9` directly instead
of using the `distrofactory`. This is problematic as the go
module for `rhel9` is going away. This commit fixes this
by going via the `distrofactory` which will keep working.
Previously, the script didn't distinguish between the scheduled RHEL-X
nightly pipeline and the scheduled RHEL GA pipeline when reporting
status back to GitHub. Moreover the scheduled RHEL GA pipeline on GitLab
had RHEL_MAJOR variable set to "9". As a result, the scheduled RHEL GA
pipeline status has been reported to GitHub as "Schutzbot on GitLab,
RHEL-9-nightly", which effectively overrode the RHEL-9 nightly pipeline
status for the same commit.
Fix the script reporting the status back to GitHub, to take the NIGHLY
variable value into consideration when building up the status context.
I've also modified the RHEL GA scheduled pipeline settings in GitLab to
not specify any RHEL_MAJOR, which was a relict from pre-RHEL-10 days.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
These releases are already GA. For 9.6 and 10.0, we test them in a
scheduled GA pipeline, which runs the CI tests on GA runners, which
don't have RH VPN access. Previously, some tests in the GA pipeline
would fail, because they would use rpmrepo snapshots of nightly composes
for these releases, which are behind RH VPN. Change the test repo
definitions to use CDN repositories instead, which should fix the GA
pipeline.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Adjust the test case, so that it does not fail when run against older
osbuild-composer version, i.e. the one from RHEL-10 nightly CI pipelines.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
We have an issue where `%post` scripts are not being executed due to our incorrect handling of Anaconda modules [1].
[1]: https://github.com/osbuild/bootc-image-builder/issues/968
Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Fix RHEL 10 mock confings not being created if the machine was subscribed and fix RHEL 9 being used in the RHEL 10 mock confings for a repo path.
These issues caused the rpm jobs for RHEL 10 GA to fail.
Add new GA runners and remove the old 9.5 GA runner. Remove repo overrides for new runners as well. Add a comment explaining why a regression-old-worker-new-composer test will fail when a new major version GA runner is added.
The latest version of osbuild/blueprint changed some BP properties
to be 'omitempty', thus the expected API responses need to be adjusted
to account for this change.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Delete the `internal/upload/koji` package and replace it with
`pkg/upload/koji` package provided by `osbuild/images`.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Use the version that contains the updated Koji upload code.
Also bump the version of `osbuild/blueprint` due to the new `uri` field
in file customizations.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
For RHEL-10, we have a special version of RHEL-8 repositories, that do
not contain the auxiliary key. This is due to the fact that the key uses
SHA-1, which is not allowed by default by RHEL-10 crypto policy.
We deleted repositories for these releases in osbuild/images, but we
need to delete them also here, to ensure that they don't end up in the
RPMs and that the cross-distro test case does not fail.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
tag v0.155.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.155.0
----------------
* Fedora 43: add shadow-utils when LockRoot is enabled, update cloud-init service name (osbuild/images#1618)
* Author: Achilleas Koutsou, Reviewers: Gianluca Zuccarelli, Michael Vogt
* Update osbuild dependency commit ID to latest (osbuild/images#1609)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza
* Update snapshots to 20250626 (osbuild/images#1623)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro/rhel9: xz compress azure-cvm image type [HMS-8587] (osbuild/images#1620)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro/rhel: introduce new image type: Azure SAP Apps [HMS-8738] (osbuild/images#1612)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro/rhel: move ansible-core to sap_extras_pkgset (osbuild/images#1624)
* Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Tomáš Hozza
* github/create-tag: allow passing the version when run manually (osbuild/images#1621)
* Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza
* rhel9: move image-config into pure YAML (HMS-8593) (osbuild/images#1616)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* test: split manifest checksums into separate files (osbuild/images#1625)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
— Somewhere on the Internet, 2025-06-30
---
tag v0.156.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.156.0
----------------
* Many: delete repositories for EOL distributions (HMS-7044) (osbuild/images#1607)
* Author: Tomáš Hozza, Reviewers: Michael Vogt, Simon de Vlieger
* RHSM/facts: add 'image-builder CLI' API type (osbuild/images#1640)
* Author: Tomáš Hozza, Reviewers: Brian C. Lane, Simon de Vlieger
* Update dependencies 2025-06-29 (osbuild/images#1628)
* Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
* Update osbuild dependency commit ID to latest (osbuild/images#1627)
* Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
* [RFC] image: drop `InstallWeakDeps` from image.DiskImage (osbuild/images#1642)
* Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger, Tomáš Hozza
* build(deps): bump the go-deps group across 1 directory with 3 updates (osbuild/images#1632)
* Author: dependabot[bot], Reviewers: SchutzBot, Tomáš Hozza
* distro/rhel10: xz compress azure-cvm image type (osbuild/images#1638)
* Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Simon de Vlieger
* distro: cleanup/refactor distro/{defs,generic} (HMS-8744) (osbuild/images#1570)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro: remove some hardcoded values from generic/images.go (osbuild/images#1636)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro: small tweaks for the YAML based imagetypes (osbuild/images#1622)
* Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger
* fedora/wsl: packages and locale (osbuild/images#1635)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza
* image/many: make compression more generic (osbuild/images#1634)
* Author: Simon de Vlieger, Reviewers: Brian C. Lane, Michael Vogt
* manifest: handle content template name with spaces (osbuild/images#1641)
* Author: Bryttanie, Reviewers: Brian C. Lane, Michael Vogt, Tomáš Hozza
* many: implement gzip (osbuild/images#1633)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza
* rhel/azure: set GRUB_TERMINAL based on architecture [RHEL-91383] (osbuild/images#1626)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
— Somewhere on the Internet, 2025-07-07
---
The most common one is going to be trying to delete a compose before it
is finished, and that is certainly not worthy of a 500 server error
since it is a temporary state.
tag v0.152.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.152.0
----------------
* Update snapshots to 20250605 (osbuild/images#1586)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro: followups for reivew feedback in PR#1563 (osbuild/images#1584)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza
* fedora/wsl: xz compression (HMS-8573) (osbuild/images#1582)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Florian Schüller
— Somewhere on the Internet, 2025-06-16
---
tag v0.153.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.153.0
----------------
* GHA: enable the stale action to delete its saved state (osbuild/images#1602)
* Author: Tomáš Hozza, Reviewers: Lukáš Zapletal, Simon de Vlieger
* Smaller isos (osbuild/images#1599)
* Author: Brian C. Lane, Reviewers: Lukáš Zapletal, Simon de Vlieger
* Update snapshots to 20250618 (osbuild/images#1603)
* Author: SchutzBot, Reviewers: Brian C. Lane, Simon de Vlieger
* distro/rhel-10: WSL distribution config (HMS-8573) (osbuild/images#1591)
* Author: Simon de Vlieger, Reviewers: Gianluca Zuccarelli, Lukáš Zapletal, Tomáš Hozza
* distro/rhel-10: new `vagrant-libvirt` image type (HMS-6116) (osbuild/images#1601)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza
* distro/rhel{8,9,10}: WSL extension and compression (HMS-8573) (osbuild/images#1590)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza
* distro: handle `centos-9` and similar versions better (osbuild/images#1598)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* osbuild/grub2: add compat_version and set it to 2 (osbuild/images#1595)
* Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Tomáš Hozza
— Somewhere on the Internet, 2025-06-20
---
Delete the osbuild-koji tools, which is not used by any code or test
case. This also allows to delete the koji.NewFromPlain() function. This
is to minimize the set of exported functions by the koji package, before
moving it to osbuild/images repository.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Modify the Koji image extra metadata to not depend on the upload target
data structure for the OSBuild Artifact. This is the last dependency on
the internal osbuild-composer package, allowing the move of the Koji
upload code to the osbuild/images repository.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Modify the Koji image extra metadata to not depend on the upload target
data structures for upload results. The target results are supposed to
be specific to the uploader implementation, which will eventually
change. Moreover, the definition is internal to osbuild-composer, so
this would create a problem once the Koji upload implementation is moved
to osbuild/images.
The Koji upload implementation does not really care about the exact
structure of the upload results. It is just a list of JSON objects.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The use of rpmmd.RPM is exclusive to the Koji upload implementation.
Consolidate the metadata structure for RPMs into the koji package
codebase, together with any required functions for converting osbuild
stage metadata. The respective code in osbuild/images will be eventually
removed.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Increase readability by logically splitting the build metadata
structures from the actual upload API implementation.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The upload/koji package functions were creating a logger and then were
using it. This is not ideal for a library implementation.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Don't create a new transport in NewFromPlain() using
CreateRetryableTransport(), because the only place
in which NewFromPlain() is called passes the return value of
CreateRetryableTransport() when calling it.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
RHUI-3 has been EOL on RHEL-8 and it is no longer being updated and we
do not take new snapshots of it. Use RHUI-4 instead. More info in [1].
It turns out, that the previously used RHUI-3 snapshot was missing
amazon-libdnf-plugin package, wich is required by the RHUI client.
As a result, the "weldr dot-notation" test has been failing in the GA
pipeline on RHEL-8. We do not run the test case on RHEL-8 in PRs of
`main` pipeline, because we test only on nightly composes and there are
no new releases being developed for RHEL-8. Therefore this was
manifesting only in the GA pipeline runs.
This change should fix the failures in the GA pipeline.
[1] https://github.com/osbuild/rpmrepo/pull/119
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
tag v0.149.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.149.0
----------------
* Update dependencies 2025-05-25 (osbuild/images#1560)
* Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
* Update osbuild dependency commit ID to latest (osbuild/images#1522)
* Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
* Update snapshots to 20250515 (osbuild/images#1524)
* Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
* `vagrant-libvirt` implementation (HMS-6116) (osbuild/images#1548)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Tomáš Hozza
* fedora: tweaks after all imageTypes are YAML (osbuild/images#1518)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* gha: do not break gobump output (osbuild/images#1561)
* Author: Lukáš Zapletal, Reviewers: Simon de Vlieger, Tomáš Hozza
* repositories: AlmaLinux 10 (osbuild/images#1567)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal, Neal Gompa (ニール・ゴンパ)
* vagrant: image config for default vagrant user (HMS-6116) (osbuild/images#1565)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Michael Vogt
— Somewhere on the Internet, 2025-05-27
---
tag v0.150.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.150.0
----------------
* Replace hardcoded kickstart %post scripts with new stage options and bootc switch with custom kickstart content (HMS-6051) (osbuild/images#1527)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
* test: install yamllint for tests (osbuild/images#1572)
* Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza
— Somewhere on the Internet, 2025-06-02
---
tag v0.151.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.151.0
----------------
* Introduce new Azure CVM image type (HMS-5636) (osbuild/images#1318)
* Author: Achilleas Koutsou, Reviewers: Nobody
* Many: support using string with unit for byte-sized partitioning fields in YAML distro definitions (osbuild/images#1579)
* Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Brian C. Lane
* Update osbuild dependency commit ID to latest (osbuild/images#1587)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza
* Update snapshots to 20250601 (osbuild/images#1573)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Lukáš Zapletal
* bootc: Make installed rootfs configurable (osbuild/images#1555)
* Author: Mbarak Bujra, Reviewers: Michael Vogt, Tomáš Hozza
* distro: create new ImageConfig.DNFConfig (osbuild/images#1583)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro: make "fedora" a "generic" distro (osbuild/images#1563)
* Author: Michael Vogt, Reviewers: Nobody
* image: If using a separate build container, copy bootc customization to it (osbuild/images#1571)
* Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Tomáš Hozza
* manifest/ostree: explicitly include shadow-utils (osbuild/images#1585)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Michael Vogt
* osbuild/tar: explicit compression (HMS-8573, HMS-6116) (osbuild/images#1581)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Tomáš Hozza
* tests: bump fedora versions to 41 (osbuild/images#1438)
* Author: Lukáš Zapletal, Reviewers: Brian C. Lane, Michael Vogt
— Somewhere on the Internet, 2025-06-09
---
These test have been failing consistently for very long time (many
months). They need to be investigated and fixed before re-enabling them.
The ticket to re-enable them is:
https://issues.redhat.com/browse/HMS-8719
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
