Start embedding the awscloud.AWS from osbuild/images in
osbuild-composer's version of awscloud.AWS. The idea is to remove all
methods from osbuild-composer implementation, which are used for
uploading and registering images in AWS. The rest that it related to
service maintenance or to running secure instances, will be kept in
osbuild-composer, since these are specific to the project.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
With the upload code consolidation to osbuild/images, we need to make
sure to configure the logger used by the library to keep logging the
same (or similar) messages when running osbuild-composer.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The changes to the TestComposeUnsupportedMountPointV0() test case when
the osbuild/images has been updated to v0.172.0 broke the RHEL nightly
and GA CI pipelines.
Change the test to be backward compatible with osbuild/images <
v0.172.0.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The v36.0 release of weldr-client/composer-cli will include support for
cloudapi commands. This adjusts the tests so that they will work with
the new version while maintaining compatibility with the previous
version.
Related: RHEL-60123
The internal blueprint implementation has been removed from
osbuild/images. Conversion from osbuild/blueprint blueprints to
osbuild/images blueprints is no longer necessary.
The test manifests don't have any use in this repository, since the
osbuild-image-tests command has been removed. Likewise, generating
testing manifests is no longer needed in this repository, therefore
remove the gen-manifests command.
Manifests are being generated in the osbuild/images repository and the
necessary tooling to generate them lives there.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Delete the no longer used osbuild-images-tests command. Subsequently,
delete the /internal/boot packages, which were used only by the command
and also depended on its data structures.
Technically, no boot test were done using the code in this repository
for quite some time. And the long term plan is to boot test all images
in the osbuild/images repository.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The image_tests.sh test case is being run only as part of the RHEL
nightly pipeline. This test case evolved over the years. In principle
it can do the following:
1. Read test cases from /test/data/manifests.
2. Rebuild the manifest attached to the test case directly by running
osbuild.
3. Compare the image-info report if attached to the test case (NOT
done for any test cases in /test/data/manifests).
4. Boot-test the built image in the respective environment (NOT done
for any test cases in /test/data/manifests).
Moreover, these manifests (or test cases) are not updated regularly
after being generated for the first time.
All in all, given the fact that the test case rebuilds outdated
manifests by directly calling osbuild and does not run any additional
tests, it adds no value compared to the osbuild/images CI.
osbuild/images CI always rebuilds the latest image definition version
manifests with osbuild, so at the time the library is updated in
osbuild-composer, this scenario has already been tested.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
This uses the blueprint and the image type's manifest with a minimal
imageRequest to get the package sets to use for depsolving, instead of
just using the packages in the blueprint.
This does not work with iot image types that require an ostree url.
Depsolving iot commits doesn't make sense anyway, since the blueprint
packages have no effect on it.
Includes simple tests for depsolving with image type, and returning an
error if the image type isn't recognized.
Related: RHEL-60125
The oapi-codegen update to v2.5.0 changed the Details field of the main
Error type to be an empty interface. This requires updates to the error
handling tests to accommodate the new structure.
v1.60 seems to have some issues [1] with something in our dependency
chain. Update to v1.61 and fix all new issues.
New issues are all instances of potential integer overflow from int ->
uint conversions. Added guards where appropriate and disabled the check
when when it's not needed.
[1] https://github.com/osbuild/osbuild-composer/actions/runs/16624417387/job/47037518471
tag v0.165.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.165.0
----------------
* distro: move rhel9 into a generic distro (osbuild/images#1645)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* Revert "distro: drop `ImageType.BasePartitionTable()`" (osbuild/images#1691)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* Update dependencies 2025-07-20 (osbuild/images#1675)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger
* defs: add missing `bootstrap_containers` (osbuild/images#1679)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* disk: handle adding `PReP` partition on PPC64/s390x (HMS-8884) (osbuild/images#1681)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro: bring per-distro checkOptions back (osbuild/images#1678)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro: cleanups in the pkg/distro/generic area (osbuild/images#1686)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro: move rhel8 into a generic distro (osbuild/images#1643)
* Author: Michael Vogt, Reviewers: Nobody
* distro: small followups for PR#1682 (osbuild/images#1689)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza
* distro: unify transform/match into a single concept (osbuild/images#1682)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza
* distros: de-duplicate runner build packages for centos10 (osbuild/images#1680)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* github: disable Go dep updates through dependabot (osbuild/images#1683)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
* repos: include almalinux 9.6 (osbuild/images#1677)
* Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza
* rhel9: wsl distribution config (osbuild/images#1694)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers
* test/manifests/all-customizations: don't embed local file via URI (osbuild/images#1684)
* Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Brian C. Lane
— Somewhere on the Internet, 2025-07-28
---
tag v0.166.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.166.0
----------------
* customizations/subscription: conditionally enable semanage call (HMS-8866) (osbuild/images#1673)
* Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Michael Vogt
* distro/rhel-10: versionlock shim-x64 in the azure-cvm image (osbuild/images#1697)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger
* manifestmock: move container/pkg/commit mocks into helper (osbuild/images#1700)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* rhel9: `vagrant-libvirt`, `vagrant-virtualbox` (osbuild/images#1693)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers
* rhel{9,10}: centos WSL refinement (HMS-8922) (osbuild/images#1690)
* Author: Simon de Vlieger, Reviewers: Ondřej Budai, Sanne Raymaekers, Tomáš Hozza
— Somewhere on the Internet, 2025-07-29
---
tag v0.167.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.167.0
----------------
* RHEL/Azure: drop obsolete WAAgentConfig keys [RHEL-93894] and remove loglevel kernel option [RHEL-102372] (osbuild/images#1611)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Ondřej Budai, Sanne Raymaekers
* Update dependencies 2025-07-27 (osbuild/images#1699)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro/rhel9: set default_kernel to kernel-uki-virt (osbuild/images#1704)
* Author: Achilleas Koutsou, Reviewers: Ondřej Budai, Simon de Vlieger
* distro: drop legacy loaders and update tests (osbuild/images#1687)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza
* distro: fix issues with yaml distro definitions and enable yaml checks (osbuild/images#1702)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Ondřej Budai, Simon de Vlieger
— Somewhere on the Internet, 2025-07-30
---
tag v0.168.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.168.0
----------------
* distro: fix bug in variable substitution for static distros (osbuild/images#1710)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* rhel{9,10}: azure for non-RHEL (HMS-8949) (osbuild/images#1707)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Michael Vogt
— Somewhere on the Internet, 2025-07-30
---
The newly added gobump was using the default token but this one is not
configured with all required permissions for this repo. This was causing
tests not being executed on github.
Migration 9 alters the result column in the jobs table is relied on for
compose statuses. Because it has to be kept consistent across
migrations, add a test to verify this.
As a side effect, the test itself handles the migration now, so remove
that part from the tests GHA.
Postgres doesn't accept `\u0000` in the jsonb datatype. Switch to the
json datatype which is larger and slower, but accepts escaped null
bytes.
As we don't actually query or index the result jsonb directly, the
impact of this should be minimal.
See: https://www.postgresql.org/docs/current/datatype-json.html
When the worker executor starts up, many error messages and warnings are
shown in the system logs, worker-initialization.service should actually
not run at all. The service crashes and functionally that's fine, but
it just messes up the log, raises questions and can be avoided by just
not running it.
The test was importing `distro/rhel/rhel9` directly instead
of using the `distrofactory`. This is problematic as the go
module for `rhel9` is going away. This commit fixes this
by going via the `distrofactory` which will keep working.
Previously, the script didn't distinguish between the scheduled RHEL-X
nightly pipeline and the scheduled RHEL GA pipeline when reporting
status back to GitHub. Moreover the scheduled RHEL GA pipeline on GitLab
had RHEL_MAJOR variable set to "9". As a result, the scheduled RHEL GA
pipeline status has been reported to GitHub as "Schutzbot on GitLab,
RHEL-9-nightly", which effectively overrode the RHEL-9 nightly pipeline
status for the same commit.
Fix the script reporting the status back to GitHub, to take the NIGHLY
variable value into consideration when building up the status context.
I've also modified the RHEL GA scheduled pipeline settings in GitLab to
not specify any RHEL_MAJOR, which was a relict from pre-RHEL-10 days.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
These releases are already GA. For 9.6 and 10.0, we test them in a
scheduled GA pipeline, which runs the CI tests on GA runners, which
don't have RH VPN access. Previously, some tests in the GA pipeline
would fail, because they would use rpmrepo snapshots of nightly composes
for these releases, which are behind RH VPN. Change the test repo
definitions to use CDN repositories instead, which should fix the GA
pipeline.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Adjust the test case, so that it does not fail when run against older
osbuild-composer version, i.e. the one from RHEL-10 nightly CI pipelines.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
We have an issue where `%post` scripts are not being executed due to our incorrect handling of Anaconda modules [1].
[1]: https://github.com/osbuild/bootc-image-builder/issues/968
Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Fix RHEL 10 mock confings not being created if the machine was subscribed and fix RHEL 9 being used in the RHEL 10 mock confings for a repo path.
These issues caused the rpm jobs for RHEL 10 GA to fail.
Add new GA runners and remove the old 9.5 GA runner. Remove repo overrides for new runners as well. Add a comment explaining why a regression-old-worker-new-composer test will fail when a new major version GA runner is added.
