This commit removes the direct use of `pkg/distro/fedora` and
uses `distrofactory` instead. This is the more generic interface,
it also helps with PR#1563 as `pkg/distro/fedora` goes away.
Note that I did not test this but @bcl was kind enough to
mention how this is used:
```
The output from this is used in Test_upgrade in
internal/store/json_test.go, the files there are manually
created when we change the format of the store and add a new
parser to internal/store/json.go -- which hasn't happened in
a long time :)
```
I updated the cmd/README with a snippet of the above.
The cross distro test started failing on RHEL 10.1, because the osbuild/images version was a Go pseudo-version that the sed command parsing the version did not recognize.
In repository files for RHEL 9.7 and 10.1, there were missing slashes at the end of the baseurl which caused the satellite regression tests to fail. The refresh job only subs the snapshot dates and leaves the rest of the url unchanged.
Update the RHEL-9 Cloud Access images used for our workers from 9.0 to
9.6, which is the latest GA. We do upgrade all packages in our Ansible
playbook, but that is just waste of resources if we can use the latest
GA images.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Update Fedora workers from EOL F40 to F42.
Remove workarounds that should not be needed any more (i.e. the Packer
upstream issue has been closed).
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The `cloud-init.target` in 9.6 has `After=multi-user.target` in its unit
config. The worker initialization service was set to run before
`multi-user.target`, but after `cloud-final.service`. This created an
impossible situation and systemd just disabling the initialization
service.
So this changes:
`multi-user.target -> worker-*.service -> cloud-final.service -> multi-user.target`
to
`cloud-init.target -> worker-*.service -> cloud-final.service -> multi-user.target`.
Thus resolving the loop.
tag v0.144.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.144.0
----------------
* customizations: drop `FsNode` interface as it is not used (#1490)
* Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger
* distro/rhel10/ami: unset authselect in ImageConfig (COMPOSER-2517) (#1469)
* Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Michael Vogt
* manifest/os: immediately create directories (HMS-6043) (#1502)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Michael Vogt
* osbuild: Add config to InsightsClientConfigStageOptions (#1503)
* Author: rverdile, Reviewers: Michael Vogt, Sanne Raymaekers
* refactor: replace logrus with stdlib log package (#1481)
* Author: Lukáš Zapletal, Reviewers: Michael Vogt, Simon de Vlieger
— Somewhere on the Internet, 2025-05-08
tag v0.142.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.142.0
----------------
* distro: move `kernelOptions` into `ImageConfig` (osbuild/images#1470)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza
* manifest: register insights to template on boot (HMS-5994) (osbuild/images#1443)
* Author: rverdile, Reviewers: Achilleas Koutsou, Tomáš Hozza
* many: add custom unmarshalers for osbuild, platform (osbuild/images#1477)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza
— Somewhere on the Internet, 2025-05-05
---
tag v0.143.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.143.0
----------------
* distro/rhel9/azure: drop net.ifnames=0 kernel arg (RHEL-89440) (osbuild/images#1487)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Sanne Raymaekers
* github: don't run manifest checksum validation on the merge queue (osbuild/images#1478)
* Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Florian Schüller
* repositories: Set 6h expire on main repo, use default for updates (osbuild/images#1482)
* Author: Brian C. Lane, Reviewers: Achilleas Koutsou, Neal Gompa (ニール・ゴンパ), Simon de Vlieger
— Somewhere on the Internet, 2025-05-05
---
The issue has been fixed in 9.6 0day ZStream in v132.1, so running the
test against anything older will make the test fail. This is currently
the case for RHEL-9-nightly pipeline.
Let's solve this annoyance.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
This method is not particularly useful anymore. Its purpose was to
initialise the ImageOptions from an ImageRequest with the appropriate
size and partitioning mode. However, the partitioning mode was also
being set later using request.GetPartitioningMode(). More importantly,
setting the size on the ImageOptions caused issues with the interaction
between filesystem and partitioning customizations as well as the image
request size (see #4705). The correct thing to do here is to map the
ImageRequest.Size directly onto ImageOptions.Size, without taking into
account ImageType or the Blueprint Customizations. The rest are
considered when generating the manifest in images, either when preparing
the Manifest() call or when generating the partition table. This makes
it easier to trace and reason about the effect of each option. This
kind of decision making in the API layer makes it difficult to maintain
the logic, since it requires duplicating the decision making or, as we
had now, making certain specific combinations impossible.
After the move of the repo configs to `osbuild/images`, we changed the
way to determine the all available distro repo configs by taking the
last release of 'images'. This turns out to be fragile, especially when
the test case is being run on a "rhel-x.y.0" branch or basically with
any old osbuild-composer binary. It could happen also in Nightly test
pipelines after the devel freeze.
We always compile osbuild-composer binary with debug information, so we
can determine the vendored 'images' version from the binary. We also
always ship repo configs from the same 'images' version in the RPMs.
Therefore modify the test case to check out the 'images' version that
osbuild-composer was compiled with and use repo configs from that
version.
In addition, don't reduce the depth when cloning the images repository,
because even 200 commits may be too little on some older RHEL ZStream
branches.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Previously, the code would remove everything after the first dot in the
repo config filename. So 'rhel-10.0.json' -> 'rhel-10'. This means that
there was just a bunch of 'rhel-X' repo config names to compare. This is
probably a leftover from the days before we introduced dot-notation for
distro names.
Modify the test to effectivelly strip only the filename extension (the
part after the last dot, including the dot).
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The type of the minsize parameter in the new disk customization was
meant to support both integers (size in bytes) and strings (size with
unit). However, the schema wasn't done properly, which made any input
result in an error:
GenericError: Failed to create the compose request:
{"code":"IMAGE-BUILDER-COMPOSER-30","details":"request body has an
error: doesn't match schema #/components/schemas/ComposeRequest:
Error at \"/customizations/disk/partitions/0\": doesn't match schema
due to: Error at \"/minsize\": input matches more than one oneOf
schemas
Reducing it to just support strings simplifies the schema. It's also
not an important feature reduction since sizes as integers (for
filesystems that are typically in GiB) aren't very convenient.
tag v0.140.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.140.0
----------------
* Loader part override followups (osbuild/images#1466)
* Author: Michael Vogt, Reviewers: Tomáš Hozza
* RHEL-10/gce: install cloud-utils-growpart by default (osbuild/images#1463)
* Author: Tomáš Hozza, Reviewers: Michael Vogt, Simon de Vlieger
* base-host-check: expand to cover more (COMPOSER-2498) (osbuild/images#1432)
* Author: Simon de Vlieger, Reviewers: Tomáš Hozza
* rhel8,9: move partitioning into YAML (osbuild/images#1390)
* Author: Michael Vogt, Reviewers: Tomáš Hozza
— Somewhere on the Internet, 2025-04-28
---
tag v0.141.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.141.0
----------------
* Shrink the current installer images a bit (osbuild/images#1423)
* Author: Brian C. Lane, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza
* Update EL10 Azure images with changes made in RHEL 9.6 (osbuild/images#1472)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza
* distro: add DNFSetReleaseVerVar to ImageConfig (osbuild/images#1465)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza
* test/base-host-check.sh: fix disabled firewall services check (osbuild/images#1471)
* Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Tomáš Hozza
— Somewhere on the Internet, 2025-04-29
---
Expose the ${SUBJ} customization in Cloud API. Weldr API inherited it
automatically with the update of `osbuild/blueprint` to v1.6.0.
Adjust relevant test cases and unit tests to use this new customization.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The image type names for Fedora were changed in images 0.138.0, aliases
were left behind so the old names still exist.
Split out the testcases between rhel and fedora so we test for the new
names being returned.
Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Includes
tag v0.134.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.134.0
----------------
* Distro/el10/ec2/modprobe: blacklist 'i2c_piix4' (RHEL-71926) (osbuild/images#1395)
* Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Michael Vogt
* Update osbuild dependency commit ID to latest (osbuild/images#1391)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza
* distro/rhel9/azure: blacklist more modules on 9.6+ (RHEL-79065) (osbuild/images#1394)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger
* distro/rhel9/azure: exclude microcode_ctl on 9.6+ (RHEL-79065) (osbuild/images#1405)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza
* test: add configs for Azure that match official builds (osbuild/images#1411)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza
* test: fix description of `build-image` (osbuild/images#1420)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* tools/gen-manifest-checksums: sort by image name (osbuild/images#1406)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger
— Somewhere on the Internet, 2025-04-14
---
tag v0.135.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.135.0
----------------
* RHEL 9.6+ & 10.0+: install system-reinstall-bootc AWS and Azure [COMPOSER-2502] (osbuild/images#1435)
* Author: Achilleas Koutsou, Reviewers: Ondřej Budai
* RHEL 9.6+/Azure: systemd service and script for dataloss warning on temporary resource disk (osbuild/images#1434)
* Author: Achilleas Koutsou, Reviewers: Tomáš Hozza
* Set refclock in chrony config for Azure images on RHEL 9.6+ (RHEL-79065) (osbuild/images#1400)
* Author: Achilleas Koutsou, Reviewers: Tomáš Hozza
* Update snapshots to 20250415 (osbuild/images#1431)
* Author: SchutzBot, Reviewers: Achilleas Koutsou
* WSL: add packages for podman and proc utilities (COMPOSER-2455) (osbuild/images#1425)
* Author: Sanne Raymaekers, Reviewers: Tomáš Hozza
* [RHEL-9.6+/Azure]: update waagent.conf and add nvme_core.io_timeout kernel arg (osbuild/images#1430)
* Author: Achilleas Koutsou, Reviewers: Ondřej Budai, Sanne Raymaekers
* [RHEL/Azure RHUI] Disable `auto_enable_yum_plugins` in the RHSM config as a BP customization (osbuild/images#1415)
* Author: Tomáš Hozza, Reviewers: Achilleas Koutsou
* ci: dependency updater gobump golang fix (osbuild/images#1441)
* Author: Lukáš Zapletal, Reviewers: Ondřej Budai
* ci: dependency updater gobump typo (osbuild/images#1439)
* Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou
* ci: dependency updater via gobump (osbuild/images#1385)
* Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou
* distro: almalinux and almalinux_kitten (osbuild/images#1375)
* Author: Simon de Vlieger, Reviewers: Neal Gompa (ニール・ゴンパ), Ondřej Budai
* fedora: bump branched and rawhide (osbuild/images#1440)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Ondřej Budai
* github: don't run manifest checksum validation on main (osbuild/images#1437)
* Author: Achilleas Koutsou, Reviewers: Ondřej Budai, Simon de Vlieger
* manifesttest: add helper to find stages in a pipeline (osbuild/images#1418)
* Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger
* rhsm: support for podman secrets (osbuild/images#1414)
* Author: Lukáš Zapletal, Reviewers: Simon de Vlieger
— Somewhere on the Internet, 2025-04-16
---
tag v0.136.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.136.0
----------------
* ci: dependency updater gobump git fix (osbuild/images#1442)
* Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou
— Somewhere on the Internet, 2025-04-21
---
tag v0.137.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.137.0
----------------
* RHEL 9.6+ Azure: enable the dataloss warning service and add unmanaged devices to the NetworkManager config (osbuild/images#1447)
* Author: Achilleas Koutsou, Reviewers: Ondřej Budai, Tomáš Hozza
— Somewhere on the Internet, 2025-04-22
---
Includes
tag v0.129.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.129.0
----------------
* Update osbuild dependency commit ID to latest (osbuild/images#1347)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Ondřej Budai
* distro: move fedora partition tables into YAML (osbuild/images#1362)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* osbuild: create .mount and .swap units in /etc/systemd (osbuild/images#1366)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger
— Somewhere on the Internet, 2025-03-28
---
tag v0.130.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.130.0
----------------
* Imageconfig no osbuild (osbuild/images#1350)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* osbuild: add insights-client config stage (HMS-5670) (osbuild/images#1274)
* Author: rverdile, Reviewers: Achilleas Koutsou, Simon de Vlieger
— Somewhere on the Internet, 2025-04-01
---
tag v0.131.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.131.0
----------------
* Update snapshots to 20250401 (osbuild/images#1374)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger
* disk: add missing json/yaml keys for disk structs (osbuild/images#1378)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro/fedora: move defaultImageConfig into YAML (osbuild/images#1337)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro: add `ImageType.BasePartitionTable()` (osbuild/images#1376)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* gen-manifests: show depsolve config in mock depsolve (osbuild/images#1379)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger
* tools: make gen-manifests-diff run against the merge base (osbuild/images#1356)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza
— Somewhere on the Internet, 2025-04-03
---
tag v0.132.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.132.0
----------------
* Manifest checksums: detect manifest changes in PRs (osbuild/images#1380)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger
* manifest,image: stop embedding `OSCustomizations` in `manifest.OS` (osbuild/images#1386)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza
* manifest: addInlineDataAndStages() helper method for the OS and OSTreeDeployment pipelines (osbuild/images#1353)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger
* osbuild: add new stage org.osbuild.hmac (HMS-5924) (osbuild/images#1369)
* Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Tomáš Hozza
* rhel{7,10}: move partition table into yaml (osbuild/images#1367)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
— Somewhere on the Internet, 2025-04-07
---
tag v0.133.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.133.0
----------------
* Update snapshots to 20250404 (osbuild/images#1389)
* Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
* dnfjson: provide details if subscription cannot be found (osbuild/images#1393)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Lukáš Zapletal, Simon de Vlieger
* manifestgen: extra io.Writer for depsolver (osbuild/images#1384)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza
— Somewhere on the Internet, 2025-04-08
---
tag v0.134.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.134.0
----------------
* Distro/el10/ec2/modprobe: blacklist 'i2c_piix4' (RHEL-71926) (osbuild/images#1395)
* Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Michael Vogt
* Update osbuild dependency commit ID to latest (osbuild/images#1391)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza
* distro/rhel9/azure: blacklist more modules on 9.6+ (RHEL-79065) (osbuild/images#1394)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger
* distro/rhel9/azure: exclude microcode_ctl on 9.6+ (RHEL-79065) (osbuild/images#1405)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza
* test: add configs for Azure that match official builds (osbuild/images#1411)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza
* test: fix description of `build-image` (osbuild/images#1420)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* tools/gen-manifest-checksums: sort by image name (osbuild/images#1406)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger
— Somewhere on the Internet, 2025-04-14
---
commit a1ca7f34c770ac869387213923fa64ec36180084
Changes with a1ca7f34c770ac869387213923fa64ec36180084
----------------
* RHEL 9.6+/Azure: systemd service and script for dataloss warning on temporary resource disk (osbuild/images#1434)
* Author: Achilleas Koutsou, Reviewers: Tomáš Hozza
* Set refclock in chrony config for Azure images on RHEL 9.6+ (RHEL-79065) (osbuild/images#1400)
* Author: Achilleas Koutsou, Reviewers: Tomáš Hozza
* Update snapshots to 20250415 (osbuild/images#1431)
* Author: SchutzBot, Reviewers: Achilleas Koutsou
* WSL: add packages for podman and proc utilities (COMPOSER-2455) (osbuild/images#1425)
* Author: Sanne Raymaekers, Reviewers: Tomáš Hozza
* [RHEL-9.6+/Azure]: update waagent.conf and add nvme_core.io_timeout kernel arg (osbuild/images#1430)
* Author: Achilleas Koutsou, Reviewers: Ondřej Budai, Sanne Raymaekers
* [RHEL/Azure RHUI] Disable `auto_enable_yum_plugins` in the RHSM config as a BP customization (osbuild/images#1415)
* Author: Tomáš Hozza, Reviewers: Achilleas Koutsou
* ci: dependency updater gobump golang fix (osbuild/images#1441)
* Author: Lukáš Zapletal, Reviewers: Ondřej Budai
* ci: dependency updater gobump typo (osbuild/images#1439)
* Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou
* ci: dependency updater via gobump (osbuild/images#1385)
* Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou
* distro: almalinux and almalinux_kitten (osbuild/images#1375)
* Author: Simon de Vlieger, Reviewers: Neal Gompa (ニール・ゴンパ), Ondřej Budai
* fedora: bump branched and rawhide (osbuild/images#1440)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Ondřej Budai
* github: don't run manifest checksum validation on main (osbuild/images#1437)
* Author: Achilleas Koutsou, Reviewers: Ondřej Budai, Simon de Vlieger
* manifesttest: add helper to find stages in a pipeline (osbuild/images#1418)
* Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger
* rhsm: support for podman secrets (osbuild/images#1414)
* Author: Lukáš Zapletal, Reviewers: Simon de Vlieger
---
