Commit graph

7160 commits

Author SHA1 Message Date
Brian C. Lane
60c5f10af8 cloudapi: Fix the href of the delete response
Originally it was going to include /delete/ in the path. It was removed
in the openapi yaml but not in the result from deleteComposeImpl.
2025-07-11 00:47:22 +02:00
Brian C. Lane
07d34f339c cloudapi: Use error 400 for cloudapi delete errors
The most common one is going to be trying to delete a compose before it
is finished, and that is certainly not worthy of a 500 server error
since it is a temporary state.
2025-07-11 00:47:22 +02:00
Sanne Raymaekers
5d67542f3f test: adapt to images v0.155.0
- renamed wsl disk;
- install latest osbuild version in worker regression test (but keep the
  older worker).
2025-07-10 16:00:45 +02:00
Sanne Raymaekers
395f68549d go.mod: update osbuild/images to v0.155.0
tag v0.152.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 0.152.0

----------------
  * Update snapshots to 20250605 (osbuild/images#1586)
    * Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger
  * distro: followups for reivew feedback in PR#1563 (osbuild/images#1584)
    * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza
  * fedora/wsl: xz compression (HMS-8573) (osbuild/images#1582)
    * Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Florian Schüller

— Somewhere on the Internet, 2025-06-16

---

tag v0.153.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 0.153.0

----------------
  * GHA: enable the stale action to delete its saved state (osbuild/images#1602)
    * Author: Tomáš Hozza, Reviewers: Lukáš Zapletal, Simon de Vlieger
  * Smaller isos (osbuild/images#1599)
    * Author: Brian C. Lane, Reviewers: Lukáš Zapletal, Simon de Vlieger
  * Update snapshots to 20250618 (osbuild/images#1603)
    * Author: SchutzBot, Reviewers: Brian C. Lane, Simon de Vlieger
  * distro/rhel-10: WSL distribution config (HMS-8573) (osbuild/images#1591)
    * Author: Simon de Vlieger, Reviewers: Gianluca Zuccarelli, Lukáš Zapletal, Tomáš Hozza
  * distro/rhel-10: new `vagrant-libvirt` image type (HMS-6116) (osbuild/images#1601)
    * Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza
  * distro/rhel{8,9,10}: WSL extension and compression (HMS-8573) (osbuild/images#1590)
    * Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza
  * distro: handle `centos-9` and similar versions better (osbuild/images#1598)
    * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
  * osbuild/grub2: add compat_version and set it to 2 (osbuild/images#1595)
    * Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Tomáš Hozza

— Somewhere on the Internet, 2025-06-20

---
2025-07-10 16:00:45 +02:00
Sanne Raymaekers
4324f24fe7 go.mod: upgrade github.com/go-jose/go-jose/v4 to v4.0.5 2025-07-10 16:00:45 +02:00
Sanne Raymaekers
d62827e97c go.mod: upgrade to 1.23.9 2025-07-10 16:00:45 +02:00
Tomáš Hozza
97c3460a94 cmd: delete osbuild-koji
Delete the osbuild-koji tools, which is not used by any code or test
case. This also allows to delete the koji.NewFromPlain() function. This
is to minimize the set of exported functions by the koji package, before
moving it to osbuild/images repository.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-07-09 22:51:53 +02:00
Tomáš Hozza
651946ae54 upload/koji: don't depend on upload target osbuild artifact structure
Modify the Koji image extra metadata to not depend on the upload target
data structure for the OSBuild Artifact. This is the last dependency on
the internal osbuild-composer package, allowing the move of the Koji
upload code to the osbuild/images repository.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-07-09 22:51:53 +02:00
Tomáš Hozza
2ceffb3796 upload/koji: don't depend on upload target results data structures
Modify the Koji image extra metadata to not depend on the upload target
data structures for upload results. The target results are supposed to
be specific to the uploader implementation, which will eventually
change. Moreover, the definition is internal to osbuild-composer, so
this would create a problem once the Koji upload implementation is moved
to osbuild/images.

The Koji upload implementation does not really care about the exact
structure of the upload results. It is just a list of JSON objects.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-07-09 22:51:53 +02:00
Tomáš Hozza
0bafc0915d upload/koji: don't depend on rpmmd.RPM for build metadata
The use of rpmmd.RPM is exclusive to the Koji upload implementation.
Consolidate the metadata structure for RPMs into the koji package
codebase, together with any required functions for converting osbuild
stage metadata. The respective code in osbuild/images will be eventually
removed.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-07-09 22:51:53 +02:00
Tomáš Hozza
0ca81d5af4 upload/koji: move metadata structures to a separate file
Increase readability by logically splitting the build metadata
structures from the actual upload API implementation.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-07-09 22:51:53 +02:00
Tomáš Hozza
dc8f8964a4 upload/koji: delete unused GSSAPICredentialsFromEnv()
The function is not being used anywhere, therefore delete it.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-07-09 22:51:53 +02:00
Tomáš Hozza
ca1e1dce36 Many: factor out logger implementation from upload/koji
The upload/koji package functions were creating a logger and then were
using it. This is not ideal for a library implementation.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-07-09 22:51:53 +02:00
Tomáš Hozza
60014b1218 upload/koji: use passed transport in NewFromPlain()
Don't create a new transport in NewFromPlain() using
CreateRetryableTransport(), because the only place
in which NewFromPlain() is called passes the return value of
CreateRetryableTransport() when calling it.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-07-09 22:51:53 +02:00
schutzbot
55744ac1e8 Post release version bump
[skip ci]
2025-07-09 08:15:36 +00:00
Lukas Zapletal
1cde7e341b common: fix unclosed logrus logging pipes 2025-07-08 11:38:27 +02:00
rverdile
0c325137cf cloudapi/v2: add patch_url to customizations
Supports registering a template to insights on boot. Patch URL is needed
for RHEL 8 and RHEL 9.5 support.
2025-07-04 08:36:23 +02:00
Tomáš Hozza
c2f3e0486c Test/repositories/el8*: use rhui-4 instead of rhui-3
RHUI-3 has been EOL on RHEL-8 and it is no longer being updated and we
do not take new snapshots of it. Use RHUI-4 instead. More info in [1].

It turns out, that the previously used RHUI-3 snapshot was missing
amazon-libdnf-plugin package, wich is required by the RHUI client.
As a result, the "weldr dot-notation" test has been failing in the GA
pipeline on RHEL-8. We do not run the test case on RHEL-8 in PRs of
`main` pipeline, because we test only on nightly composes and there are
no new releases being developed for RHEL-8. Therefore this was
manifesting only in the GA pipeline runs.

This change should fix the failures in the GA pipeline.

[1] https://github.com/osbuild/rpmrepo/pull/119

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-07-03 12:59:52 +02:00
Sanne Raymaekers
3ce8efd80f schutzbot/containerbuild: do not verify images from rh registries 2025-06-27 21:19:21 +02:00
schutzbot
9f7b6210fe schutzfile: Update snapshots to 20250626 2025-06-27 21:19:21 +02:00
Lukas Zapletal
84e26ab591 fix: update gobump GHA 2025-06-26 18:44:35 +02:00
Lukas Zapletal
f0fb23f1af ci: introduce gobump gha 2025-06-26 13:01:27 +02:00
schutzbot
06d060c8df Post release version bump
[skip ci]
2025-06-25 08:16:36 +00:00
Sanne Raymaekers
7dea1bcd01 many: remove jobsite code
This was replaced by `cmd/osbuild-worker-executor`.
2025-06-25 03:01:59 +02:00
Achilleas Koutsou
f6c1709d8d cloudapi: add azure-cvm image type
Introduce the azure-cvm (confidential VM) in the cloud API.
2025-06-24 15:38:32 +02:00
Tomáš Hozza
f1afe0ce26 Schutzfile: unify the pinned osbuild ref
Make sure that we have the same osbuild ref pinned for all distros.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-06-23 14:37:30 +01:00
Achilleas Koutsou
cf72504057 spec: bump min osbuild version 2025-06-23 14:37:30 +01:00
Achilleas Koutsou
deccaf9548 go.mod: update osbuild/images to v0.151.0
tag v0.149.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 0.149.0

----------------
  * Update dependencies 2025-05-25 (osbuild/images#1560)
    * Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
  * Update osbuild dependency commit ID to latest (osbuild/images#1522)
    * Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
  * Update snapshots to 20250515 (osbuild/images#1524)
    * Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
  * `vagrant-libvirt` implementation (HMS-6116) (osbuild/images#1548)
    * Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Tomáš Hozza
  * fedora: tweaks after all imageTypes are YAML (osbuild/images#1518)
    * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
  * gha: do not break gobump output (osbuild/images#1561)
    * Author: Lukáš Zapletal, Reviewers: Simon de Vlieger, Tomáš Hozza
  * repositories: AlmaLinux 10 (osbuild/images#1567)
    * Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal, Neal Gompa (ニール・ゴンパ)
  * vagrant: image config for default vagrant user (HMS-6116) (osbuild/images#1565)
    * Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Michael Vogt

— Somewhere on the Internet, 2025-05-27

---

tag v0.150.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 0.150.0

----------------
  * Replace hardcoded kickstart %post scripts with new stage options and bootc switch with custom kickstart content (HMS-6051) (osbuild/images#1527)
    * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
  * test: install yamllint for tests (osbuild/images#1572)
    * Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza

— Somewhere on the Internet, 2025-06-02

---

tag v0.151.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 0.151.0

----------------
  * Introduce new Azure CVM image type (HMS-5636) (osbuild/images#1318)
    * Author: Achilleas Koutsou, Reviewers: Nobody
  * Many: support using string with unit for byte-sized partitioning fields in YAML distro definitions (osbuild/images#1579)
    * Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Brian C. Lane
  * Update osbuild dependency commit ID to latest (osbuild/images#1587)
    * Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza
  * Update snapshots to 20250601 (osbuild/images#1573)
    * Author: SchutzBot, Reviewers: Achilleas Koutsou, Lukáš Zapletal
  * bootc: Make installed rootfs configurable (osbuild/images#1555)
    * Author: Mbarak Bujra, Reviewers: Michael Vogt, Tomáš Hozza
  * distro: create new ImageConfig.DNFConfig (osbuild/images#1583)
    * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
  * distro: make "fedora" a "generic" distro (osbuild/images#1563)
    * Author: Michael Vogt, Reviewers: Nobody
  * image: If using a separate build container, copy bootc customization to it (osbuild/images#1571)
    * Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Tomáš Hozza
  * manifest/ostree: explicitly include shadow-utils (osbuild/images#1585)
    * Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Michael Vogt
  * osbuild/tar: explicit compression (HMS-8573, HMS-6116) (osbuild/images#1581)
    * Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Tomáš Hozza
  * tests: bump fedora versions to 41 (osbuild/images#1438)
    * Author: Lukáš Zapletal, Reviewers: Brian C. Lane, Michael Vogt

— Somewhere on the Internet, 2025-06-09

---
2025-06-23 14:37:30 +01:00
Sanne Raymaekers
cedc351bbd templates/packer: fix installing rpms from copr
There are now 2 colons present, one separating the epoch and the
version, and one before the comment.
2025-06-20 21:57:04 +02:00
Tomáš Hozza
c4430ffa7a CI: disable consistently failing EDGE CI tests
These test have been failing consistently for very long time (many
months). They need to be investigated and fixed before re-enabling them.

The ticket to re-enable them is:
https://issues.redhat.com/browse/HMS-8719

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-06-20 12:55:17 +02:00
Tomáš Hozza
019c6771c6 CI: disable Installer test on c10s / el10.1 due to a known bug
The ticket to re-enable the test is:
https://issues.redhat.com/browse/HMS-8718

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-06-20 12:55:17 +02:00
Tomáš Hozza
b4e2db8c35 Test/data: add F42 repositories
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-06-20 10:06:51 +02:00
Achilleas Koutsou
61e3fc7f2e Stop testing on Fedora 40 - Start testing on Fedora 42
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-06-20 10:06:51 +02:00
Tomáš Hozza
664f68ba16 schutzbot/terraform: update ref to the one with F42 config
Update the terraform ref to the one that contains F42 configs. This is
needed to start testing anything on F42.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-06-20 10:06:51 +02:00
schutzbot
378ca76682 schutzfile: Update snapshots to 20250605 2025-06-18 20:40:14 +02:00
Tomáš Hozza
11d821863e GHA: enable the stale action to delete its saved state
It turns out that the stale action is not able to delete its saved
state due to missing permissions. As a result, it was not processing
issues and PRs, that have been processed once, for almost a month.

The error in the job log was:
```
Warning: Error delete _state: [403] Resource not accessible by integration
```

The fix is to add `actions: write` to the action permissions

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
2025-06-18 14:38:12 +02:00
Lukas Zapletal
f2bf47814f deps: upgrade go-systemd from v1 to v22 2025-06-16 17:46:45 +02:00
Achilleas Koutsou
5a5e6d732c clouapi: test Disk customization validation
Two new tests are added, one with valid customizations and another with
invalid customizations.
Invalid customizations will return one of two error types, depending on
where exactly the failures was generated.
When the openapi schema fails to validate a request, it will return
IMAGE-BUILDLER-30.
When the error occurs while converting the openapi customizations to the
blueprint types, it will have the IMAGE-BUILDER-35 type instead.
2025-06-16 13:33:20 +02:00
Achilleas Koutsou
45929efbcf cloudapi: validate Disk customization before returining
After converting a Disk customization from the API type to the Blueprint
equivalent, run the validator and return an error if it fails to
validate.
The schema doesn't catch all invalid cases, such as the mountpoint being
required when the fs_type is not "swap", so calling the validator
ensures that any such cases are caught without needing to duplicate the
checks.
2025-06-16 13:33:20 +02:00
Achilleas Koutsou
ea0b5e8661 cloudapi: make fs_type required for filesystems and logical volumes
While technically this is a backwards incompatible API change, the
core blueprint schema didn't allow for empty or undefined fs_type [1,2],
so the general behaviour hasn't changed, we're just catching it early
now.

[1] de18902e3f/pkg/blueprint/disk_customizations.go (L624-L627)
[2] de18902e3f/pkg/blueprint/disk_customizations.go (L677-L680)
2025-06-16 13:33:20 +02:00
Achilleas Koutsou
a03d01c92c cloudapi: make type mandatory for non-plain partitions
The type is required for partitions with a type other than plain.

This commit also adds the empty string to the valid values in the
conversion switch case and is treated like "plain".
2025-06-16 13:33:20 +02:00
Achilleas Koutsou
6cd4bbc6d2 cloudapi: support swap partitions and volume groups
Supporting "swap" as the fs_type requires making the mountpoint an
optional field.  When setting fs_type="swap", the mountpoint must be
empty.
2025-06-16 13:33:20 +02:00
Achilleas Koutsou
edb9b284d5 cloudapi: return http error when failing to convert disk customizations
Return an HTTP error with the invalid customization message when the
convertDiskCustomizations() function returns an error.

Secondary: The conversion was being run twice by mistake.  This has also
been fixed.
2025-06-16 13:33:20 +02:00
Sanne Raymaekers
90f05db135 Schutzfile: add fedora-42
The packer job actually looks for the osbuild dependency that matches
the distro name that it's about to build. So in the case of fedora-42, a
fedora-42 Schutzfile entry is needed.
2025-06-13 12:00:21 +02:00
Simon Steinbeiss
594286f07b fedora-worker-packer: Bump to Fedora 42 2025-06-12 17:03:48 +02:00
Simon Steinbeiss
47b5b8b101 Schutzfile: Bump all osbuild hashes
This completes the change commited as 612a295bf6
2025-06-12 17:03:48 +02:00
Simon Steinbeiss
612a295bf6 Schutzfile: Bump osbuild ref
This is to work around breakage in Fedora Rawhide and Python 3.14.
2025-06-12 15:39:56 +02:00
schutzbot
01f1fcf34b Post release version bump
[skip ci]
2025-06-11 08:17:01 +00:00
Florian Schüller
f26b992fe1 test/cases/oci.sh: Update shape to newer version
As of today it was recommended by oracle to use the
newer shape to be supported longer.
2025-06-06 14:34:04 +02:00
Florian Schüller
f0d39d986f test/cases/oci: improve CI output
Avoid error message where this is no error.
2025-06-06 14:34:04 +02:00