These tools were usually introduced when we added new upload target
implementation to osbuild-composer. Their main purpose was manual
testing of the upload library. They don't have any real use beyond that.
With the upload code being moved to `osbuild/images` and these tools
having their duplicates in that repository, there is very little sense
in keeping them in osbuild-composer.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
We now use gobump to manage Go dependencies. gobump supports holding
back dependency updates that require newer go compiler versions than the
one specified in the project's go.mod.
It turned out that the Pulp upload target was never adopted by the
service, thus it is being removed as part of upload code consolidation.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
It turned out that the target was never adopted by the service, thus it
is being removed as part of the upload code consolidation.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
It turned out that the upload target was never adopted by the service,
thus we are removing it as part of upload code consolidation.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
It turned out that the target was never adopted by the service, thus it
is being deleted as part of upload code consolidation.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
It turned out that the target was never adopted by the service, thus it
is being deleted as part of upload code consolidation.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Start embedding the awscloud.AWS from osbuild/images in
osbuild-composer's version of awscloud.AWS. The idea is to remove all
methods from osbuild-composer implementation, which are used for
uploading and registering images in AWS. The rest that it related to
service maintenance or to running secure instances, will be kept in
osbuild-composer, since these are specific to the project.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
With the upload code consolidation to osbuild/images, we need to make
sure to configure the logger used by the library to keep logging the
same (or similar) messages when running osbuild-composer.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The changes to the TestComposeUnsupportedMountPointV0() test case when
the osbuild/images has been updated to v0.172.0 broke the RHEL nightly
and GA CI pipelines.
Change the test to be backward compatible with osbuild/images <
v0.172.0.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The v36.0 release of weldr-client/composer-cli will include support for
cloudapi commands. This adjusts the tests so that they will work with
the new version while maintaining compatibility with the previous
version.
Related: RHEL-60123
The internal blueprint implementation has been removed from
osbuild/images. Conversion from osbuild/blueprint blueprints to
osbuild/images blueprints is no longer necessary.
The test manifests don't have any use in this repository, since the
osbuild-image-tests command has been removed. Likewise, generating
testing manifests is no longer needed in this repository, therefore
remove the gen-manifests command.
Manifests are being generated in the osbuild/images repository and the
necessary tooling to generate them lives there.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Delete the no longer used osbuild-images-tests command. Subsequently,
delete the /internal/boot packages, which were used only by the command
and also depended on its data structures.
Technically, no boot test were done using the code in this repository
for quite some time. And the long term plan is to boot test all images
in the osbuild/images repository.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
The image_tests.sh test case is being run only as part of the RHEL
nightly pipeline. This test case evolved over the years. In principle
it can do the following:
1. Read test cases from /test/data/manifests.
2. Rebuild the manifest attached to the test case directly by running
osbuild.
3. Compare the image-info report if attached to the test case (NOT
done for any test cases in /test/data/manifests).
4. Boot-test the built image in the respective environment (NOT done
for any test cases in /test/data/manifests).
Moreover, these manifests (or test cases) are not updated regularly
after being generated for the first time.
All in all, given the fact that the test case rebuilds outdated
manifests by directly calling osbuild and does not run any additional
tests, it adds no value compared to the osbuild/images CI.
osbuild/images CI always rebuilds the latest image definition version
manifests with osbuild, so at the time the library is updated in
osbuild-composer, this scenario has already been tested.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
This uses the blueprint and the image type's manifest with a minimal
imageRequest to get the package sets to use for depsolving, instead of
just using the packages in the blueprint.
This does not work with iot image types that require an ostree url.
Depsolving iot commits doesn't make sense anyway, since the blueprint
packages have no effect on it.
Includes simple tests for depsolving with image type, and returning an
error if the image type isn't recognized.
Related: RHEL-60125
The oapi-codegen update to v2.5.0 changed the Details field of the main
Error type to be an empty interface. This requires updates to the error
handling tests to accommodate the new structure.
v1.60 seems to have some issues [1] with something in our dependency
chain. Update to v1.61 and fix all new issues.
New issues are all instances of potential integer overflow from int ->
uint conversions. Added guards where appropriate and disabled the check
when when it's not needed.
[1] https://github.com/osbuild/osbuild-composer/actions/runs/16624417387/job/47037518471
