osbuild: resolve TODOs

When an alternative monitor like JSONSeqMonitor is used there is
still non json output printed to stdout. This was a TODO but
this commit removes it because it's okay, there is the
"--monitor-fd" that should be used when using the json-seq monitor.
This commit is contained in:
Michael Vogt 2024-01-24 18:51:37 +01:00 committed by Ondřej Budai
parent f214c69a98
commit 66468a3c58
2 changed files with 1 additions and 4 deletions

View file

@ -186,7 +186,6 @@ def osbuild_cli() -> int:
debug_break,
stage_timeout=stage_timeout
)
# TODO: this needs a test
if r["success"]:
monitor.log(f"manifest {args.manifest_path} finished successfully", origin="org.osbuild.main")
else:
@ -197,8 +196,6 @@ def osbuild_cli() -> int:
for pid in exports:
export(pid, output_directory, object_store, manifest)
# TODO: subpress when "--monitor=JSONSeqMontior" is used
# or (be explcit) have "--no-summary" or something
if args.json:
r = fmt.output(manifest, r, object_store)
json.dump(r, sys.stdout)