do not shell=True

2018-03-14 20:09:01 +08:00 · 2018-03-14 20:09:01 +08:00 · 43a433d37a
commit 43a433d37a
parent c008ac8bb9
1 changed files with 1 additions and 2 deletions
--- a/koji/daemon.py
+++ b/koji/daemon.py
@ -513,8 +513,7 @@ class SCM(object):
        if self.scmtype.startswith('GIT'):
            cmd = ['git', 'rev-parse', 'HEAD']
            proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
-                                    cwd=self.sourcedir,
-                                    shell=True)
+                                    cwd=self.sourcedir,)
            out, _ = proc.communicate()
            status = proc.wait()
            if status != 0: