do not shell=True

This commit is contained in:
Yuming Zhu 2018-03-14 20:09:01 +08:00
parent c008ac8bb9
commit 43a433d37a

View file

@ -513,8 +513,7 @@ class SCM(object):
if self.scmtype.startswith('GIT'): if self.scmtype.startswith('GIT'):
cmd = ['git', 'rev-parse', 'HEAD'] cmd = ['git', 'rev-parse', 'HEAD']
proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
cwd=self.sourcedir, cwd=self.sourcedir,)
shell=True)
out, _ = proc.communicate() out, _ = proc.communicate()
status = proc.wait() status = proc.wait()
if status != 0: if status != 0: