particle-os/debian-koji
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

better variable naming

Browse source
This commit is contained in:
Tomas Kopecek 2023-08-03 13:02:36 +02:00
parent 13097dff36
commit b7a05820f5
1 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

24
plugins/hub/sidetag_hub.py
View file

@ -65,24 +65,24 @@ class SidetagOwnerTest(koji.policy.MatchTest):
name = 'is_sidetag_owner'
def run(self, data):
values = self.str.split()[1:]
if len(values) > 1:
fields = self.str.split()[1:]
if len(fields) > 1:
raise koji.GenericError("Just one argument is allowed for this test.")
elif values:
value = values[0]
if value not in ('tag', 'fromtag', 'both'):
elif fields:
key = fields[0]
if key not in ('tag', 'fromtag', 'both'):
raise koji.GenericError("Policy test is_sidetag_owner has only "
f"/tag/fromtag/both options (got {value})")
if value == 'both':
values = ['tag', 'fromtag']
f"/tag/fromtag/both options (got {key})")
if key == 'both':
fields = ['tag', 'fromtag']
else:
values = ['tag']
fields = ['tag']
user = policy_get_user(data)
for value in values:
if value not in data:
for field in fields:
if field not in data:
return False
tag = get_tag(value)
tag = get_tag(data[field])
if not tag or not is_sidetag_owner(tag, user):
return False
return True