Commit graph

3252 commits

Author SHA1 Message Date
Mike McLean
12f156d1f3 fix exception syntax 2017-12-07 18:16:03 -05:00
Patrick Uiterwijk
fbbd5cd168 Fix resetting the environment
Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
2017-12-07 18:16:03 -05:00
Mike McLean
c3f5b5b124 unit tests for gssapi auth 2017-12-07 18:16:03 -05:00
Mike McLean
66e42e9bfc fix another bare exception 2017-12-07 18:16:03 -05:00
Mike McLean
960c1f861d be a little more paranoid about undoing opts/environ mangling 2017-12-07 18:16:03 -05:00
Mike McLean
64375197ff avoid bare exception and add some debug logging 2017-12-07 18:16:03 -05:00
Patrick Uiterwijk
7a2f2a7d4b Implement support for keytab in gssapi codepaths
This had been a TODO that until now wasn't critical since python2 would fall back to krbV.
For python3, we only have gssapi, so implement keytabs and ccache for gssapi.

Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
2017-12-07 18:16:03 -05:00
Mike McLean
c1d8ca8e46 PR#446: run checks earlier for cg_import
Merges #446
https://pagure.io/koji/pull-request/446

Fixes: #426
https://pagure.io/koji/issue/426
cg_import should catch archive errors earlier
2017-12-07 14:57:49 -05:00
Mike McLean
bc2bb62032 avoid unnecessary file opening 2017-12-07 14:55:37 -05:00
Tomas Kopecek
b482e36595 move checks earlier to prep_outputs 2017-12-07 14:55:37 -05:00
Tomas Kopecek
6ad3d65a91 check all existing btypes 2017-12-07 14:55:37 -05:00
Tomas Kopecek
b81159bc2d run checks earlier for cg_import
Related: https://pagure.io/koji/issue/426
2017-12-07 14:55:37 -05:00
Mike McLean
bc02f03d3e PR#610: show components for all archives
Merges #610
https://pagure.io/koji/pull-request/610

Fixes: #545
https://pagure.io/koji/issue/545
components not displayed for non-images
2017-12-07 14:47:13 -05:00
Mike McLean
e6fae7ca29 fix rpm components check 2017-12-07 14:47:09 -05:00
Tomas Kopecek
f635493c95 show archives in archives 2017-12-07 14:47:09 -05:00
Tomas Kopecek
601871c699 show components for all archives
Related: https://pagure.io/koji/issue/545
2017-12-07 14:47:09 -05:00
Mike McLean
62d4d1d1d1 PR#578: cli: fix changelog encode for PY3
Merges #578
https://pagure.io/koji/pull-request/578

Fixes #577
https://pagure.io/koji/issue/577
buildinfo --changelog prints bytestring
2017-12-07 14:26:52 -05:00
Yuming Zhu
377fecbbfc fix unit test - test_formatChangelog 2017-12-06 14:08:37 +08:00
Mike McLean
8a4c75ee7f rename fixPrint->_fix_print and add a docstring 2017-12-06 13:32:51 +08:00
Mike McLean
1da06800cf adjustments to test_formatChangelog 2017-12-06 13:32:51 +08:00
Yuming Zhu
3464adae2e cli: fix changelog encode for PY3
relates [issue#577](https://pagure.io/koji/issue/577)
2017-12-06 13:32:29 +08:00
Mike McLean
ac2d2c5935 PR#533: Treat canceled tasks as failed for optional_archs
Merges #533
https://pagure.io/koji/pull-request/533

Fixes: #529
https://pagure.io/koji/issue/529
failable tasks that are cancelled should not fail the parent
2017-12-05 10:30:32 -05:00
Tomas Kopecek
47164a9d58 test intermediate calls 2017-12-05 10:28:24 -05:00
Mike McLean
cb64ee6bd8 taskWaitResults: more unit tests 2017-12-05 10:28:24 -05:00
Mike McLean
7ce1c73777 taskWaitResults: fix canfail/canceled case when tasks=None 2017-12-05 10:28:24 -05:00
Mike McLean
88fb2a9b8c add unit test for host.taskWaitResults 2017-12-05 10:28:24 -05:00
Mike McLean
621ce5b27e include faultCode in return for canceled, can-fail tasks 2017-12-05 10:28:24 -05:00
Tomas Kopecek
3701634d65 Treat canceled tasks as failed for optional_archs
Related: https://pagure.io/koji/issue/529
2017-12-05 10:28:23 -05:00
Mike McLean
7e90e36808 PR#686: Display license info in CLI's rpminfo and Web UI
Merges #686
https://pagure.io/koji/pull-request/686

Fixes: #683
https://pagure.io/koji/issue/683
RFE: show License data for rpms
2017-11-30 17:39:05 -05:00
Tomas Kopecek
c8242ed75f Display license info in CLI's rpminfo and Web UI
Fixes: https://pagure.io/koji/issue/683
2017-11-30 17:39:01 -05:00
Mike McLean
43c48c61be PR#718: convenience script to run py2 and py3 tests in parallel
Merges #718
https://pagure.io/koji/pull-request/718
2017-11-30 16:23:25 -05:00
Mike McLean
a56b655bd7 deal with failed commands 2017-11-30 16:23:22 -05:00
Mike McLean
824d27935c runtests script 2017-11-30 16:23:22 -05:00
Mike McLean
c0dbda3bda PR#722: docs: check external repos with taginfo
Merges #722
https://pagure.io/koji/pull-request/722
2017-11-30 16:18:46 -05:00
Ken Dreyer
0fbc71854f docs: check external repos with taginfo
Add a step to check your work when setting up the new external
repositories, along with some expected output.
2017-11-30 16:18:41 -05:00
Ken Dreyer
89803c24e4 docs: indent external-repo-server-bootstrap notes
These notes below to the bullet points. Indent them to align with the
respective bullet points.
2017-11-30 16:18:41 -05:00
Mike McLean
b260aab9cd PR#675: refactory cli unittests, move share code pieces to utilities library
Merges #675
https://pagure.io/koji/pull-request/675

Fixes: #640
https://pagure.io/koji/issue/640
Goal: 30% coverage for cli commands
2017-11-30 15:02:05 -05:00
Franz Chih-Ping Hsieh
ec99419f3b Add unit tests for koji image_build command 2017-11-30 15:02:00 -05:00
Franz Chih-Ping Hsieh
f16f26be63 Add unit tests for koji commands 2017-11-30 15:02:00 -05:00
Franz Chih-Ping Hsieh
d331fdfa11 refactory CLI unittests including:
- introduce new CliTestCase class
 - implement useful assert functions in CliTestCase
2017-11-30 15:02:00 -05:00
Mike McLean
f79cab8c0d PR#714: Use task id as key to sort
Merges #714
https://pagure.io/koji/pull-request/714

Related: #713
https://pagure.io/koji/issue/713
invalid keyword cmp in python3 list.sort() and sorted()
2017-11-30 12:20:36 -05:00
Franz Chih-Ping Hsieh
8da5f2bc2f Use task id as key to sort
related: #713
https://pagure.io/koji/issue/713
2017-11-30 12:20:33 -05:00
Mike McLean
39dc9efaac PR#707: add argument detection to prevent array out of index error.
Merges #707
https://pagure.io/koji/pull-request/707

Fixes: #706
https://pagure.io/koji/issue/706
search command argument errors
2017-11-30 12:18:39 -05:00
Franz Chih-Ping Hsieh
5da7c18f1f add argument detection to prevent array out of index error.
Fixes: #706
https://pagure.io/koji/issue/706
2017-11-29 04:05:50 +00:00
Mike McLean
c152991b54 PR#717: Fix watch-tasks unit tests
Merges #717
https://pagure.io/koji/pull-request/717
2017-11-28 13:40:32 -05:00
Mike McLean
d38a2f30da py3 fixes for watch-tasks unit tests 2017-11-28 13:40:29 -05:00
Mike McLean
704e542b65 test_watch_tasks_with_keyboardinterrupt() 2017-11-28 13:40:29 -05:00
Mike McLean
2b0146a0ba another watch-tasks test 2017-11-28 13:40:29 -05:00
Mike McLean
83015e643c fakeclient: support multiple calls per key 2017-11-28 13:40:29 -05:00
Mike McLean
d97cf1f961 use fake client for watch_tasks testing 2017-11-28 13:40:29 -05:00