Ken Dreyer
14daa94d82
doc: rewrite PostgreSQL authorization instructions
...
Rewrite the PostgreSQL authorization instructions in the Server HowTo
guide.
Provide two complete examples: the "all-in-one localhost" option, and
the "separate postgres over the network" option. This reduces the
decision trees and makes it easier to copy and paste the entire
pg_hba.conf file. Explain what each mystery setting does and link to the
PostgreSQL documentation.
Only set listen_addresses to "*" if we need it, and turn it off if we
don't.
Simplify the instructions so that the user only restarts the postgresql
daemon once.
Clarify that koji-web does not need DB access, and the hub is the only
service that requires direct DB access.
Remove the example of authorizing the apache system user, because that
implies that the admin must run a series of complicated GRANT
instructions to allow both koji and apache to write to the DB. Just
grant the koji user full trust access for simplicity.
2020-06-24 14:44:44 +02:00
Tomas Kopecek
9887a4f408
PR#2290: vm: clone mac address via xml
...
Merges #2290
https://pagure.io/koji/pull-request/2290
Fixes : #2289
https://pagure.io/koji/issue/2289
vm: new libvirt refuse to clone same mac addr in some cases
2020-06-24 14:43:28 +02:00
Tomas Kopecek
bb0ea0d6d5
vm: clone mac address via xml
...
Fixes: https://pagure.io/koji/issue/2289
2020-06-24 14:43:17 +02:00
Tomas Kopecek
2778b7ac25
PR#2317: md5: try the best to use sha256 instead of md5 and ignore FIPS in other parts
...
Merges #2317
https://pagure.io/koji/pull-request/2317
Fixes : #2291
https://pagure.io/koji/issue/2291
error raised by `hashlib.md5()` on RHEL8.2 (MD5 is disabled by FIPS)
2020-06-24 14:42:11 +02:00
Yu Ming Zhu
1be2064df1
fix flake8 for kojihub.py
2020-06-24 14:42:01 +02:00
Yuming Zhu
65f5b6489b
fix param name for uploadFile
2020-06-24 14:42:01 +02:00
Tomas Kopecek
50bcb6f3bc
replace md5 with sha256
2020-06-24 14:42:01 +02:00
Yu Ming Zhu
a893e8bf2b
a wrapper ignoring FIPS for hashlib.md5
2020-06-24 14:42:00 +02:00
Yu Ming Zhu
0a61104280
web: use sha1 for token generation instead of md5(disabled by FIPS)
...
fixes : #2291
2020-06-24 14:42:00 +02:00
Tomas Kopecek
fc4cb3d37e
PR#2263: improve race condition for getNextRelease / images
...
Merges #2263
https://pagure.io/koji/pull-request/2263
Fixes : #2138
https://pagure.io/koji/issue/2138
Race condition for getNextRelease / images
2020-06-24 13:36:32 +02:00
Tomas Kopecek
ba02c1b977
improve race condition for getNextRelease / images
...
Fixes: https://pagure.io/koji/issue/2138
2020-06-24 13:36:23 +02:00
Tomas Kopecek
9e196264da
PR#2085: hide local --debug options
...
Merges #2085
https://pagure.io/koji/pull-request/2085
Fixes : #2084
https://pagure.io/koji/issue/2084
list-signed has separate --debug option
2020-06-24 10:53:51 +02:00
Tomas Kopecek
5b94c9eb01
hide local --debug options
...
Fixes: https://pagure.io/koji/issue/2084
2020-06-24 10:53:38 +02:00
Tomas Kopecek
6e50120279
PR#2301: avoid redundant clauses and joins in query_buildroots()
...
Merges #2301
https://pagure.io/koji/pull-request/2301
Fixes : #2300
https://pagure.io/koji/issue/2300
query_buildroots can perform redundant joins
2020-06-24 10:40:46 +02:00
Mike McLean
b2dd73fa03
avoid redundant clauses and joins
...
Fixes https://pagure.io/koji/issue/2300
2020-06-24 10:40:36 +02:00
Tomas Kopecek
4675229937
PR#2237: db: use timestamps with timezone
...
Merges #2237
https://pagure.io/koji/pull-request/2237
Fixes : #2160
https://pagure.io/koji/issue/2160
event times subject to postgres timezone setting
2020-06-24 09:45:01 +02:00
Tomas Kopecek
87b8cf718a
db: use timestamps with timezone
...
Fixes: https://pagure.io/koji/issue/2160
2020-06-24 09:44:52 +02:00
Tomas Kopecek
3839e2498c
PR#2329: docs: align "Hub" text in diagram
...
Merges #2329
https://pagure.io/koji/pull-request/2329
2020-06-23 12:44:52 +02:00
Ken Dreyer
ec032a2cfc
docs: align "Hub" text in diagram
...
Prior to this change, Google Chrome's SVG renderer did not display "Hub"
centered in the Koji structure diagram.
Re-do the "Hub" text in the diagram so that it is centered in Inkscape,
Firefox, and Chrome.
2020-06-23 12:44:43 +02:00
Tomas Kopecek
fcca060a05
PR#2330: clean_old option was duplicated on clean_empty
...
Merges #2330
https://pagure.io/koji/pull-request/2330
Fixes #2332
https://pagure.io/koji/issue/2332
2020-06-23 12:33:00 +02:00
Kevin Fenzi
fa8ac96d54
clean_old option was duplicated on clean_empty
...
The --no-old option wouldn't work because the check was checking for
--no-empty, and --no-empty was disabling both checks. :)
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-06-23 12:32:51 +02:00
Tomas Kopecek
b3049b0ebf
PR#2331: hub: document listChannels arguments
...
Merges #2331
https://pagure.io/koji/pull-request/2331
2020-06-23 12:24:12 +02:00
Ken Dreyer
993be46a4c
hub: document listChannels arguments
...
Describe the arguments and return value for the listChannels() method.
2020-06-23 12:24:04 +02:00
Tomas Kopecek
40d205b73f
PR#2318: make mock depsolver policy configurable
...
Merges #2318
https://pagure.io/koji/pull-request/2318
Fixes : #826
https://pagure.io/koji/issue/826
Make mock depsolver policy configurable
2020-06-23 12:21:15 +02:00
Tomas Kopecek
ac38549992
make mock depsolver policy configurable
...
Fixes: https://pagure.io/koji/issue/826
2020-06-23 09:02:15 +02:00
Tomas Kopecek
62998b0885
PR#1932: per-tag settings for mock's sign plugin
...
Merges #1932
https://pagure.io/koji/pull-request/1932
Fixes : #84
https://pagure.io/koji/issue/84
[Feature Request] Allow koji-builder to use Mock's sign plugin to automatically sign package after build
2020-06-19 13:30:07 +02:00
Tomas Kopecek
ae1561876c
flake8 fix
2020-06-19 13:23:59 +02:00
Tomas Kopecek
baa14dd38e
update docs
2020-06-19 13:21:53 +02:00
Tomas Kopecek
8e7b616ca4
fix option names
2020-06-19 13:21:53 +02:00
Tomas Kopecek
477fb48b67
per-tag settings for mock's sign plugin
...
Based on amessina's patch
Fixes: https://pagure.io/koji/issue/84
2020-06-19 13:21:53 +02:00
Tomas Kopecek
c06404246e
PR#2328: koji-gc: fix flake8
...
Merges #2328
https://pagure.io/koji/pull-request/2328
2020-06-18 15:53:22 +02:00
Tomas Kopecek
4f925cec2b
koji-gc: fix flake8
2020-06-18 15:51:42 +02:00
Tomas Kopecek
19b491ec47
PR#2218: Drop py2 support for hub/web
...
Merges #2218
https://pagure.io/koji/pull-request/2218
Fixes : #1942
https://pagure.io/koji/issue/1942
Drop py2 support for hub/web
2020-06-18 15:41:44 +02:00
Tomas Kopecek
51358cfd09
simplify py3 tests
2020-06-18 15:41:35 +02:00
Tomas Kopecek
af311184fc
dropping six from hub/web
2020-06-18 15:41:35 +02:00
Tomas Kopecek
83d425f976
drop py2 hub and web from spec
...
Fixes: https://pagure.io/koji/issue/1942
2020-06-18 15:41:35 +02:00
Tomas Kopecek
ac0e8812d5
PR#2316: kojira: replace deprecated Thread.isAlive()
...
Merges #2316
https://pagure.io/koji/pull-request/2316
Fixes : #2312
https://pagure.io/koji/issue/2312
kojiria uses depreciated isAlive() call
2020-06-18 15:36:03 +02:00
Tomas Kopecek
2baa24bd4e
kojira: replace deprecated Thread.isAlive()
...
From py 2.7 exists an alias is_alive, so it is safe to replace it.
Fixes: https://pagure.io/koji/issue/2312
2020-06-18 15:35:51 +02:00
Tomas Kopecek
70fa7017e0
PR#2309: hub: simplify recipients condition in build_notification()
...
Merges #2309
https://pagure.io/koji/pull-request/2309
2020-06-18 15:22:52 +02:00
Ken Dreyer
d7d745295a
hub: simplify recipients condition in build_notification()
...
If get_notification_recipients() returns a non-empty list of recipients,
then the build_notification() method creates a new buildNotification task.
Simplify the conditional that checks the get_notification_recipients()
return value so that it is easier to read. Python treats an empty list
as False and a non-empty list as True, so we don't need to explicitly
test the list length here.
The purpose of this change is to make this code easier to read and
understand.
2020-06-18 15:22:44 +02:00
Tomas Kopecek
64147a3322
PR#2326: sidetag: parenthesis typo
...
Merges #2326
https://pagure.io/koji/pull-request/2326
Fixes : #2321
https://pagure.io/koji/issue/2321
Give koji admins the permission to remove-side-tag of others
2020-06-18 13:06:53 +02:00
Tomas Kopecek
b61df1bcc5
sidetag: parenthesis typo
...
Related: https://pagure.io/koji/issue/2321
2020-06-18 13:05:29 +02:00
Tomas Kopecek
474f346d48
PR#2322: Side tags: allow admin ops and misc fixes
...
Merges #2322
https://pagure.io/koji/pull-request/2322
Fixes : #2321
https://pagure.io/koji/issue/2321
Give koji admins the permission to remove-side-tag of others
2020-06-17 11:53:08 +02:00
Nils Philippsen
cad3e63ee5
Allow admins to operate on all sidetags
...
Fixes : #2321
Signed-off-by: Nils Philippsen <nils@redhat.com>
2020-06-17 11:52:58 +02:00
Nils Philippsen
a8c72a7740
Actually return results from is_sidetag()/_owner()
...
Signed-off-by: Nils Philippsen <nils@redhat.com>
2020-06-17 11:52:58 +02:00
Tomas Kopecek
fe596571e6
PR#2323: kojira: Fix logic detecting directories
...
Merges #2323
https://pagure.io/koji/pull-request/2323
Fixes #2324
https://pagure.io/koji/issue/2324
2020-06-17 10:18:37 +02:00
Nils Philippsen
ffd282031d
Fix logic detecting directories
...
Signed-off-by: Nils Philippsen <nils@redhat.com>
2020-06-16 17:39:01 +02:00
Tomas Kopecek
cc5adaeb61
PR#2276: document merge modes
...
Merges #2276
https://pagure.io/koji/pull-request/2276
Fixes : #2099
https://pagure.io/koji/issue/2099
Document merge modes
2020-06-16 13:28:34 +02:00
Tomas Kopecek
196ee64f58
extend docs
2020-06-16 13:28:26 +02:00
Tomas Kopecek
089bc38320
document merge modes
...
Fixes: https://pagure.io/koji/issue/2099
2020-06-16 13:28:26 +02:00