Commit graph

5552 commits

Author SHA1 Message Date
Tomas Kopecek
1a2efb49f1 move migration to correct script
Fixes: https://pagure.io/koji/issue/2521
2020-10-05 10:25:18 +02:00
Tomas Kopecek
9191474888 PR#2518: util: [rmtree] try best to catch errors for race condition
Merges #2518
https://pagure.io/koji/pull-request/2518

Fixes: #2481
https://pagure.io/koji/issue/2481
koji.util.rmtree() is not multi-process/thread safe
2020-10-05 10:14:41 +02:00
Yu Ming Zhu
52a63f732d util: [rmtree] try best to catch errors for race condition
fixes: #2481

This approach is ugly, but just working.

ENOENT and ESTALE errors are catched in `chdir`, `listdir` calls to stomach the deletion by other process/thread

ENOTEMPTY is catched when calling `os.rmdir(path)` in `rmtree()` too. It happens when `path` is on an NFS like where ESTALE happens.
2020-10-05 10:14:34 +02:00
Mike McLean
fa56a5b25b PR#2505: cli: show log urls for failed tasks
Merges #2505
https://pagure.io/koji/pull-request/2505

Fixes: #2188
https://pagure.io/koji/issue/2188
RFE: provide direct URL to logfile when a failure occurs
2020-10-02 12:44:11 -04:00
Tomas Kopecek
bc478c2d68 cli: show log urls for failed tasks
Fixes: https://pagure.io/koji/issue/2188
2020-10-02 12:44:07 -04:00
Tomas Kopecek
30e87348b8 PR#2512: proton: missing default value for timestamp
Merges #2512
https://pagure.io/koji/pull-request/2512

Fixes: #2230
https://pagure.io/koji/issue/2230
protonmsg persistent message queue
2020-10-01 09:24:07 +02:00
Tomas Kopecek
5167fee215 proton: missing default value for timestamp
Related: https://pagure.io/koji/issue/2230
2020-10-01 09:21:51 +02:00
Tomas Kopecek
e8119e52be PR#2438: report versions of components
Merges #2438
https://pagure.io/koji/pull-request/2438

Fixes: #2430
https://pagure.io/koji/issue/2430
RFE: version discoverable from cli and web
2020-09-30 10:43:28 +02:00
Tomas Kopecek
4b1cbe0789 flake8 fix 2020-09-30 10:43:19 +02:00
Tomas Kopecek
a14a1fee39 fix for older hub 2020-09-30 10:43:19 +02:00
Tomas Kopecek
455745b153 update version 2020-09-30 10:43:19 +02:00
Tomas Kopecek
5f472413c9 drop host versions 2020-09-30 10:43:19 +02:00
Tomas Kopecek
ba908fd2de report versions of components
Fixes: https://pagure.io/koji/issue/2430
2020-09-30 10:43:19 +02:00
Tomas Kopecek
729f84767c PR#2441: proton: persistent message queue
Merges #2441
https://pagure.io/koji/pull-request/2441

Fixes: #2230
https://pagure.io/koji/issue/2230
protonmsg persistent message queue
2020-09-30 10:14:58 +02:00
Mike McLean
4ddc48e72a avoid message re-insertion, extend test mode, schema and docs updates
include new table in main schema, since this plugin is part of Koji itself

clean up and expand the docs for this plugin

refactor query_from_db() into handle_db_msgs()
* fix lock error cases
* only delete messages from queue if we successfully send them
* handle test_mode

allow test_mode to exercise db queue via test_mode_fail setting
2020-09-30 10:14:49 +02:00
Tomas Kopecek
aff74c4b3a proton: handling of lock failure 2020-09-30 10:14:49 +02:00
Tomas Kopecek
99c21690c2 delete too old messages 2020-09-30 10:14:49 +02:00
Tomas Kopecek
8c253396e8 proton: persistent message queue
Fixes: https://pagure.io/koji/issue/2230
2020-09-30 10:14:49 +02:00
Tomas Kopecek
dfccd676b9 PR#2510: doc: remove the link of Chinese user guide which is out-of-date
Merges #2510
https://pagure.io/koji/pull-request/2510

Fixes: #1377
https://pagure.io/koji/issue/1377
Error when building the PDF documentation
2020-09-28 15:46:47 +02:00
Yuming Zhu
a2c8ebc144 doc: remove the link of Chinese user guide which is out-of-date 2020-09-28 15:46:38 +02:00
Tomas Kopecek
49ce0a4f1f PR#2508: doc: update pg requirements for partitioning
Merges #2508
https://pagure.io/koji/pull-request/2508

Fixes: #1938
https://pagure.io/koji/issue/1938
Clarify versions needed for database partitioning doc
2020-09-28 13:55:59 +02:00
Tomas Kopecek
620888a089 doc: update pg requirements for partitioning
Fixes: https://pagure.io/koji/issue/1938
2020-09-28 13:54:31 +02:00
Tomas Kopecek
5e8ed0c166 PR#2495: blocking inherited extra
Merges #2495
https://pagure.io/koji/pull-request/2495

Fixes: #2283
https://pagure.io/koji/issue/2283
No way to unset/block inherited tag.extra values
2020-09-28 11:03:51 +02:00
Tomas Kopecek
08494de774 block inherited extra tag info
Fixes: https://pagure.io/koji/issue/2283
2020-09-28 11:03:43 +02:00
Tomas Kopecek
98ebd872bf PR#2498: cli: list-tag-inheritance - description of flags
Merges #2498
https://pagure.io/koji/pull-request/2498

Fixes: #2296
https://pagure.io/koji/issue/2296
"koji list-tag-inheritance --help" does not explain the "." characters
2020-09-23 13:59:37 +02:00
Tomas Kopecek
c1cd6a6327 cli: list-tag-inheritance - description of flags
Fixes: https://pagure.io/koji/issue/2296
2020-09-23 13:59:28 +02:00
Tomas Kopecek
b75d3cc31a PR#2148: Simplify obtaining of PKGDIR
Merges #2148
https://pagure.io/koji/pull-request/2148

Fixes #2149
https://pagure.io/koji/issue/2149
2020-09-22 13:45:54 +02:00
Michal Privoznik
0ef3c75185 Simplify obtaining of PKGDIR
So far, in all Makefiles we have a complicated way to construct
PKGDIR path which is used to install python modules into.
Firstly, python version is obtained, and then system prefix and
these are then used to construct the PKGDIR path. Well, we can do
better. We can use 'site.getsitepackages()[0]' to obtain exactly
the path we are after.

This also fixes the problem on distributions which have split
/usr/lib and /usr/lib64 directories, because with the way we are
constructing the PKGDIR path we assume that the directories are
the same (or one is a symlink to another). Well, that is not
always the case.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2020-09-22 13:45:48 +02:00
Tomas Kopecek
1a1f7e29c1 PR#2499: flake8 fix
Merges #2499
https://pagure.io/koji/pull-request/2499
2020-09-22 12:22:16 +02:00
Tomas Kopecek
1b8efdfa69 flake8 fix 2020-09-22 12:21:07 +02:00
Tomas Kopecek
edf5bbdc4a PR#2494: prune-signed-copies fix help message
Merges #2494
https://pagure.io/koji/pull-request/2494

Fixes: #2488
https://pagure.io/koji/issue/2488
CLI prune-signed-copies has wrong 'Usage' command in help
2020-09-22 10:19:04 +02:00
Jana Cupova
f62c0d0080 prune-signed-copies fix help message
Fixes: https://pagure.io/koji/issue/2488
2020-09-22 10:18:55 +02:00
Tomas Kopecek
efaae9db22 PR#2492: web: wrong variable name
Merges #2492
https://pagure.io/koji/pull-request/2492

Fixes: #2491
https://pagure.io/koji/issue/2491
NameMapper.NotFound web interface traceback
2020-09-22 09:54:35 +02:00
Tomas Kopecek
968a129290 web: wrong variable name
Fixes: https://pagure.io/koji/issue/2491
2020-09-22 09:54:28 +02:00
Tomas Kopecek
c55dc316f7 PR#2485: builder: configurable TTL for buildroots
Merges #2485
https://pagure.io/koji/pull-request/2485

Fixes: #2374
https://pagure.io/koji/issue/2374
TaskManager: make some (max/min) time configurable in `updateBuildroots`
2020-09-17 14:16:13 +02:00
Tomas Kopecek
05dd937146 fix default value 2020-09-17 14:16:02 +02:00
Tomas Kopecek
16b4562056 fix option parsing 2020-09-17 14:16:02 +02:00
Tomas Kopecek
4c9c20180c typo 2020-09-17 14:16:02 +02:00
Tomas Kopecek
f674f554f8 builder: configurable TTL for buildroots
Fixes: https://pagure.io/koji/issue/2374
2020-09-17 14:16:02 +02:00
Tomas Kopecek
6587d19e10 PR#2478: web: urlquote buildtarget/buildtag names
Merges #2478
https://pagure.io/koji/pull-request/2478

Fixes: #2468
https://pagure.io/koji/issue/2468
web: [hyperlink] cannot handle tag/target whose name contains "+" correctly
2020-09-17 14:12:13 +02:00
Tomas Kopecek
f4d0898a71 web: urlquote buildtarget/buildtag names
Fixes: https://pagure.io/koji/issue/2468
2020-09-17 14:12:05 +02:00
Tomas Kopecek
ae2261b4c7 PR#2486: cli: propagate system exit codes
Merges #2486
https://pagure.io/koji/pull-request/2486

Fixes: #2273
https://pagure.io/koji/issue/2273
kojira with no such options returns code 2, koji CLI returns 1
2020-09-15 16:11:11 +02:00
Tomas Kopecek
c0ffe4ed27 cli: propagate system exit codes
Fixes: https://pagure.io/koji/issue/2273
2020-09-15 16:11:01 +02:00
Tomas Kopecek
4ae23c1847 PR#2477: hub: deleteBuild should skip deleted builds
Merges #2477
https://pagure.io/koji/pull-request/2477

Fixes: #2475
https://pagure.io/koji/issue/2475
deleteBuild should skip already deleted builds
2020-09-10 13:24:10 +02:00
Tomas Kopecek
59b97d56f1 hub: deleteBuild should skip deleted builds
We can return ASAP from the call if build is already deleted.

Fixes: https://pagure.io/koji/issue/2475
2020-09-10 13:24:02 +02:00
Tomas Kopecek
37cd4223e4 PR#2464: cli: clone-tag fails on failed multicalls
Merges #2464
https://pagure.io/koji/pull-request/2464

Fixes: #2010
https://pagure.io/koji/issue/2010
clone-tag should check all the server-side errors
2020-09-09 14:06:31 +02:00
Tomas Kopecek
df8ce93699 fix test 2020-09-09 14:02:42 +02:00
Tomas Kopecek
e407957c0a cli: clone-tag fails on failed multicalls
Fixes: https://pagure.io/koji/issue/2010
2020-09-09 14:00:51 +02:00
Tomas Kopecek
ded2f65e5d tests: fix coveragerc 2020-09-08 16:21:40 +02:00
Tomas Kopecek
9557d1b253 PR#2386: Run tests in virtualenvs using tox
Merges #2386
https://pagure.io/koji/pull-request/2386

Fixes #2391
https://pagure.io/koji/issue/2391
2020-09-08 16:20:29 +02:00