Yuming Zhu
20ee6081e0
flake8: apply rules for koji-sidetag-cleanup
2020-03-03 21:38:22 +08:00
Yuming Zhu
d21083a11b
still use BaseException for logging purpose
2020-03-03 21:38:22 +08:00
Yuming Zhu
cf34706f04
use Exception instead of BaseException for bare expection
2020-03-03 21:38:22 +08:00
Yuming Zhu
b3b0c8d51e
flake8: ignore F812 rule for PY2
2020-03-03 21:38:22 +08:00
Yuming Zhu
a3d3604416
flake8: update contribution guide for flake8
2020-03-03 21:38:22 +08:00
Yuming Zhu
31006ed775
add test-requirements.txt to install testing related modules by pip
2020-03-03 21:38:22 +08:00
Yuming Zhu
8c76bcde74
flake8: apply all rules after rebasing
2020-03-03 21:38:22 +08:00
Yuming Zhu
2a2c5cb729
flake8: apply W rules (prefering W503)
2020-03-03 21:38:22 +08:00
Yuming Zhu
c5db34a8e1
flake8: apply E501 with max-line-length=99
2020-03-03 21:38:22 +08:00
Yuming Zhu
f1ba6cefd7
flake8: apply all rest E7 rules
2020-03-03 21:38:22 +08:00
Yuming Zhu
6ed30954b2
flake8: apply E71x rule
2020-03-03 21:38:22 +08:00
Yuming Zhu
fa69c4904e
flake8: apply E70x rule
2020-03-03 21:38:22 +08:00
Yuming Zhu
6dd77e0fa4
flake8: apply E502 rule
2020-03-03 21:38:22 +08:00
Yuming Zhu
1416630e42
flake8: apply E4 rules and ignore E402 in sidetag_hub plugin
2020-03-03 21:38:22 +08:00
Yuming Zhu
0f727a2ab4
flake8: apply E3 rules
2020-03-03 21:38:22 +08:00
Yuming Zhu
05340b146b
flake8: apply E2 rules except E266
2020-03-03 21:38:21 +08:00
Yuming Zhu
ce1f9928af
flake8: apply E1 rules
2020-03-03 21:38:21 +08:00
Yuming Zhu
450f9249cd
flake8: apply E265 for util/koji-*
2020-03-03 21:35:08 +08:00
Yuming Zhu
0a0ee577ec
flake8: apply F rules for koji-shadow
2020-03-03 21:35:08 +08:00
Yu Ming Zhu
49504073b1
refine import style
2020-03-03 21:35:08 +08:00
Yuming Zhu
a0a9dd74ca
flake8: util/koji-* were ignored
2020-03-03 21:35:08 +08:00
Yuming Zhu
97cfaa4fcf
flake8: follow E265 rule
2020-03-03 21:35:08 +08:00
Yuming Zhu
642508ccf6
flake8: follow all F rules
2020-03-03 21:35:08 +08:00
Tomas Kopecek
7b4c7aa3d1
PR#1891: Disable notifications from clone-tag by default
...
Merges #1891
https://pagure.io/koji/pull-request/1891
Fixes : #1890
https://pagure.io/koji/issue/1890
clone-tag should not generate notifications
2020-03-03 14:13:53 +01:00
Christopher O'Brien
ff1996564c
Disable notifications from clone-tag by default
...
The tagBuildBypass and untagBuildBypass invocations in the clone-tag
CLI were not setting the notify option, leaving it at the default of
True. This means in some cases many hundreds of notification events
would be triggered from a clone-tag call.
Change the default behavior of clone-tag to explicitly disable
notifications
Add a new --notify option to clone-tag to re-enable notifications for
tagging and untagging of builds.
Fixes : #1890
2020-03-03 14:13:48 +01:00
Christopher O'Brien
e4062ea1ea
allow python to find its own version of nose rather than looking for a binary which may not exist
2020-03-03 14:13:48 +01:00
Tomas Kopecek
5dc492ada4
PR#2006: add missing koji-sidetag-cleanup script
...
Merges #2006
https://pagure.io/koji/pull-request/2006
Fixes : #2005
https://pagure.io/koji/issue/2005
sidetag plugin merge missed cleanup script
2020-03-02 14:27:22 +01:00
Tomas Kopecek
1cfe6e50e4
add missing koji-sidetag-cleanup script
...
Fixes: https://pagure.io/koji/issue/2005
2020-03-02 14:27:15 +01:00
Mike McLean
de92fc1cb6
PR#2025: Include livemedia builds in accepted wrapperRPM methods
...
Merges #2025
https://pagure.io/koji/pull-request/2025
2020-02-26 18:04:39 -05:00
Brendan Reilly
67b30845fc
Include livemedia builds in accepted wrapperRPM methods
2020-02-26 18:04:36 -05:00
Tomas Kopecek
a5cff3a7c5
PR#2045: insert path before import kojihub
...
Merges #2045
https://pagure.io/koji/pull-request/2045
2020-02-26 13:29:12 +01:00
Tomas Kopecek
4c315dddc0
PR#2034: update docs to current jenkins setup
...
Merges #2034
https://pagure.io/koji/pull-request/2034
Fixes : #1871
https://pagure.io/koji/issue/1871
flake8 to check code style
2020-02-25 10:31:55 +01:00
Tomas Kopecek
d86273e39d
update docs to current jenkins setup
...
Fixes: https://pagure.io/koji/issue/1871
2020-02-25 10:31:45 +01:00
Tomas Kopecek
5f026cd752
PR#1987: Add doc string for virtual methods
...
Merges #1987
https://pagure.io/koji/pull-request/1987
Fixes : #1533
https://pagure.io/koji/issue/1533
Add doc string for virtual methods
2020-02-25 10:25:05 +01:00
Tomas Kopecek
344f00a2a5
move _apidoc cache to session
...
Fixes: https://pagure.io/koji/issue/1533
2020-02-25 10:24:55 +01:00
Till Maas
cdf63326c7
Add doc string for virtual methods
2020-02-25 10:24:55 +01:00
Tomas Kopecek
fbfeff5df7
PR#1916: replace xmlrpc_client exception with requests
...
Merges #1916
https://pagure.io/koji/pull-request/1916
Fixes : #1914
https://pagure.io/koji/issue/1914
kojid doesn't fail correctly during the startup problems
2020-02-21 12:40:47 +01:00
Tomas Kopecek
638f6cc6f2
replace xmlrpc_client exception with requests
...
It is broken in startup function for kojid and kojivmd from the
introduction of requests.
Fixes: https://pagure.io/koji/issue/1914
2020-02-21 12:40:42 +01:00
Tomas Kopecek
c30c4a48fd
PR#751: xmlrpcplus: use parent Marshaller's implementations where possible
...
Merges #751
https://pagure.io/koji/pull-request/751
Fixes: https://pagure.io/koji/issue/1538
2020-02-21 09:44:52 +01:00
Ken Dreyer
81d685b07d
xmlrpcplus: use parent Marshaller's nil implementation
...
We can enable the None -> "nil" behavior when we instantiate our
Marshaller. RHEL 5 and newer supports allow_none here.
This allows us to drop the dump_nil code from our custom Marshaller and
rely directly on the parent class's method instead.
2020-02-21 09:44:46 +01:00
Ken Dreyer
aa35b84c8c
xmlrpcplus: use parent's int marshalling if possible
...
If we have an int value between xmlrpc.MININT and xmlrpc.MAXINT, we can
rely on stdlib's xmlrpc.Marshaller. This allows us to drop this custom
code.
2020-02-21 09:44:46 +01:00
Tomas Kopecek
41d9a61088
PR#2004: obsolete external sidetag plugin
...
Merges #2004
https://pagure.io/koji/pull-request/2004
Fixes : #2003
https://pagure.io/koji/issue/2003
Original sidetags plugin is not correctly obsoleted in spec
2020-02-19 14:17:26 +01:00
Tomas Kopecek
3462b35361
obsolete external sidetag plugin
...
Fixes: https://pagure.io/koji/issue/2003
2020-02-19 14:17:18 +01:00
Tomas Kopecek
98a86c87be
PR#1992: deprecation of krb_login
...
Merges #1992
https://pagure.io/koji/pull-request/1992
Fixes : #1906
https://pagure.io/koji/issue/1906
Deprecate/drop non-gssapi code
2020-02-19 14:15:25 +01:00
Tomas Kopecek
72b4c0c3e2
deprecation of krb_login
...
Fixes: https://pagure.io/koji/issue/1906
2020-02-19 14:15:17 +01:00
Tomas Kopecek
fa55182571
PR#2020: move needed functions
...
Merges #2020
https://pagure.io/koji/pull-request/2020
Fixes : #1484
https://pagure.io/koji/issue/1484
Handle malformed tasks gracefully
2020-02-18 13:38:11 +01:00
Tomas Kopecek
0a9712b28f
move needed functions
...
Related: https://pagure.io/koji/issue/1484
2020-02-18 13:38:04 +01:00
Tomas Kopecek
73df118b03
PR#1958: fix potentially undeclared variable error
...
Merges #1958
https://pagure.io/koji/pull-request/1958
Fixes : #1957
https://pagure.io/koji/issue/1957
unreferenced variable
2020-02-18 11:54:15 +01:00
Tomas Kopecek
d6f2db6325
fix potentially undeclared variable error
...
Fixes: https://pagure.io/koji/issue/1957
2020-02-18 11:54:11 +01:00
Tomas Kopecek
7158c85241
announce utf-8 coding
2020-02-18 11:20:51 +01:00