Commit graph

3695 commits

Author SHA1 Message Date
Tomas Kopecek
27abb872c6 Expand user directory from config
Fixes: https://pagure.io/koji/issue/1022
2018-08-16 09:09:29 -04:00
Mike McLean
7ca9d7829d PR#1002: prioritize unittest2
Merges #1002
https://pagure.io/koji/pull-request/1002

Fixes: #1001
https://pagure.io/koji/issue/1001
unittest is still used in some places instead of unittest2
2018-08-16 09:03:16 -04:00
Tomas Kopecek
bd649d2723 prioritize unittest2
Make all imports consistent with
https://pagure.io/koji/issue/830

Fixes: https://pagure.io/koji/issue/1001
2018-08-16 09:03:09 -04:00
Mike McLean
cd761147ae PR#1000: Fix target handling in make_task
Merges #1000
https://pagure.io/koji/pull-request/1000

Fixes: #998
https://pagure.io/koji/issue/998
cancel build doesn't work for images
2018-08-14 17:12:12 -04:00
Tomas Kopecek
f9d1de99f6 Fix target handling in make_task
Fixes: https://pagure.io/koji/issue/998
2018-08-14 17:12:05 -04:00
Mike McLean
05e791374e PR#997: Fix rpmdiff's ignoring of size
Merges #997
https://pagure.io/koji/pull-request/997

Fixes: #994
https://pagure.io/koji/issue/994
rpmdiff calculate wrong results
2018-08-10 15:48:44 -04:00
Mike McLean
e559653ab5 simplify ignore logic in rpmdiff function 2018-08-10 15:47:46 -04:00
Tomas Kopecek
d1544e7f05 Correctly ignore all values in rpmdiff
Related: https://pagure.io/koji/issue/994
2018-08-10 15:47:46 -04:00
Franz Chih-Ping Hsieh
e25603dd97 copy data from static variable instead of use it directly to prevent caching.
also update test cases to verfiy this issue.

Fixes: #994
https://pagure.io/koji/issue/994
2018-08-10 15:47:46 -04:00
Mike McLean
304b1708c4 PR#1012: Fix isinstance with lists
Merges #1012
https://pagure.io/koji/pull-request/1012

Fixes: #1011
https://pagure.io/koji/issue/1011
isinstance doesn't accept list of classes
2018-08-08 11:34:46 -04:00
Tomas Kopecek
3cc443df97 Fix isinstance with lists
Fixes: https://pagure.io/koji/issue/1011
2018-08-08 11:34:39 -04:00
Mike McLean
fd4eb9fadc PR#1030: Create symlinks for builds imported onto non-default volumes
Merges #1030
https://pagure.io/koji/pull-request/1030

Fixes: #1025
https://pagure.io/koji/issue/1025
missing default volume symlink for imported builds affected by volume policy
2018-08-08 11:25:29 -04:00
Mike McLean
549d9d7955 more checks in unit test 2018-08-08 11:22:59 -04:00
Mike McLean
d9c44735cc actually add unit test 2018-08-08 11:22:59 -04:00
Mike McLean
484bf0181a create parent dir for symlink if needed 2018-08-08 11:22:59 -04:00
Mike McLean
b92afc0fed ensure volume symlinks in import pathways 2018-08-08 11:22:59 -04:00
Mike McLean
f8947a9215 add ensure_volume_symlink() function 2018-08-08 11:22:59 -04:00
Mike McLean
0d7e69ddd2 PR#1021: Raise error for non-200 codes in download_file
Merges #1021
https://pagure.io/koji/pull-request/1021

Fixes: #1020
https://pagure.io/koji/issue/1020
download_file function doesn't raise errors for non-200 codes
2018-08-08 11:20:40 -04:00
Tomas Kopecek
913efc47d1 Raise error for non-200 codes in download_file
Fixes: https://pagure.io/koji/issue/1020
2018-08-08 11:20:33 -04:00
Mike McLean
a9d23403dd PR#1005: Add unit tests for check volume id substitution list
Merges #1005
https://pagure.io/koji/pull-request/1005
2018-08-08 11:06:46 -04:00
Jana Cupova
9f9a72f4d6 Fix code review 2018-08-08 11:06:41 -04:00
Jana Cupova
8173ec7bac Change to one test with variants 2018-08-08 11:06:41 -04:00
Jana Cupova
4f2a632c98 Add unit tests for check volume id substitution list 2018-08-08 11:06:41 -04:00
Mike McLean
e05f871b4a PR#1027: [kojihub] add strict parameter in getBuildNotification
Merges #1027
https://pagure.io/koji/pull-request/1027

Fixes: #1009
https://pagure.io/koji/issue/1009
getBuildNotification API call should raise GenericError exception for non existing notification ID
2018-08-08 10:09:52 -04:00
Yuming Zhu
b4c5c95684 [kojihub] add strict parameter in getBuildNotification 2018-08-08 10:09:46 -04:00
Mike McLean
4a214437ee PR#1016: raise Error when user not found in getBuildNotifications
Merges #1016
https://pagure.io/koji/pull-request/1016

Fixes: #1013
https://pagure.io/koji/issue/1013
getBuildNotifications API call should raise GenericError exception for non existing user ID
2018-08-07 16:09:07 -04:00
Yuming Zhu
5a229a092e raise Error when user not found in getBuildNotifications 2018-07-31 17:50:07 +08:00
Mike McLean
e50cd283b8 PR#1008: decode_args(): make a copy of the opts dict, rather than modifying it in-place
Merges #1008
https://pagure.io/koji/pull-request/1008

Fixes: #1007
https://pagure.io/koji/issue/1007
decode_args() might result in --package parameter missing in runroot command
2018-07-27 15:56:44 -04:00
Franz Chih-Ping Hsieh
646c43561a decode_args(): make a copy of the opts dict, rather than modifying it in-place
Fixes: #1007
https://pagure.io/koji/issue/1007

  Author: Mike Bonnet <mikeb@redhat.com>
  Date:   Wed Jul 18 17:03:56 2018 -0700

    The commit changes make_task() to call decode_args() on the arglist before
    it is saved to the db. If the method was called with keyword arguments, those
    would be passed in a dict at the end of the arglist, with a __starstar entry.
    decode_args() edits that dict in place, removing the __starstar entry and
    making the arglist appear to end in a single dict argument, effectively
    removing the keyword arguments. This change makes a copy of the dict before
2018-07-25 15:07:11 -04:00
Mike McLean
38e6a4f401 PR#989: additional info on builders in channelinfo page
Merges #989
https://pagure.io/koji/pull-request/989

Fixes: #988
https://pagure.io/koji/issue/988
[RFE] more info about builders in channelinfo page
2018-07-11 18:11:25 -04:00
Tomas Kopecek
167b296311 additional info on builders in channelinfo page
Fixes: https://pagure.io/koji/issue/988
2018-07-11 18:11:18 -04:00
Mike McLean
147f781183 PR#685: Rest of automated conversion from py3 changes
Merges #685
https://pagure.io/koji/pull-request/685
2018-07-11 17:37:45 -04:00
Tomas Kopecek
f464160ac6 fix tuple expansion in args 2018-07-11 17:37:40 -04:00
Tomas Kopecek
d9ac4ed85c python-modernize -f lib2to3.fixes.fix_numliterals 2018-07-11 17:37:40 -04:00
Tomas Kopecek
6f7f828f77 python-modernize -f lib2to3.fixes.fix_except 2018-07-11 17:37:40 -04:00
Tomas Kopecek
9b3cf26dc2 fix sort(l) vs l.sort() typo 2018-07-11 17:37:40 -04:00
Tomas Kopecek
242e143b97 fix double import typo 2018-07-11 17:37:40 -04:00
Tomas Kopecek
caae1a0a8b workaround unnecessary list conversions 2018-07-11 17:37:40 -04:00
Tomas Kopecek
56095e8018 fix unicode type checks 2018-07-11 17:37:40 -04:00
Tomas Kopecek
b37236d7ae fix incorrect divisions 2018-07-11 17:37:40 -04:00
Tomas Kopecek
8e61dc7c56 python-modernize -f libmodernize.fixes.fix_classic_division 2018-07-11 17:37:40 -04:00
Tomas Kopecek
bc425033b5 fix rest of int/long 2018-07-11 17:37:40 -04:00
Tomas Kopecek
220e889f2b python-modernize -f libmodernize.fixes.fix_int_long_tuple 2018-07-11 17:37:40 -04:00
Tomas Kopecek
707c6b7774 python-modernize -f libmodernize.fixes.fix_map 2018-07-11 17:37:39 -04:00
Tomas Kopecek
be535c2854 python-modernize -f libmodernize.fixes.fix_imports_six 2018-07-11 17:37:39 -04:00
Tomas Kopecek
f03646bab5 python-modernize -f lib2to3.fixes.fix_methodattrs 2018-07-11 17:37:39 -04:00
Tomas Kopecek
9173587056 python-modernize -f lib2to3.fixes.fix_funcattrs 2018-07-11 17:37:39 -04:00
Tomas Kopecek
d92fa1fa9c python-modernize -f libmodernize.fixes.fix_file 2018-07-11 17:37:39 -04:00
Tomas Kopecek
5ad9027320 python-modernize -f libmodernize.fixes.fix_basestring 2018-07-11 17:37:39 -04:00
Tomas Kopecek
7f6b717eb6 python-modernize -f libmodernize.fixes.fix_import 2018-07-11 17:37:39 -04:00