Commit graph

7641 commits

Author SHA1 Message Date
Tomas Kopecek
2b45e9889e PR#4082: More mocking cleanup
Merges #4082
https://pagure.io/koji/pull-request/4082
2024-06-04 12:55:04 +02:00
Mike McLean
48d78bd535 more mock.patch cleanup 2024-06-04 12:54:58 +02:00
Mike McLean
1a51320e86 avoid test failure when running in console 2024-06-04 12:54:58 +02:00
Tomas Kopecek
8d65a6ef18 PR#4087: Increase index.py unit tests
Merges #4087
https://pagure.io/koji/pull-request/4087
2024-06-04 12:51:38 +02:00
Jana Cupova
eabf1c8b3d Increase index.py unit tests 2024-06-04 12:51:31 +02:00
Tomas Kopecek
86acc4d3dd PR#4090: Koji 1.34.1 release notes
Merges #4090
https://pagure.io/koji/pull-request/4090

Fixes: #4089
https://pagure.io/koji/issue/4089
release notes 1.34.1
2024-05-30 13:09:31 +02:00
Tomas Kopecek
18c258e44f Koji 1.34.1 release notes
Related: https://pagure.io/koji/issue/4089
2024-05-30 13:09:24 +02:00
Tomas Kopecek
b997909f48 PR#4097: stop suggesting that users need repo permission
Merges #4097
https://pagure.io/koji/pull-request/4097

Related #4099
https://pagure.io/koji/issue/4099
2024-05-20 11:42:17 +02:00
Mike McLean
70b0556aca stop suggesting that users need repo permission
regen-repo allows (only) newRepo
repo allows this, but also repo state management. It is only for kojira.

The current acl error reads:
koji.ActionNotAllowed: repo permission required

This prompts users to request the wrong permission
2024-05-20 11:42:09 +02:00
Tomas Kopecek
5d25e10a49 PR#4095: drop unused DBHandler class
Merges #4095
https://pagure.io/koji/pull-request/4095

Fixes: #4096
https://pagure.io/koji/issue/4096
2024-05-13 10:28:07 +02:00
Mike McLean
68833a10a7 drop unused DBHandler class
This has been unreferenced since #507 was merged
See: https://pagure.io/koji/pull-request/507
2024-05-10 16:08:01 -04:00
Tomas Kopecek
54b0aa3355 PR#4088: tests: py3 versions compatibility fixes
Merges #4088
https://pagure.io/koji/pull-request/4088
2024-05-06 13:26:31 +02:00
Tomas Kopecek
5801ac8b13 tests: py3 versions compatibility fixes 2024-05-06 13:17:48 +02:00
Tomas Kopecek
df86feab7f PR#4056: avoid explicit rowlock in taskWaitCheck
Merges #4056
https://pagure.io/koji/pull-request/4056

Relates: #4057
https://pagure.io/koji/issue/4057
Deadlocks in taskWaitCheck
2024-05-06 11:26:10 +02:00
Mike McLean
b283835220 avoid explicit rowlock in taskWaitCheck 2024-05-06 11:26:01 +02:00
Tomas Kopecek
a9526e8403 PR#4086: Drop part of code related to host without update_ts
Merges #4086
https://pagure.io/koji/pull-request/4086

Fixes: #4085
https://pagure.io/koji/issue/4085
Remove part of code in index.py which is for older hub related to update_ts for host
2024-05-06 11:23:35 +02:00
Jana Cupova
9b27e267da Drop part of code related to host without update_ts
Fixes: https://pagure.io/koji/issue/4085
2024-05-06 11:23:26 +02:00
Tomas Kopecek
e5ec3dad0b PR#4066: fix errors in channel policy
Merges #4066
https://pagure.io/koji/pull-request/4066

Fixes: #4065
https://pagure.io/koji/issue/4065
build target policy failure
2024-04-24 15:00:55 +02:00
Mike McLean
d0e90d3687 fix errors in channel policy
Fixes: https://pagure.io/koji/issue/4065
2024-04-24 15:00:45 +02:00
Tomas Kopecek
d0de585229 PR#4073: sort checksums before inserting
Merges #4073
https://pagure.io/koji/pull-request/4073

Fixes: #4072
https://pagure.io/koji/issue/4072
deadlocks in create_rpm_checksum
2024-04-24 15:00:03 +02:00
Mike McLean
1932796ef5 use upsert to avoid duplicate inserts 2024-04-24 14:59:54 +02:00
Mike McLean
d54dedc039 sort checksums before inserting 2024-04-24 14:59:54 +02:00
Mike McLean
c7aeda7898 fakehub --no-commit option 2024-04-24 14:59:54 +02:00
Tomas Kopecek
8187761c01 PR#4051: fixes for list-users
Merges #4051
https://pagure.io/koji/pull-request/4051

Fixes: #4050
https://pagure.io/koji/issue/4050
updated list-users command fails for 1.34 hub
2024-04-24 14:48:07 +02:00
Mike McLean
bf6e437df3 new cli tests for coverage 2024-04-24 14:47:57 +02:00
Mike McLean
eb18210744 fix unit tests 2024-04-24 14:47:57 +02:00
Mike McLean
9200c67ade warn if hub does not support --usertype any 2024-04-24 14:47:57 +02:00
Mike McLean
8e74f198a2 adjust help 2024-04-24 14:47:57 +02:00
Mike McLean
32239f2c68 address issues with list-users
Fixes: https://pagure.io/koji/issue/4050
2024-04-24 14:47:57 +02:00
Tomas Kopecek
f5c9ca95f6 PR#4068: Rework mocking of QueryProcessor in DBQueryTestCase
Merges #4068
https://pagure.io/koji/pull-request/4068

Fixes: #4071
https://pagure.io/koji/issue/4071
DBQueryTestCase class doesn't work for other hub modules

Relates: #2758
https://pagure.io/koji/issue/2758
DBQueryTest doesn't clean mock env
2024-04-15 11:08:38 +02:00
Mike McLean
2485b87294 more missing tearDowns 2024-04-15 11:08:29 +02:00
Mike McLean
f49ee80a7b fix missing tearDown methods for numerous tests 2024-04-15 11:08:29 +02:00
Mike McLean
a807137c3c rework DBQueryTestCase mocking
Mocking kojihub.kojihub.QueryProcessor doesn't affect other import
paths, e.g. in other kojihub modules
2024-04-15 11:08:29 +02:00
Tomas Kopecek
4df957cb3d PR#4069: add requirement: defusedxml in setup.py
Merges #4069
https://pagure.io/koji/pull-request/4069

Fixes: #4067
https://pagure.io/koji/issue/4067
defusedxml missing from setup.py
2024-04-12 12:10:12 +02:00
Yuming Zhu
ad7cea732d add requirement: defusedxml in setup.py
fixes: #4067
2024-04-12 12:10:05 +02:00
Tomas Kopecek
6e2e795be2 PR#4046: kiwi: Generate full logs with debug information
Merges #4046
https://pagure.io/koji/pull-request/4046

Fixes #4048
https://pagure.io/koji/issue/4048
2024-04-10 14:41:22 +02:00
Neal Gompa
baa5a735e1 kiwi: Generate full logs with debug information
Without this flag, we do not have logs that include the details of
what happened during the build.
2024-04-10 14:41:15 +02:00
Tomas Kopecek
d331654069 PR#4012: rmtree: use fork
Merges #4012
https://pagure.io/koji/pull-request/4012

Fixes: #3755
https://pagure.io/koji/issue/3755
koji-gc occasionally gets Directory not empty fault on delete

Fixes: #2481
https://pagure.io/koji/issue/2481
koji.util.rmtree() is not multi-process/thread safe
2024-04-10 11:20:23 +02:00
Mike McLean
4dd0e24b00 correct a few comment lines 2024-04-10 11:20:15 +02:00
Mike McLean
ce4718f1fb fix samefile check and relative path test 2024-04-10 11:20:15 +02:00
Mike McLean
e8ae18fcc8 Align our cwd tracking with os 2024-04-10 11:20:15 +02:00
Mike McLean
895d0cf8ec avoid double fork in kojira rmtree 2024-04-10 11:20:15 +02:00
Mike McLean
f9eefde102 cleanup 2024-04-10 11:20:15 +02:00
Mike McLean
c0917955c0 more testcases 2024-04-10 11:20:15 +02:00
Mike McLean
4fddafc54d rmtree: use fork
These changes work around a thread safety issue in our rmtree
implementation, which uses chdir to traverse the directory tree.
Using chdir resolves issues deleting paths longer than PATH_MAX, but
makes the code inherently unsafe in a threaded environment.

Now, the main rmtree function uses fork to perform the actions in a
dedicated process.
To avoid possible locking issues with the logging module, we introduce a
simple proxy logger for the subprocess.

Fixes: https://pagure.io/koji/issue/3755

For historical context see:
https://pagure.io/koji/issue/201
https://pagure.io/koji/issue/2481
https://pagure.io/koji/issue/2714
2024-04-10 11:20:15 +02:00
Tomas Kopecek
c4b50c65c7 PR#4044: Update getNextTask for scheduler
Merges #4044
https://pagure.io/koji/pull-request/4044

Fixes: #4028
https://pagure.io/koji/issue/4028
Clean getNextTask
2024-03-28 15:58:15 +01:00
Mike McLean
9c8b9a1556 skip updateBuildroots if we have just taken a task 2024-03-28 15:58:07 +01:00
Mike McLean
1d0d4f2683 add unit tests and drop obsolete ones 2024-03-28 15:58:07 +01:00
Mike McLean
5c383b6175 clean up logging 2024-03-28 15:58:07 +01:00
Mike McLean
3554a1fb43 update getNextTask to use host.getTasks 2024-03-28 15:58:07 +01:00