Tomas Kopecek
482ea1eda8
PR#2799: kojid.conf: fix linewrapped comment
...
Merges #2799
https://pagure.io/koji/pull-request/2799
Fixes : #2800
https://pagure.io/koji/issue/2800
kojid.conf: fix linewrapped comment
2021-04-06 13:38:13 +02:00
Kevin Fenzi
1fcde3464f
kojid.conf: fix linewrapped comment
...
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2021-04-03 17:37:45 -07:00
Tomas Kopecek
f3349d696f
PR#2794: lib: set sinfo=None for failed ssl_login
...
Merges #2794
https://pagure.io/koji/pull-request/2794
Fixes : #2793
https://pagure.io/koji/issue/2793
ssl login can traceback on missing sinfo
2021-03-31 13:54:13 +02:00
Tomas Kopecek
a7c769fd41
lib: set sinfo=None for failed ssl_login
...
Fixes: https://pagure.io/koji/issue/2793
2021-03-31 13:54:08 +02:00
Tomas Kopecek
eb644e7e4c
PR#2689: lib: missing default values in read_config
...
Merges #2689
https://pagure.io/koji/pull-request/2689
Fixes : #2668
https://pagure.io/koji/issue/2668
TypeError in _callMethod()'s max_tries conditional
2021-03-31 13:51:39 +02:00
Tomas Kopecek
32929a7916
lib: missing default values in read_config
...
e.g. self.opts.get('max_retries', 30) will return wrong value if there
is None as a default value.
Fixes: https://pagure.io/koji/issue/2668
2021-03-31 13:51:34 +02:00
Tomas Kopecek
d8c46e85e8
PR#2784: Tolerate floats in metadata timestamps
...
Merges #2784
https://pagure.io/koji/pull-request/2784
Fixes : #2783
https://pagure.io/koji/issue/2783
Kojira failing with non-int timestamps in repomd.xml
2021-03-30 14:49:28 +02:00
Alex Iribarren
2b83d458c6
Tolerate floats in metadata timestamps
2021-03-30 14:49:22 +02:00
Tomas Kopecek
0d3a3304e9
PR#2787: Revert "requests exception"
...
Merges #2787
https://pagure.io/koji/pull-request/2787
Fixes : #2786
https://pagure.io/koji/issue/2786
ClientSession fails to retry on RequestException
2021-03-29 11:27:27 +02:00
Mike McLean
c71ebec58a
Revert "requests exception"
...
This reverts commit ff8c13969e .
Fixes https://pagure.io/koji/issue/2786
2021-03-29 11:27:22 +02:00
Tomas Kopecek
fa1e3f833d
PR#2770: cli: buildinfo returns error for non exist build
...
Merges #2770
https://pagure.io/koji/pull-request/2770
Fixes : #2762
https://pagure.io/koji/issue/2762
CLI buildinfo returns code 0 for non existing build
2021-03-29 11:24:33 +02:00
Jana Cupova
b9f261d8de
cli: buildinfo returns error for non exist build
...
Fixes: https://pagure.io/koji/issue/2762
2021-03-29 11:24:26 +02:00
Tomas Kopecek
f7a6338483
PR#2766: api getLastHostUpdate returns timestamp
...
Merges #2766
https://pagure.io/koji/pull-request/2766
Fixes : #2497
https://pagure.io/koji/issue/2497
getLastHostUpdate returns time only as a string
2021-03-29 11:23:12 +02:00
Jana Cupova
9dc0efd476
api getLastHostUpdate returns timestamp
...
fixes: https://pagure.io/koji/issue/2497
2021-03-29 11:23:06 +02:00
Tomas Kopecek
217704fd67
PR#2735: lib: more verbose conn AuthError for ssl/gssapi
...
Merges #2735
https://pagure.io/koji/pull-request/2735
Fixes : #2502
https://pagure.io/koji/issue/2502
client: better error handling in gssapi_login()
2021-03-29 11:22:12 +02:00
Tomas Kopecek
3321abbf88
lib: more verbose conn AuthError for ssl/gssapi
...
Fixes: https://pagure.io/koji/issue/2502
2021-03-29 11:22:06 +02:00
Tomas Kopecek
5c40091b70
PR#2782: Be tolerant with duplicate parents in _writeInheritanceData
...
Merges #2782
https://pagure.io/koji/pull-request/2782
Fixes : #2614
https://pagure.io/koji/issue/2614
CLI add-tag-inheritance --force returns error
Relates: #1435
https://pagure.io/koji/issue/1435
changes for writeInheritanceData should not contain duplicated parent_id
2021-03-29 11:19:46 +02:00
Yuming Zhu
8845b9eba1
Be tolerant with duplicate parents in _writeInheritanceData
...
Now setInheritanceData API supports duplicate parents in data again.
And we choose to clean the other fields from "delete link" items, so that the ineffective update after deletion which was reported in #1435 .
fixes : #2614
relates: #1434
relates: #1435
2021-03-29 11:19:40 +02:00
Tomas Kopecek
8b53dc74e3
PR#2615: cli: catch koji.ParameterError in list_task_output_all_volumes
...
Merges #2615
https://pagure.io/koji/pull-request/2615
Fixes #2686
https://pagure.io/koji/issue/2686
2021-03-25 14:00:04 +01:00
Ken Dreyer
8d0b4bc618
cli: catch koji.ParameterError in list_task_output_all_volumes
...
When we send an RPC with a parameter that the hub does not understand,
we get a koji.ParameterError.
Update list_task_output_all_volumes() to catch the specific error we
expect here.
The purpose of this change is to make the code easier to understand.
2021-03-25 13:59:59 +01:00
Tomas Kopecek
ed04738b58
PR#2749: web: optional KojiHubCA usage
...
Merges #2749
https://pagure.io/koji/pull-request/2749
Fixes : #2742
https://pagure.io/koji/issue/2742
web looking for hub CA even without SSL auth
2021-03-24 17:18:11 +01:00
Tomas Kopecek
700a7bbdd4
web: optional KojiHubCA usage
...
Fixes: https://pagure.io/koji/issue/2742
2021-03-24 17:18:05 +01:00
Tomas Kopecek
b5c8d41e6a
PR#2753: drop PyOpenSSL usage
...
Merges #2753
https://pagure.io/koji/pull-request/2753
Fixes : #2752
https://pagure.io/koji/issue/2752
revisit pyOpenSSL usage
2021-03-24 14:43:47 +01:00
Tomas Kopecek
ebdbb80e02
drop PyOpenSSL usage
...
We've replaced it with requests library some time ago, this code has no
better sensitivity than requests error checking, so we can drop it
completely.
Fixes: https://pagure.io/koji/issue/2752
2021-03-24 14:43:40 +01:00
Tomas Kopecek
2dc537199a
PR#2765: kojira: check repo.json before deleting
...
Merges #2765
https://pagure.io/koji/pull-request/2765
Fixes : #1321
https://pagure.io/koji/issue/1321
[kojira] If tag is renamed, old repos will never be deleted
2021-03-23 13:47:53 +01:00
Tomas Kopecek
1a76030707
kojira: check repo.json before deleting
...
Fixes: https://pagure.io/koji/issue/1321
2021-03-23 13:47:48 +01:00
Tomas Kopecek
267f5bbae0
PR#2777: docs: fix Fedora's koji URL
...
Merges #2777
https://pagure.io/koji/pull-request/2777
Fixes : #2776
https://pagure.io/koji/issue/2776
I canot visit url from doc?
2021-03-23 13:46:30 +01:00
Tomas Kopecek
5ad2715be7
docs: fix Fedora's koji URL
...
Fixes: https://pagure.io/koji/issue/2776
2021-03-23 13:17:49 +01:00
Tomas Kopecek
21ec2511f4
PR#2722: cli: use multicall for cancel command
...
Merges #2722
https://pagure.io/koji/pull-request/2722
Fixes : #2607
https://pagure.io/koji/issue/2607
cli: cancel-build should use multicall
2021-03-22 15:12:07 +01:00
Tomas Kopecek
7333a8e174
cli: use multicall for cancel command
...
Fixes: https://pagure.io/koji/issue/2607
2021-03-22 15:12:01 +01:00
Tomas Kopecek
e2f4aa794f
PR#2772: Fix small documentation typo
...
Merges #2772
https://pagure.io/koji/pull-request/2772
2021-03-18 16:27:16 +01:00
Alex Iribarren
14dcd554c3
Fix typo
2021-03-18 16:27:11 +01:00
Tomas Kopecek
66e6ee322b
make flake8 happy
2021-03-18 16:13:29 +01:00
Tomas Kopecek
131c5fa1bb
PR#2699: Fix race handling in rmtree
...
Merges #2699
https://pagure.io/koji/pull-request/2699
Fixes : #2698
https://pagure.io/koji/issue/2698
rmtree can fail with mysterious error in race
2021-03-18 15:46:22 +01:00
Mike McLean
362c3e5cc6
more rmtree unit tests
2021-03-18 15:46:16 +01:00
Mike McLean
144dc70010
fix logic
2021-03-18 15:46:16 +01:00
Mike McLean
08139a9e39
update unit tests
2021-03-18 15:46:16 +01:00
Mike McLean
9cceb6764d
rework rmtree a bit
2021-03-18 15:46:16 +01:00
Tomas Kopecek
788b2775ed
PR#2755: kojira: check rm queue before adding new path
...
Merges #2755
https://pagure.io/koji/pull-request/2755
Fixes : #2716
https://pagure.io/koji/issue/2716
kojira: duplicate deletes
2021-03-18 15:33:37 +01:00
Tomas Kopecek
e83dd2757e
kojira: check rm queue before adding new path
...
It is a remnant of previsou unification of rmtree paths. Instead of
deleting tree directly while deleting repo it is put into queue now. So,
other thread looking for expired/deleted repos can find it also and add
it twice. Internal rmtree can check the queue before adding duplicate
path. As a side-effect manager.rmtree can also never fail, so try/except
can be removed from there.
Fixes: https://pagure.io/koji/issue/2716
2021-03-18 15:33:31 +01:00
Tomas Kopecek
8a74740bb9
PR#2769: cli: hostinfo with non-exist host
...
Merges #2769
https://pagure.io/koji/pull-request/2769
Fixes : #2763
https://pagure.io/koji/issue/2763
CLI hostinfo returns code 0 for non existing host
2021-03-18 10:50:42 +01:00
Jana Cupova
de09faca6c
cli: hostinfo with non-exist host
...
Fixes: https://pagure.io/koji/issue/2763
2021-03-18 10:50:36 +01:00
Tomas Kopecek
9df4b1fb33
PR#2768: tests: fix locale setting
...
Merges #2768
https://pagure.io/koji/pull-request/2768
Fixes : #2767
https://pagure.io/koji/issue/2767
fix locale setting in test
2021-03-18 10:16:03 +01:00
Tomas Kopecek
8ed86e86ee
tests: fix locale setting
...
Fixes: https://pagure.io/koji/issue/2767
2021-03-18 10:11:51 +01:00
Tomas Kopecek
33efc94893
PR#2721: API: createWinBuild with wrong win/build info
...
Merges #2721
https://pagure.io/koji/pull-request/2721
Fixes : #1102
https://pagure.io/koji/issue/1102
createWinBuild API call should raise GenericError exception for non existing build name
Fixes : #1103
https://pagure.io/koji/issue/1103
createWinBuild API call should raise GenericError exception for empty win build info
2021-03-17 10:12:51 +01:00
Jana Cupova
9c6483f197
API: createWinBuild with wrong win/build info
...
createWinBuild returns an error when win info is empty, is not a dict or
doesn't contain platform key
createWinBuild returns an error when build info is string and build is
not existing
Fixes: https://pagure.io/koji/issue/1103
Fixes: https://pagure.io/koji/issue/1102
2021-03-17 10:12:45 +01:00
Tomas Kopecek
ea5f4621e5
PR#2761: cli: rpminfo with non-exist rpm
...
Merges #2761
https://pagure.io/koji/pull-request/2761
Fixes : #2643
https://pagure.io/koji/issue/2643
CLI rpminfo does not raise exception for non-existing nvra
2021-03-17 10:11:09 +01:00
Jana Cupova
0c9c8c6a81
cli: rpminfo with non-exist rpm
...
Fixes: https://pagure.io/koji/issue/2643
2021-03-17 10:11:03 +01:00
Tomas Kopecek
f6ca9aa50b
PR#2736: api: createMavenBuild wrong buildinfo/maveninfo
...
Merges #2736
https://pagure.io/koji/pull-request/2736
Fixes : #1105
https://pagure.io/koji/issue/1105
createMavenBuild API call should raise GenericError exception for maven info without all obligatory keys
Fixes : #1104
https://pagure.io/koji/issue/1104
createMavenBuild API call should raise GenericError exception for non existing build name
2021-03-16 15:25:23 +01:00
Jana Cupova
36284cdea9
api: createMavenBuild wrong buildinfo/maveninfo
...
Fixes: https://pagure.io/koji/issue/1104
Fixes: https://pagure.io/koji/issue/1105
2021-03-16 15:25:15 +01:00