Commit graph

6522 commits

Author SHA1 Message Date
Ken Dreyer
5469452da7 cli: rename "args" var for list-tags command
Instead of re-using the "args" variable, name this variable something
more descriptive to reflect that these are tag name patterns.
2022-04-01 13:12:14 -04:00
Tomas Kopecek
8e3973ad36 PR#3248: Retry gssapi_login if it makes sense
Merges #3248
https://pagure.io/koji/pull-request/3248

Fixes: #3170
https://pagure.io/koji/issue/3170
gssapi_login doesn't have any retries
2022-03-29 12:28:32 +02:00
Tomas Kopecek
d95e3ff094 logging and comment update 2022-03-29 12:28:17 +02:00
Tomas Kopecek
30af3a6bf5 fix test 2022-03-29 12:28:17 +02:00
Tomas Kopecek
2f1090d051 Retry gssapi_login if it makes sense
Related: https://pagure.io/koji/issue/3170
2022-03-29 12:28:17 +02:00
Tomas Kopecek
94e27dbc64 PR#3303: www: fix attribute test
Merges #3303
https://pagure.io/koji/pull-request/3303

Fixes: #3302
https://pagure.io/koji/issue/3302
web ui: noisy error for empty search
2022-03-28 14:03:03 +02:00
Tomas Kopecek
c94ce02633 www: fix attribute test
Related: https://pagure.io/koji/issue/3302
2022-03-28 14:02:55 +02:00
Tomas Kopecek
ddd5f221a8 PR#3292: docs: Task flow diagram
Merges #3292
https://pagure.io/koji/pull-request/3292

Fixes: #3267
https://pagure.io/koji/issue/3267
Document API 'state' and 'waiting'
2022-03-28 14:00:56 +02:00
Tomas Kopecek
cdb31f8486 additional description 2022-03-28 14:00:50 +02:00
Tomas Kopecek
d6a0267571 docs: Task flow diagram
Fixes: https://pagure.io/koji/issue/3267
2022-03-28 14:00:50 +02:00
Tomas Kopecek
c92464936d PR#3290: web: encode filename as UTF-8
Merges #3290
https://pagure.io/koji/pull-request/3290

Fixes #3290
https://pagure.io/koji/issue/3291
2022-03-28 13:53:38 +02:00
Ji-Hyeon Gim
1335841aeb web: encode filename as UTF-8
Signed-off-by: Ji-Hyeon Gim <potatogim@gluesys.com>
2022-03-28 13:53:32 +02:00
Tomas Kopecek
4e6e781c11 PR#3259: kojira: don't call listTags more than once
Merges #3259
https://pagure.io/koji/pull-request/3259

Fixes: #3258
https://pagure.io/koji/issue/3258
Kojira fills tag cache too often
2022-03-28 13:46:45 +02:00
Tomas Kopecek
9d568cb828 kojira: don't call listTags more than once
Fixes: https://pagure.io/koji/issue/3258
2022-03-28 13:46:37 +02:00
Tomas Kopecek
ce0ea82b78 PR#3262: Fix parsing of URLs with port numbers
Merges #3262
https://pagure.io/koji/pull-request/3262

Fixes #3287
https://pagure.io/koji/issue/3287
2022-03-25 15:37:44 +01:00
Alex Iribarren
9bc9680285 Fix parsing of URLs with port numbers 2022-03-25 15:37:37 +01:00
Tomas Kopecek
6444cf144b PR#3298: Use buildins.type when option is called type in readTaggedRPMS
Merges #3298
https://pagure.io/koji/pull-request/3298

Fixes: #3283
https://pagure.io/koji/issue/3283
readTaggedRPMS has conflict with param type and type function
2022-03-25 14:48:51 +01:00
Jana Cupova
a0b8ec8bfd Use builtins.type when option is called type in readTaggedRPMS
Fixes: https://pagure.io/koji/issue/3283
2022-03-24 13:05:30 +01:00
Tomas Kopecek
44f1eb9d11 PR#3300: Same format output for list-builroot with verbose for py3/py2
Merges #3300
https://pagure.io/koji/pull-request/3300

Fixes: #3299
https://pagure.io/koji/issue/3299
CLI list-buildroot with verbose print different format of message on py3 and py2
2022-03-24 13:00:01 +01:00
Jana Cupova
49f5f72a9f Same format output for list-builroot with verbose for py3/py2
Fixes: https://pagure.io/koji/issue/3299
2022-03-24 12:59:58 +01:00
Tomas Kopecek
16c2e6e576 PR#3297: doc: fix readTaggedRPMs rpmsigs option description
Merges #3297
https://pagure.io/koji/pull-request/3297

Fixes: #3231
https://pagure.io/koji/issue/3231
listTaggedRPMS documentation inconsistent with behaviour
2022-03-24 11:18:33 +01:00
Tomas Kopecek
3131a64178 doc: fix readTaggedRPMs rpmsigs option description
Related: https://pagure.io/koji/issue/3231
2022-03-23 14:02:29 +01:00
Tomas Kopecek
2394af63d9 PR#3234: Check ccache size before trying to use it
Merges #3234
https://pagure.io/koji/pull-request/3234

Fixes: #3233
https://pagure.io/koji/issue/3233
Kojid not able to authenticate when ccache is empty
2022-03-22 10:25:03 +01:00
Daniel Juarez
e596ca6fcb Check ccache size before trying to use it 2022-03-22 10:24:54 +01:00
Tomas Kopecek
1a71dcef81 PR#3270: Increase CLI test cases
Merges #3270
https://pagure.io/koji/pull-request/3270
2022-03-21 14:42:14 +01:00
Jana Cupova
a8f11fbf9c Increase CLI test cases 2022-03-21 14:42:08 +01:00
Tomas Kopecek
ba407086fb PR#3208: hub: improve inheritance priority collision error message
Merges #3208
https://pagure.io/koji/pull-request/3208
2022-03-21 14:39:45 +01:00
Ken Dreyer
ddb46d744b hub: improve inheritance priority collision error message
When users set multiple parents to the same priority in
setInheritanceData(), we raise an error because this is an invalid
configuration.

Improve the error message to make it easier for humans to understand the
problem and explain which tag ID ints are parents or children.
2022-03-21 14:39:05 +01:00
Tomas Kopecek
f5fe7a550e PR#3269: return 400 codes when client fails to send a full request
Merges #3269
https://pagure.io/koji/pull-request/3269

Fixes: #3268
https://pagure.io/koji/issue/3268
Some network errors cannot be retried
2022-03-21 14:34:37 +01:00
Mike McLean
f89794ce07 also raise 400 errors when we can't read the client upload stream 2022-03-21 14:34:30 +01:00
Mike McLean
37b108bf24 fix indent 2022-03-21 14:34:30 +01:00
Mike McLean
3ece0d8e05 return 400 codes when client fails to send a full request
Fixes: https://pagure.io/koji/issue/3268
2022-03-21 14:34:30 +01:00
Tomas Kopecek
c5749fc414 PR#3265: Set dst permissions same as src permissions
Merges #3265
https://pagure.io/koji/pull-request/3265

Fixes: #3260
https://pagure.io/koji/issue/3260
Koji 1.28.0 writes RPMs with mode 0600 (not accessible for distRepo tasks via NFS)
2022-03-21 14:33:50 +01:00
Jana Cupova
b3258c4273 Set dst permissions same as src permissions
Fixes: https://pagure.io/koji/issue/3260
2022-03-21 14:33:43 +01:00
Tomas Kopecek
4429b88385 PR#3255: allow untag-build for blocked packages
Merges #3255
https://pagure.io/koji/pull-request/3255

Fixes: #3134
https://pagure.io/koji/issue/3134
Allow untagging "invisible" tagged builds
2022-03-21 14:32:30 +01:00
Jana Cupova
d561ded4fa allow untag-build for blocked packages
https://pagure.io/koji/issue/3134
2022-03-21 14:32:23 +01:00
Tomas Kopecek
2a6f186210 PR#3252: Fix tag and target shows as string, not as dict to string
Merges #3252
https://pagure.io/koji/pull-request/3252

Fixes: #3251
https://pagure.io/koji/issue/3251
webUI shows tag and targets on webUI as dict, when user create task with dict param
2022-03-21 14:30:10 +01:00
Jana Cupova
8f91020a01 Fix tag and target shows as string, not as dict to string
Fixes: https://pagure.io/koji/issue/3251
2022-03-21 14:30:03 +01:00
Tomas Kopecek
47a80cf0ff PR#3238: Remove koji.listFaults
Merges #3238
https://pagure.io/koji/pull-request/3238

Fixes: #3083
https://pagure.io/koji/issue/3083
Remove deprecated listFaults
2022-03-21 14:29:18 +01:00
Jana Cupova
995b57c961 Remove koji.listFaults
Fixes: https://pagure.io/koji/issue/3083
2022-03-21 14:29:11 +01:00
Tomas Kopecek
bd1b996e69 PR#3237: Remove taskReport API call
Merges #3237
https://pagure.io/koji/pull-request/3237

Fixes: #3032
https://pagure.io/koji/issue/3032
Remove deprecated taskReport
2022-03-21 14:28:35 +01:00
Jana Cupova
dc58186d1f Remove taskReport API call
Fixes: https://pagure.io/koji/issue/3032
2022-03-21 14:28:29 +01:00
Alex Iribarren
68040263d3 Fix syntax error
Fixes: https://pagure.io/koji/issue/3264
2022-02-25 08:47:38 +01:00
Tomas Kopecek
77aec93b98 Revert "refactor exceptions to koji.exceptions"
This reverts commit 1e00081991.
2022-02-21 12:33:25 +01:00
Tomas Kopecek
fd84571f82 Revert "add "NoSuch" custom exceptions"
This reverts commit 3ff8eef322.
2022-02-21 12:33:18 +01:00
Tomas Kopecek
a99c695728 PR#3240: [WIP] Koji 1.28.0 release notes
Merges #3240
https://pagure.io/koji/pull-request/3240

Fixes: #3224
https://pagure.io/koji/issue/3224
1.28 release notes
2022-02-21 12:27:47 +01:00
Tomas Kopecek
a9e440e725 fix typo 2022-02-10 15:45:01 +01:00
Tomas Kopecek
7081ce90db Koji 1.28.0 release notes
Fixes: https://pagure.io/koji/issue/3224
2022-02-10 15:45:01 +01:00
Ken Dreyer
3ff8eef322 add "NoSuch" custom exceptions
Add more custom exception classes. This will allow to programmatically
determine the error causes from complex RPCs.

This commit simply defines the new classes and fault codes. Nothing in
Koji's codebase uses these exceptions yet. We'll begin to raise these
exceptions after this is widely deployed for clients in the field.
2022-02-10 15:44:04 +01:00
Ken Dreyer
1e00081991 refactor exceptions to koji.exceptions
Move Koji's custom exceptions classes to a dedicated koji.exceptions
library. This organizes the code so it's easier to maintain, and matches
patterns in other well-known projects, like requests.exceptions or
cryptography.exceptions.
2022-02-10 15:44:04 +01:00