Commit graph

3869 commits

Author SHA1 Message Date
Tomas Kopecek
715b40d6b9 spec changes for py3 hub
Fixes: https://pagure.io/koji/issue/905
2019-02-05 16:46:32 +01:00
Tomas Kopecek
5cd9ed7e56 fix new test 2019-02-05 15:49:54 +01:00
Tomas Kopecek
afa636264a fix import 2019-02-05 15:49:54 +01:00
Tomas Kopecek
ca29c78046 fix bytes/str in rpm header 2019-02-05 15:49:54 +01:00
Tomas Kopecek
8b3edd6d95 fix test 2019-02-05 15:49:54 +01:00
Tomas Kopecek
d0338fd4e7 fix code inspects 2019-02-05 15:49:54 +01:00
Tomas Kopecek
2343763598 marshaller update 2019-02-05 15:49:54 +01:00
Tomas Kopecek
dbb955426c rename masked rpm variable 2019-02-05 15:49:54 +01:00
Tomas Kopecek
b6ff16b624 db ordering fixes 2019-02-05 15:49:54 +01:00
Tomas Kopecek
69a12c13d1 convert py2 sorting to py3 2019-02-05 15:49:42 +01:00
Tomas Kopecek
9eaf244141 fix encoding 2019-02-05 15:49:24 +01:00
Tomas Kopecek
fd9a6a32a1 encode xmlrpc responses correctly 2019-02-05 15:49:13 +01:00
Tomas Kopecek
4d7535374c fix file handling 2019-02-05 14:24:49 +01:00
Tomas Kopecek
60132d25f4 six.moves xmlrpc_client, parse_qs 2019-02-05 14:24:49 +01:00
Mike McLean
ce1644b4e2 PR#1182: hub: document get_channel arguments
Merges #1182
https://pagure.io/koji/pull-request/1182
2019-01-30 19:59:56 -05:00
Ken Dreyer
5a69365b9f hub: document get_channel arguments
Describe each of the arguments to the get_channel() method.
2019-01-30 19:59:46 -05:00
Mike McLean
21c5bd317e PR#1014: cli: preserve build order in clone-tag
Merges #1014
https://pagure.io/koji/pull-request/1014

Fixes: #960
https://pagure.io/koji/issue/960
clone-tag can get things wrong when destination tag has content already
2019-01-30 18:09:21 -05:00
Yuming Zhu
ca26e38023 delete all other builds when latest_only and dsttag exists 2019-01-30 18:09:05 -05:00
Mike McLean
64c29c61d4 rename var, tweak logic, and add comments for clarity 2019-01-30 18:09:05 -05:00
Yuming Zhu
efece06adf preserve group order 2019-01-30 18:09:05 -05:00
Yuming Zhu
b42bc3ebde [clone-tag] preserve build order and fix group cloning 2019-01-30 18:09:05 -05:00
Mike McLean
39f84abf32 PR#1218: docs: drop HTML tags from howto doc
Merges #1218
https://pagure.io/koji/pull-request/1218
2019-01-29 05:23:31 -05:00
Ken Dreyer
46fc81a2ca docs: drop HTML tags from howto doc
When copying this page from Fedora's wiki, some HTML tags were missed in
the translation. Translate the HTML tags to their reStructuredText
equivalents.
2019-01-28 17:08:27 -07:00
Mike McLean
3a1d64abc4 PR#1211: Fix wrong error message
Merges #1211
https://pagure.io/koji/pull-request/1211

Fixes: #1210
https://pagure.io/koji/issue/1210
CLI command free-task returns an error everytime
2019-01-28 10:50:48 -05:00
Tomas Kopecek
2ca3284447 Fix wrong error message
Fixes: https://pagure.io/koji/issue/1210

for/else resulted in error with correct arguments.
2019-01-28 10:50:32 -05:00
Mike McLean
494c539254 PR#1184: rest of python3 support for koji lib
Merges #1184
https://pagure.io/koji/pull-request/1184
2019-01-28 09:09:08 -05:00
Yu Ming Zhu
dc66521ceb misc changes for build and test 2019-01-28 08:46:11 -05:00
Yuming Zhu
fa5ccf0eac using explicit coverage2/3 in Makefile 2019-01-28 08:46:11 -05:00
Yu Ming Zhu
30c2e5f426 sorted set in Error msgs of tasks.find_arch 2019-01-28 08:46:11 -05:00
Yu Ming Zhu
eb36620aa3 fix some unittests 2019-01-28 08:46:11 -05:00
Yu Ming Zhu
200951c9d6 fix zip for python3 2019-01-28 08:46:11 -05:00
Yu Ming Zhu
7ab1e2901d urllib fix for python3 2019-01-28 08:45:18 -05:00
Mike McLean
708ded8138 PR#1062: fix pyOpenSSL dependency for py26 in setup.py
Merges #1062
https://pagure.io/koji/pull-request/1062

Fixes: #1060
https://pagure.io/koji/issue/1060
pyopenssl 18.0.0 has dropped Python 2.6 support
2019-01-28 06:16:46 -05:00
Yuming Zhu
8586a227c6 fix pyOpenSSL dependency for py26 in setup.py 2019-01-28 06:16:35 -05:00
Mike McLean
e10daecd2b PR#1019: Use python2/3 instead of python in Makefile/spec
Merges #1019
https://pagure.io/koji/pull-request/1019

Fixes: #1018
https://pagure.io/koji/issue/1018
rpms can't be built in Fedora rawhide
2019-01-28 06:07:02 -05:00
Tomas Kopecek
b2230b9510 set default python 2019-01-28 06:06:50 -05:00
Franz Chih-Ping Hsieh
42f5988dc3 use macro to support RHEL8 build
Related: #986
2019-01-28 06:06:50 -05:00
Tomas Kopecek
ccdb8ac34c Use python2/3 instead of python in Makefile/spec
Fixes: https://pagure.io/koji/issue/1018
2019-01-28 06:06:50 -05:00
Mike McLean
c203afe7c2 PR#1190: hub: document all edit_tag arguments
Merges #1190
https://pagure.io/koji/pull-request/1190
2019-01-15 12:03:00 -05:00
Ken Dreyer
21e837db3e hub: document all edit_tag arguments
Reformat the description of the editTag2 RPC to Sphinx's doc format,
filling in the missing data types.
2019-01-15 12:02:55 -05:00
Mike McLean
822311fb56 PR#1201: re-add urlparse import in kojikamid
Merges #1201
https://pagure.io/koji/pull-request/1201
2019-01-15 11:42:32 -05:00
Mike Bonnet
6bdb18e26f re-add import removed by 921258749a
kojikamid has code from other files substituted into it, to reduce
copy-paste. In this case, the SCM class from koji/daemon.py
requires the urlparse module.
2019-01-15 11:42:21 -05:00
Mike McLean
a224695d1c PR#1203: Fix is_conn_error() for Python 3.3+ change to socket.error
Merges #1203
https://pagure.io/koji/pull-request/1203

See also: https://bugzilla.redhat.com/show_bug.cgi?id=1609298
2019-01-15 11:33:19 -05:00
Adam Williamson
1b6382891c Fix is_conn_error() for Python 3.3+ change to socket.error
In Python 3.3+, `socket.error` is no longer a distinct exception.
It is - as the docs say - "A deprecated alias of OSError". This
means that this check:

`isinstance(e, socket.error)`

is effectively equivalent to:

`isinstance(e, OSError)`

This is a problem, because `requests.exceptions.ConnectionError`
(another exception type we handle later in `is_conn_error()`) is
a subclass of `OSError` - so on Python 3 we never actually reach
the block that's intended to handle that exception type. We hit
the `isinstance(e, socket.error)` block at the start instead, and
of course the exception doesn't have an `errno` attribute, so we
just return `False` at that point.

There are a few different ways we could fix this; this commit
does it by ditching the `isinstance` checks, and dropping the
shortcut `return False` bailout from the early block. We'll still
ultimately return `False` unless the error is actually one of the
other types we handle; it just costs a couple more `isinstance`
checks.

I don't think replacing the `isinstance socket.error` checks is
really necessary at all. We can just check for an `errno` attr,
and if there is one and it's one of the values we check for...
that seems safe enough to treat as a connection error.

This also changes the second check to be a check of `e2`, not
`e` - I'm *fairly* sure this is what's actually intended, and
the current code was a copy-paste error.

Fixes: #1192

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-01-15 11:33:14 -05:00
Mike McLean
6cce316ff9 PR#967: use correct fileinfo checksum field
Merges #967
https://pagure.io/koji/pull-request/967

Fixes: #966
https://pagure.io/koji/issue/966
kojikamid makes wrong md5sum check
2019-01-15 10:53:49 -05:00
Mike McLean
8a36479cdb fix undefined var 2019-01-15 10:51:19 -05:00
Mike McLean
4fa2901720 cleanup
unused var
whitespace
missing import
2019-01-15 10:51:19 -05:00
Mike McLean
c60ec3c2f3 add a unit test 2019-01-15 10:51:19 -05:00
Tomas Kopecek
4191840bd7 check_sigmd5 for kojivmd 2019-01-15 10:51:19 -05:00
Tomas Kopecek
28ce53afc3 use correct fileinfo checksum field
Fixes: https://pagure.io/koji/issue/966
2019-01-15 10:51:19 -05:00