Commit graph

5121 commits

Author SHA1 Message Date
Ken Dreyer
819db9b642 koji-sweep-db: use "Type=oneshot" for systemd
"oneshot" is the appropriate choice for periodic cleanup scripts.
2020-05-05 11:08:11 +02:00
Tomas Kopecek
2012b1c734 PR#2213: Correct docstring about deleting inheritance rules
Merges #2213
https://pagure.io/koji/pull-request/2213
2020-05-05 10:45:35 +02:00
Carl George
7382eabe43 Correct docstring about deleting inheritance rules
The docstring for the setInheritanceData method states that a special
"remove link" key set to True will remove an inheritance rule.  The
_writeInheritanceData function actually looks for a "delete link" key.
The commit updates the docstring to reflect reality.
2020-05-04 23:52:18 -05:00
Tomas Kopecek
53c9fa3709 PR#2209: koji-utils: only requires /usr/bin/python2 on rhel<=7
Merges #2209
https://pagure.io/koji/pull-request/2209

Fixes: #2208
https://pagure.io/koji/issue/2208
koji-utils requires /usr/bin/python3 on rhel7
2020-04-29 14:26:04 +02:00
Yu Ming Zhu
c60080fb79 koji-utils: only requires /usr/bin/python2 on rhel<=7
fixes: #2208
2020-04-29 14:25:52 +02:00
Tomas Kopecek
0e54195c9a PR#2205: doc: fix koji-sweep-db filename typo
Merges #2205
https://pagure.io/koji/pull-request/2205
2020-04-29 10:15:52 +02:00
Ken Dreyer
9bdb0687d4 doc: fix koji-sweep-db filename typo
"sweepd" -> "sweep"
2020-04-29 10:15:44 +02:00
Tomas Kopecek
5c8075bc3a PR#2206: doc: indent SQL query for user ID discovery
Merges #2206
https://pagure.io/koji/pull-request/2206
2020-04-29 10:14:44 +02:00
Ken Dreyer
aa17d743bc doc: indent SQL query for user ID discovery
Prior to this change, Sphinx rendered the SQL query outside of the
"Note" box.

Indent the query further so that Sphinx renders it inside the "Note"
border.
2020-04-29 10:14:37 +02:00
Tomas Kopecek
f4b05ab953 PR#2207: cli: improve grant-permission --new --help message
Merges #2207
https://pagure.io/koji/pull-request/2207
2020-04-29 10:13:51 +02:00
Ken Dreyer
235018eca6 cli: improve grant-permission --new --help message
The --new option only creates a new permission if the permission does
not already exist. Update the --help message to indicate this.
2020-04-29 10:13:44 +02:00
Tomas Kopecek
9b67c6c892 PR#2203: hub: admin can't force tag now
Merges #2203
https://pagure.io/koji/pull-request/2203

Fixes: #2202
https://pagure.io/koji/issue/2202
Admin can't force tag now
2020-04-29 10:09:04 +02:00
Tomas Kopecek
9c7b4b91b1 don't traceback on missing user 2020-04-29 10:08:52 +02:00
Tomas Kopecek
913bc4026b hub: admin can't force tag now
Fixes: https://pagure.io/koji/issue/2202
2020-04-29 10:08:52 +02:00
Tomas Kopecek
ebf9255c2a PR#2194: remove obsoleted note
Merges #2194
https://pagure.io/koji/pull-request/2194

Fixes: #2170
https://pagure.io/koji/issue/2170
admins should not restart kojira after creating each new tag
2020-04-28 09:37:12 +02:00
Tomas Kopecek
9f6e273774 docs: remove obsoleted recommendation to restart kojira
Fixes: https://pagure.io/koji/issue/2170
2020-04-28 09:35:25 +02:00
Tomas Kopecek
65d26d0e91 PR#2158: hub: document addExternalRepoToTag arguments
Merges #2158
https://pagure.io/koji/pull-request/2158

Fixes #2164
https://pagure.io/koji/issue/2164
2020-04-27 15:17:52 +02:00
Ken Dreyer
0049e8604f hub: document addExternalRepoToTag arguments
Describe the types of each argument to the addExternalRepoToTag() method.
2020-04-27 15:17:44 +02:00
Tomas Kopecek
62fea17e10 PR#2172: hub: document createUser arguments
Merges #2172
https://pagure.io/koji/pull-request/2172
2020-04-27 10:00:14 +02:00
Ken Dreyer
a14a21b2c2 hub: document createUser arguments
Describe the types of each argument to the createUser() method.
2020-04-23 17:33:51 -06:00
Tomas Kopecek
d95eab0e92 PR#2180: cli: fix "list-history --help" text for "--cg"
Merges #2180
https://pagure.io/koji/pull-request/2180
2020-04-23 09:23:54 +02:00
Ken Dreyer
7faa36f523 cli: fix "list-history --help" text for "--cg"
Fix a bad copy-and-paste in the --help text for the "koji list-history"
command.
2020-04-22 13:29:31 -06:00
Tomas Kopecek
6a07c50356 PR#2044: Unify error messages in CLI
Merges #2044
https://pagure.io/koji/pull-request/2044

Fixes: #2043
https://pagure.io/koji/issue/2043
Unify error messages in CLI - next round
2020-04-22 14:54:18 +02:00
Tomas Kopecek
04f6ba886e fix tests 2020-04-22 14:54:10 +02:00
Tomas Kopecek
f873934473 replace print + return 1 with error() 2020-04-22 14:54:10 +02:00
Tomas Kopecek
58ef1338a8 fix flake8 2020-04-22 14:52:37 +02:00
Tomas Kopecek
fd9243ec87 PR#2024: queue log file for kojira
Merges #2024
https://pagure.io/koji/pull-request/2024

Fixes: #2023
https://pagure.io/koji/issue/2023
Display queue state in kojira
2020-04-22 13:54:39 +02:00
Tomas Kopecek
b4c1169da8 kojira: queue_file docs 2020-04-22 13:53:47 +02:00
Tomas Kopecek
539e024257 kojira: queue status file
Fixes: https://pagure.io/koji/issue/2023
2020-04-22 13:53:08 +02:00
Tomas Kopecek
b3feacaffe PR#2136: replace logging.warn with warning
Merges #2136
https://pagure.io/koji/pull-request/2136

Fixes: #2135
https://pagure.io/koji/issue/2135
logging.warn is deprecated in 3.7
2020-04-22 13:50:44 +02:00
Tomas Kopecek
0132313f92 replace logging.warn with warning
call is deprected in python 3.7

Fixes: https://pagure.io/koji/issue/2135
2020-04-22 13:47:15 +02:00
Tomas Kopecek
ef0730f5d5 PR#2038: Don't use listTagged(tag, *) for untag-build
Merges #2038
https://pagure.io/koji/pull-request/2038

Fixes: #2037
https://pagure.io/koji/issue/2037
untag-build hangs indefinitely
2020-04-22 13:39:19 +02:00
Tomas Kopecek
995f8e68c2 fix chain iteration
Fixes: https://pagure.io/koji/issue/2037
2020-04-22 13:39:09 +02:00
Tomas Kopecek
b8d4c66329 Don't use listTagged(tag, *) for untag-build
Fixes: https://pagure.io/koji/issue/2037
2020-04-22 13:39:09 +02:00
Tomas Kopecek
4b3c9f33b4 PR#2103: fix list-signed --tag memory issues
Merges #2103
https://pagure.io/koji/pull-request/2103

Fixes: #2102
https://pagure.io/koji/issue/2102
koji list-signed --tag  results in OOM
2020-04-22 13:35:22 +02:00
Tomas Kopecek
eb7c33a170 fix list-signed --tag memory issues
Fixes: https://pagure.io/koji/issue/2102
2020-04-22 11:05:02 +02:00
Tomas Kopecek
8f3885ce23 PR#2150: translate exceptions to GenericError
Merges #2150
https://pagure.io/koji/pull-request/2150

Fixes: #2067
https://pagure.io/koji/issue/2067
API filterResults returns Fault for API call with unexpected keyword
2020-04-22 10:37:23 +02:00
Tomas Kopecek
4d4e569909 translate exceptions to GenericError
Fixes: https://pagure.io/koji/issue/2067
2020-04-22 10:37:14 +02:00
Tomas Kopecek
613bbbd6a9 PR#2176: hub: document editUser method
Merges #2176
https://pagure.io/koji/pull-request/2176
2020-04-22 09:55:06 +02:00
Ken Dreyer
3c7d8c8407 hub: document editUser method
Describe the types of each argument to the edit_user() method. Give some
example values for krb_principal_mappings.
2020-04-22 09:54:58 +02:00
Tomas Kopecek
98d74fd809 PR#2175: kojira: remove duplicate Kerberos configuration boilerplate
Merges #2175
https://pagure.io/koji/pull-request/2175
2020-04-22 09:51:35 +02:00
Ken Dreyer
c932f4cdbc doc: use newer configuration boilerplate for kojira
The Server Howto documentation describes how to configure Kerberos
authentication in kojira.conf.

Prior to this change, the Server Howto documentation's boilerplate
configuration copied the older stale format.
eea730300a added a dedicated section for
Kerberos authentication to kojira.conf. Copy this newer format into the
Server Howto documentation.

This also updates our Server Howto document to use the default
/etc/kojira/kojira.keytab file path, which we added in
f232e49194.
2020-04-22 09:51:28 +02:00
Ken Dreyer
b13487d34f kojira: remove duplicate Kerberos configuration boilerplate
eea730300a added a dedicated section for
Kerberos authentication to kojira.conf. It refers to the canonical
location /etc/kojira/kojira.keytab.

Prior to this change, there were two "kerberos" sections in kojira.conf.
Remove the older stale one, since that refers to the old
"/etc/kojira.keytab" file path, and
f232e49194 defaults to
/etc/kojira/kojira.keytab instead.
2020-04-22 09:51:28 +02:00
Tomas Kopecek
7881ac0714 Merge #2173 hub: document getTagExternalRepos 2020-04-22 07:49:46 +00:00
Tomas Kopecek
5fe65191f9 PR#2177: doc: "koji build" requires a target
Merges #2177
https://pagure.io/koji/pull-request/2177
2020-04-22 09:45:06 +02:00
Ken Dreyer
fbcc6bb43e doc: "koji build" requires a target
The "koji build" command requires a target, not a tag.
2020-04-22 09:44:59 +02:00
Tomas Kopecek
1e30a6c299 PR#2178: docs: Fix sidetag enablement typo
Merges #2178
https://pagure.io/koji/pull-request/2178
2020-04-22 09:44:12 +02:00
Igor Raits
f5349cafa4 docs: Fix sidetag enablement typo
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
2020-04-22 09:43:57 +02:00
Tomas Kopecek
70f9f54bfe PR#2174: hub: document removeExternalRepoFromTag arguments
Merges #2174
https://pagure.io/koji/pull-request/2174
2020-04-22 09:42:40 +02:00
Ken Dreyer
4c505be0fa hub: document removeExternalRepoFromTag arguments
Describe the types of each argument to the removeExternalRepoFromTag()
method.
2020-04-22 09:42:32 +02:00