Tomas Kopecek
8b53dc74e3
PR#2615: cli: catch koji.ParameterError in list_task_output_all_volumes
...
Merges #2615
https://pagure.io/koji/pull-request/2615
Fixes #2686
https://pagure.io/koji/issue/2686
2021-03-25 14:00:04 +01:00
Ken Dreyer
8d0b4bc618
cli: catch koji.ParameterError in list_task_output_all_volumes
...
When we send an RPC with a parameter that the hub does not understand,
we get a koji.ParameterError.
Update list_task_output_all_volumes() to catch the specific error we
expect here.
The purpose of this change is to make the code easier to understand.
2021-03-25 13:59:59 +01:00
Tomas Kopecek
ed04738b58
PR#2749: web: optional KojiHubCA usage
...
Merges #2749
https://pagure.io/koji/pull-request/2749
Fixes : #2742
https://pagure.io/koji/issue/2742
web looking for hub CA even without SSL auth
2021-03-24 17:18:11 +01:00
Tomas Kopecek
700a7bbdd4
web: optional KojiHubCA usage
...
Fixes: https://pagure.io/koji/issue/2742
2021-03-24 17:18:05 +01:00
Tomas Kopecek
b5c8d41e6a
PR#2753: drop PyOpenSSL usage
...
Merges #2753
https://pagure.io/koji/pull-request/2753
Fixes : #2752
https://pagure.io/koji/issue/2752
revisit pyOpenSSL usage
2021-03-24 14:43:47 +01:00
Tomas Kopecek
ebdbb80e02
drop PyOpenSSL usage
...
We've replaced it with requests library some time ago, this code has no
better sensitivity than requests error checking, so we can drop it
completely.
Fixes: https://pagure.io/koji/issue/2752
2021-03-24 14:43:40 +01:00
Tomas Kopecek
2dc537199a
PR#2765: kojira: check repo.json before deleting
...
Merges #2765
https://pagure.io/koji/pull-request/2765
Fixes : #1321
https://pagure.io/koji/issue/1321
[kojira] If tag is renamed, old repos will never be deleted
2021-03-23 13:47:53 +01:00
Tomas Kopecek
1a76030707
kojira: check repo.json before deleting
...
Fixes: https://pagure.io/koji/issue/1321
2021-03-23 13:47:48 +01:00
Tomas Kopecek
267f5bbae0
PR#2777: docs: fix Fedora's koji URL
...
Merges #2777
https://pagure.io/koji/pull-request/2777
Fixes : #2776
https://pagure.io/koji/issue/2776
I canot visit url from doc?
2021-03-23 13:46:30 +01:00
Tomas Kopecek
5ad2715be7
docs: fix Fedora's koji URL
...
Fixes: https://pagure.io/koji/issue/2776
2021-03-23 13:17:49 +01:00
Tomas Kopecek
21ec2511f4
PR#2722: cli: use multicall for cancel command
...
Merges #2722
https://pagure.io/koji/pull-request/2722
Fixes : #2607
https://pagure.io/koji/issue/2607
cli: cancel-build should use multicall
2021-03-22 15:12:07 +01:00
Tomas Kopecek
7333a8e174
cli: use multicall for cancel command
...
Fixes: https://pagure.io/koji/issue/2607
2021-03-22 15:12:01 +01:00
Tomas Kopecek
e2f4aa794f
PR#2772: Fix small documentation typo
...
Merges #2772
https://pagure.io/koji/pull-request/2772
2021-03-18 16:27:16 +01:00
Alex Iribarren
14dcd554c3
Fix typo
2021-03-18 16:27:11 +01:00
Tomas Kopecek
66e6ee322b
make flake8 happy
2021-03-18 16:13:29 +01:00
Tomas Kopecek
131c5fa1bb
PR#2699: Fix race handling in rmtree
...
Merges #2699
https://pagure.io/koji/pull-request/2699
Fixes : #2698
https://pagure.io/koji/issue/2698
rmtree can fail with mysterious error in race
2021-03-18 15:46:22 +01:00
Mike McLean
362c3e5cc6
more rmtree unit tests
2021-03-18 15:46:16 +01:00
Mike McLean
144dc70010
fix logic
2021-03-18 15:46:16 +01:00
Mike McLean
08139a9e39
update unit tests
2021-03-18 15:46:16 +01:00
Mike McLean
9cceb6764d
rework rmtree a bit
2021-03-18 15:46:16 +01:00
Tomas Kopecek
788b2775ed
PR#2755: kojira: check rm queue before adding new path
...
Merges #2755
https://pagure.io/koji/pull-request/2755
Fixes : #2716
https://pagure.io/koji/issue/2716
kojira: duplicate deletes
2021-03-18 15:33:37 +01:00
Tomas Kopecek
e83dd2757e
kojira: check rm queue before adding new path
...
It is a remnant of previsou unification of rmtree paths. Instead of
deleting tree directly while deleting repo it is put into queue now. So,
other thread looking for expired/deleted repos can find it also and add
it twice. Internal rmtree can check the queue before adding duplicate
path. As a side-effect manager.rmtree can also never fail, so try/except
can be removed from there.
Fixes: https://pagure.io/koji/issue/2716
2021-03-18 15:33:31 +01:00
Tomas Kopecek
8a74740bb9
PR#2769: cli: hostinfo with non-exist host
...
Merges #2769
https://pagure.io/koji/pull-request/2769
Fixes : #2763
https://pagure.io/koji/issue/2763
CLI hostinfo returns code 0 for non existing host
2021-03-18 10:50:42 +01:00
Jana Cupova
de09faca6c
cli: hostinfo with non-exist host
...
Fixes: https://pagure.io/koji/issue/2763
2021-03-18 10:50:36 +01:00
Tomas Kopecek
9df4b1fb33
PR#2768: tests: fix locale setting
...
Merges #2768
https://pagure.io/koji/pull-request/2768
Fixes : #2767
https://pagure.io/koji/issue/2767
fix locale setting in test
2021-03-18 10:16:03 +01:00
Tomas Kopecek
8ed86e86ee
tests: fix locale setting
...
Fixes: https://pagure.io/koji/issue/2767
2021-03-18 10:11:51 +01:00
Tomas Kopecek
33efc94893
PR#2721: API: createWinBuild with wrong win/build info
...
Merges #2721
https://pagure.io/koji/pull-request/2721
Fixes : #1102
https://pagure.io/koji/issue/1102
createWinBuild API call should raise GenericError exception for non existing build name
Fixes : #1103
https://pagure.io/koji/issue/1103
createWinBuild API call should raise GenericError exception for empty win build info
2021-03-17 10:12:51 +01:00
Jana Cupova
9c6483f197
API: createWinBuild with wrong win/build info
...
createWinBuild returns an error when win info is empty, is not a dict or
doesn't contain platform key
createWinBuild returns an error when build info is string and build is
not existing
Fixes: https://pagure.io/koji/issue/1103
Fixes: https://pagure.io/koji/issue/1102
2021-03-17 10:12:45 +01:00
Tomas Kopecek
ea5f4621e5
PR#2761: cli: rpminfo with non-exist rpm
...
Merges #2761
https://pagure.io/koji/pull-request/2761
Fixes : #2643
https://pagure.io/koji/issue/2643
CLI rpminfo does not raise exception for non-existing nvra
2021-03-17 10:11:09 +01:00
Jana Cupova
0c9c8c6a81
cli: rpminfo with non-exist rpm
...
Fixes: https://pagure.io/koji/issue/2643
2021-03-17 10:11:03 +01:00
Tomas Kopecek
f6ca9aa50b
PR#2736: api: createMavenBuild wrong buildinfo/maveninfo
...
Merges #2736
https://pagure.io/koji/pull-request/2736
Fixes : #1105
https://pagure.io/koji/issue/1105
createMavenBuild API call should raise GenericError exception for maven info without all obligatory keys
Fixes : #1104
https://pagure.io/koji/issue/1104
createMavenBuild API call should raise GenericError exception for non existing build name
2021-03-16 15:25:23 +01:00
Jana Cupova
36284cdea9
api: createMavenBuild wrong buildinfo/maveninfo
...
Fixes: https://pagure.io/koji/issue/1104
Fixes: https://pagure.io/koji/issue/1105
2021-03-16 15:25:15 +01:00
Tomas Kopecek
8186460f9a
PR#2732: api: createImageBuild non-existing build wrong buildinfo
...
Merges #2732
https://pagure.io/koji/pull-request/2732
Fixes : #1106
https://pagure.io/koji/issue/1106
createImageBuild API call should raise GenericError exception for non existing build name
2021-03-16 13:09:04 +01:00
Jana Cupova
8a24a70159
api: createImageBuild non-existing build wrong buildinfo
...
createImageBuild returns an error when build is not existing and buildinfo
is not a dict
Fixes: https://pagure.io/koji/issue/1106
2021-03-16 13:08:57 +01:00
Tomas Kopecek
f45f8d8fca
PR#2733: Unify error messages
...
Merges #2733
https://pagure.io/koji/pull-request/2733
Fixes : #2720
https://pagure.io/koji/issue/2720
Unify error messages
2021-03-16 08:43:39 +01:00
Jana Cupova
e784373000
Unify error messages
...
Unify error messages for CLI
Unify error messages for hub
Fixes: https://pagure.io/koji/issue/2720
2021-03-16 08:43:33 +01:00
Tomas Kopecek
bbe5b4c703
PR#2759: tests: stop mock in DBQueryTest
...
Merges #2759
https://pagure.io/koji/pull-request/2759
Fixes : #2758
https://pagure.io/koji/issue/2758
DBQueryTest doesn't clean mock env
2021-03-15 13:34:51 +01:00
Tomas Kopecek
66a1ef2ab7
tests: stop mocks in DBQueryTest setUp
...
Fixes: https://pagure.io/koji/issue/2758
2021-03-15 11:01:08 +01:00
Tomas Kopecek
8c9a34737b
PR#2754: doc: jenkins fedora -> centos migration
...
Merges #2754
https://pagure.io/koji/pull-request/2754
Fixes : #2745
https://pagure.io/koji/issue/2745
update jenkins docs
2021-03-11 15:47:41 +01:00
Tomas Kopecek
6c14470922
doc: jenkins fedora -> centos migration
...
Fixes: https://pagure.io/koji/issue/2745
2021-03-11 15:47:35 +01:00
Tomas Kopecek
e9307aa4fe
PR#2744: devtools: updated Dockerfiles
...
Merges #2744
https://pagure.io/koji/pull-request/2744
Fixes : #2743
https://pagure.io/koji/issue/2743
update dockerfiles for testing
2021-03-11 15:20:37 +01:00
Tomas Kopecek
777ce2286f
PR#2715: acquire logging locks before forking
...
Merges #2715
https://pagure.io/koji/pull-request/2715
Fixes : #2714
https://pagure.io/koji/issue/2714
kojira rmtree jobs can stall due to locking race
2021-03-11 13:31:42 +01:00
Mike McLean
3c9dc70832
acquire logging locks before forking
...
Fixes https://pagure.io/koji/issue/2714
2021-03-11 13:31:35 +01:00
Tomas Kopecek
a81d0659b3
devtools: updated Dockerfiles
...
Fixes: https://pagure.io/koji/issue/2743
2021-03-11 11:27:57 +01:00
Tomas Kopecek
566c70701e
PR#2747: Escape vcs and disturl
...
Merges #2747
https://pagure.io/koji/pull-request/2747
Fixes : #2746
https://pagure.io/koji/issue/2746
VCS and DistURL not escaped
2021-03-10 16:29:27 +01:00
Alex Iribarren
519d8c4fa6
Escape vcs and disturl
2021-03-10 16:29:21 +01:00
Tomas Kopecek
5a5bdc7c85
PR#2705: cli: show connection exception
...
Merges #2705
https://pagure.io/koji/pull-request/2705
Fixes : #2592
https://pagure.io/koji/issue/2592
RFE: improve HTTPS error messages for CLI
2021-03-10 15:31:20 +01:00
Tomas Kopecek
29a34f31a5
cli: show connection exception
...
For anonymous calls (whose use ensure_connection) is now shown also
original exception if --debug is specified.
Fixes: https://pagure.io/koji/issue/2592
2021-03-10 15:31:11 +01:00
Tomas Kopecek
cf1c2dad0b
PR#2703: cli: list-untagged returns error non-exist package
...
Merges #2703
https://pagure.io/koji/pull-request/2703
Fixes : #2601
https://pagure.io/koji/issue/2601
CLI list-untagged with non existing pkg should returns an error
2021-03-10 14:38:47 +01:00
Jana Cupova
ffc9bedd00
cli: list-untagged returns error non-exist package
...
When package is not existing, list-untagged returns an error.
Fixes: https://pagure.io/koji/issue/2601
2021-03-10 14:38:39 +01:00