Mike McLean
8f6d5d41cd
clean up tests
2017-11-09 17:40:52 -05:00
Mike McLean
44a17e5dfe
fix unit test
2017-11-09 17:40:52 -05:00
Mike McLean
40bf35c0f1
move tests to correct subdirs
2017-11-09 17:40:52 -05:00
Mike McLean
af71756fa7
fix exception syntax in apply_argspec
2017-11-09 17:40:52 -05:00
Mike McLean
75d192a149
update legacy signatures
2017-11-09 17:40:52 -05:00
Mike McLean
d8132543c5
move apply_argspec to koji.util
2017-11-09 17:40:52 -05:00
Mike McLean
89825a8d2d
drop unused/incomplete parseParams method for now
2017-11-09 17:40:52 -05:00
Mike McLean
bf9e7520f7
fix defaults handling in apply_argspec
2017-11-09 17:40:52 -05:00
Mike McLean
9e48e440e8
cleanup, more testing
2017-11-09 17:40:52 -05:00
Mike McLean
1bdf7a0f09
basic unit test
2017-11-09 17:40:52 -05:00
Mike McLean
e6de3e0d62
function to parse task parameters into a dictionary
2017-11-09 17:40:52 -05:00
Mike McLean
4f97237a84
more tests
2017-11-09 17:40:52 -05:00
Mike McLean
8a8999e01c
partial work on apply_argspec function
2017-11-09 17:40:52 -05:00
Mike McLean
0faa6e3290
PR#681: use six.StringIO everywhere
...
Merges #681
https://pagure.io/koji/pull-request/681
2017-11-09 17:27:26 -05:00
Tomas Kopecek
e040745181
use six.StringIO everywhere
2017-11-09 17:27:23 -05:00
Mike McLean
ce1bf266f3
PR#684: correct format and fix issue #682
...
Merges #684
https://pagure.io/koji/pull-request/684
Fixes : #682
https://pagure.io/koji/issue/682
Error format in anon_handle_mock_config error message.
2017-11-09 14:51:08 -05:00
Franz Chih-Ping Hsieh
699ba58e44
Fixes : #682
...
https://pagure.io/koji/issue/682
correct wrong mapping in print format
2017-11-08 08:06:13 -05:00
Mike McLean
7acaf4ce77
PR#646: Improve test coverage in koji/util
...
Merges #646
https://pagure.io/koji/pull-request/646
Fixes : #642
https://pagure.io/koji/issue/642
Goal: 90% coverage for koji.util
2017-11-07 09:58:27 -05:00
Franz Chih-Ping Hsieh
efe68e54df
- add unit test for koji/util: (coverage 58%->100%)
...
- minor fix: check if input string time is valid
2017-11-07 09:58:21 -05:00
Mike McLean
c496bf994c
PR#677: handle DateTime objects in encode_datetime
...
Merges #677
https://pagure.io/koji/pull-request/677
Fixes : #676
https://pagure.io/koji/issue/676
messaging plugins fail on DateTime objects
2017-11-03 10:18:08 -04:00
Mike McLean
6bb32b699e
handle DateTime objects in encode_datetime
2017-11-02 15:59:18 -04:00
Mike McLean
cdee4d2710
PR#670: Create repo without --deltas if no old package dir is set
...
Merges #670
https://pagure.io/koji/pull-request/670
2017-11-01 16:30:02 -04:00
Lubomír Sedlář
bcac8d49b6
Create repo without --deltas if no old package dir is set
...
Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-11-01 13:18:13 +01:00
Mike McLean
21dd22ba11
PR#666: Few cheap python3 compatibilities
...
Merges #666
https://pagure.io/koji/pull-request/666
2017-10-31 12:36:48 -04:00
Tomas Kopecek
09651a9a8f
Explicit tuple in list constructor
2017-10-31 16:18:04 +01:00
Tomas Kopecek
1f6ca9ae72
python-modernize -f lib2to3.fixes.fix_numliterals . -w
2017-10-31 16:07:34 +01:00
Tomas Kopecek
379ec8ae63
python-modernize -f lib2to3.fixes.file . -w
2017-10-31 16:05:16 +01:00
Tomas Kopecek
d6a5cdf987
python-modernize -f lib2to3.fixes.fix_except . -w
2017-10-31 16:05:16 +01:00
Mike McLean
2e0b962274
PR#662: mock koji.commands._running_in_bg function to run unittest in background
...
Merges #662
https://pagure.io/koji/pull-request/662
Fixes : #640
https://pagure.io/koji/issue/640
Goal: 30% coverage for cli commands
2017-10-30 22:08:24 -04:00
Franz Chih-Ping Hsieh
2096c6fce8
mock koji.commands._running_in_bg funtion to run unittest in background
2017-10-30 22:08:20 -04:00
Mike McLean
c3a0b4673e
PR#645: don't fail on CLI plugins without docstrings
...
Merges #645
https://pagure.io/koji/pull-request/645
Fixes : #644
https://pagure.io/koji/issue/644
CLI fails on plugins without docstrings
2017-10-30 21:36:22 -04:00
Tomas Kopecek
64202285b2
don't fail on CLI plugins without docstrings
...
Related: https://pagure.io/koji/issue/644
2017-10-30 21:36:18 -04:00
Mike McLean
208a98e8e7
PR#655: fix unreachable code
...
Merges #655
https://pagure.io/koji/pull-request/655
2017-10-30 16:54:03 -04:00
Tomas Kopecek
fc81129563
fix unreachable code
2017-10-30 16:53:59 -04:00
Mike McLean
ff57765c86
PR#656: remove unused calls
...
Merges #656
https://pagure.io/koji/pull-request/656
2017-10-30 16:49:03 -04:00
Tomas Kopecek
a12925fb72
remove unused calls
2017-10-30 16:48:59 -04:00
Mike McLean
3c84b33b3a
PR#652: add unittests for koji commands
...
Merges #652
https://pagure.io/koji/pull-request/652
Related: #640
https://pagure.io/koji/issue/640
Goal: 30% coverage for cli commands
2017-10-30 16:13:44 -04:00
Franz Chih-Ping Hsieh
85f489ee98
rename testcase class name
2017-10-30 16:13:40 -04:00
Franz Chih-Ping Hsieh
cb0d9ba37d
add unittests for koji command line:
...
- call
- hello / moshimoshi
- maven-chain
- resubmit
2017-10-30 16:13:40 -04:00
Franz Chih-Ping Hsieh
17f006511d
add unittests for koji commands
...
- assign-task
- wrapper-rpm
2017-10-30 16:13:40 -04:00
Mike McLean
423eac9e7f
PR#658: consolidate safe_rmtree, rmtree and shutil.rmtree
...
Merges #658
https://pagure.io/koji/pull-request/658
Fixes : #648
https://pagure.io/koji/issue/648
Consolidate rmtree usage
2017-10-30 12:09:08 -04:00
Mike McLean
b2f2ea83ed
also use rmtree in delete_build/reset_build
2017-10-30 12:09:04 -04:00
Tomas Kopecek
f4e3f7bccf
safe_rmtree: more constraints on tests
2017-10-30 12:09:04 -04:00
Tomas Kopecek
b5b6c50e79
safe_rmtree: fix tests for backward-compatibility
2017-10-30 12:09:04 -04:00
Mike McLean
b848458251
safe_rmtree: make return value consistent with past behavior
2017-10-30 12:09:04 -04:00
Mike McLean
a2d9d756fe
drop stale comment and avoid bare except in safe_rmtree
2017-10-30 12:09:04 -04:00
Mike McLean
4c1396b955
update rmtree patch in unit test for recycle_build
2017-10-30 12:09:04 -04:00
Tomas Kopecek
5b23fb1629
consolidate safe_rmtree, rmtree and shutil.rmtree
...
shutil.rmtree should be avoided in almost all cases
safe_rmtree has its usage in tasks module, but innards are replaced with
koji.util.rmtree, so we don't have two implementations of same task
Related: https://pagure.io/koji/issue/648
2017-10-30 12:09:04 -04:00
Mike McLean
70988911ea
PR#660: more runroot tests
...
Merges #660
https://pagure.io/koji/pull-request/660
Fixes : #641
https://pagure.io/koji/issue/641
Goal: 95% coverage for plugins
2017-10-30 10:47:05 -04:00
Tomas Kopecek
f639b99a71
more runroot tests
...
Related: https://pagure.io/koji/issue/641
2017-10-30 13:20:37 +01:00
