Commit graph

6279 commits

Author SHA1 Message Date
Jana Cupova
929e0ab998 Fix type in kojid distRepo
Fixes: https://pagure.io/koji/issue/2806
2021-11-04 12:18:31 +00:00
Yu Ming Zhu
70a0c6f8bb PR#3095: Add strict option to listTagged, listTaggedRPMS, listTaggedArchives
Merges #3095
https://pagure.io/koji/pull-request/3095

Fixes: #1477
https://pagure.io/koji/issue/1477
Unexpected type returned from listTagged()
2021-11-04 12:16:54 +00:00
Jana Cupova
ea695543f2 Add strict option to listTagged, listTaggedRPMS, listTaggedArchives
Fixes: https://pagure.io/koji/issue/1477
2021-11-04 12:16:43 +00:00
Yu Ming Zhu
c116fe2a67 PR#3089: Deprecated force option in groupReqListRemove call
Merges #3089
https://pagure.io/koji/pull-request/3089

Fixes: #1164
https://pagure.io/koji/issue/1164
groupReqListRemove API call has force argument but it is not used for functionality
2021-11-04 12:15:26 +00:00
Jana Cupova
1a1f71bdbb Deprecated force option in groupReqListRemove call
Fixes: https://pagure.io/koji/issue/1164
2021-11-04 12:15:23 +00:00
Yu Ming Zhu
83bff4dcc3 PR#3078: Add specfile log to wrapperRPM
Merges #3078
https://pagure.io/koji/pull-request/3078

Fixes: #2862
https://pagure.io/koji/issue/2862
wrapperRPM should log generated spec file
2021-11-04 12:13:48 +00:00
Jana Cupova
cc7ec85c32 Add specfile log to wrapperRPM
Fixes: https://pagure.io/koji/issue/2862
2021-11-04 12:13:44 +00:00
Yu Ming Zhu
b2bd367b68 PR#3076: Logging warning messages about deletedBuild or deletedRPMSig
Merges #3076
https://pagure.io/koji/pull-request/3076

Fixes: #3018
https://pagure.io/koji/issue/3018
deleteRPMSign should be more verbose and optional
2021-11-04 12:09:06 +00:00
Jana Cupova
246bad05d6 Logging warning messages about deletedBuild or deletedRPMSig
Fixes: https://pagure.io/koji/issue/3018
2021-11-04 12:08:58 +00:00
Yu Ming Zhu
f5ba2a5c08 PR#3008: Allow kojiweb to proxy users obtained via different mechanisms
Merges #3008
https://pagure.io/koji/pull-request/3008

Fixes: #2552
https://pagure.io/koji/issue/2552
Allow kojiweb to proxy users obtained via different mechanisms
2021-11-04 12:07:12 +00:00
Tomas Kopecek
a6aeaee3e3 fix callMethod 2021-11-04 12:07:05 +00:00
Tomas Kopecek
09a8fd71e5 backward compatibility for older hub
use proxyauthtype only if it is explicetly requested. Older hubs
don't know this option and will refuse login attempt.
2021-11-04 12:07:05 +00:00
Tomas Kopecek
038a2f1850 rename ProxyAuthType -> AllowProxyAuthType 2021-11-04 12:07:05 +00:00
Tomas Kopecek
252121c11f propagate proxyauthtype in login calls 2021-11-04 12:07:05 +00:00
Tomas Kopecek
ac8e83e3ac conditional evaluation of proxyauthtype 2021-11-04 12:07:05 +00:00
Tomas Kopecek
24e5c0cb45 further fixes (will be squashed before merge) 2021-11-04 12:07:05 +00:00
Tomas Kopecek
b6ccafafeb proxyauthtype for web users 2021-11-04 12:07:05 +00:00
Tim Smith
330e4d5a1f Reverse check order between WebCert and WebPrincipal in case both are set
In the case that both WebPrincipal and WebCert are set, reverse the
order of checking them so that WebCert is used by default.
2021-11-04 12:07:05 +00:00
Tim Smith
6e58377a89 Allow kojiweb to proxy users obtained via different mechanisms
This allows for users authenticated to the Koji Web interface via
Kerberos to be proxied to the HUB using an SSL certificate and
(in theory) vice versa though it's not clear why you'd want that.

This is useful in environments where the owners of the Kerberos
realm are not willing to create service accounts and export
keytabs for them.

Set WebAuth = kerberos to indicate that users are authenticated
to the web via Kerberos. The existing config controls how kojiweb
authenticates to the HUB.

If using this, it is recommended to set

LoginCreatesUser = Off

in hub.conf, to avoid accidental creation of Koji accounts for
users of the wider Kerberos realm.
2021-11-04 12:07:05 +00:00
Tomas Kopecek
d43b9494c5 proxy login method 2021-11-04 12:07:05 +00:00
Yu Ming Zhu
82e5fbde5e PR#3092: [hub] getBuildType: ensure id exists in buildinfo dict
Merges #3092
https://pagure.io/koji/pull-request/3092

Fixes: #3091
https://pagure.io/koji/issue/3091
Cannot get build type for builds in listBuilds
2021-11-04 11:55:50 +00:00
Yuming Zhu
d367420c75 [hub] getBuildType: ensure id exists in buildinfo dict
if there is no id, call `get_build` to fetch the build data (n-v-r inside will be used or the data is invalid)

fixes: #3091
2021-11-04 11:55:45 +00:00
Tomas Kopecek
1eaeb45e94 PR#3038: docs: koji-gc options
Merges #3038
https://pagure.io/koji/pull-request/3038

Fixes: #2812
https://pagure.io/koji/issue/2812
koji-gc: Missing documentation for standard options (e.g. keytab)
2021-10-26 11:23:39 +02:00
Tomas Kopecek
d5663617a3 docs: koji-gc options
Fixes: https://pagure.io/koji/issue/2812
2021-10-26 11:23:31 +02:00
Tomas Kopecek
6853bc9d2b PR#3051: cli: mention --profile in --config help text
Merges #3051
https://pagure.io/koji/pull-request/3051
2021-10-26 11:22:31 +02:00
Ken Dreyer
071533206e cli: mention --profile in --config help text
It's easy for new users to confuse the "--config" and "--profile"
settings.

We want to guide users towards using non-default profile names (eg
"stream" or "cbs", etc) where possible. If a user is pointing at a
non-standard configuration file location, they should really use the
--profile option also to keep their configuration sane.

Update the --help text for the --config option to emphasize the
--profile option.
2021-10-26 11:21:58 +02:00
Tomas Kopecek
a4f16fe1f0 PR#3067: Allow user on git://, git+http://, git+https://, and git+rsync:// scheme
Merges #3067
https://pagure.io/koji/pull-request/3067

Fixes: #2868
https://pagure.io/koji/issue/2868
[1.24.1] git user name are not forward to the builder
2021-10-26 11:14:47 +02:00
Jana Cupova
6426ddced1 Allow user on git://, git+http://, git+https://, and git+rsync:// scheme
Fixes: https://pagure.io/koji/issue/2868
2021-10-26 11:14:40 +02:00
Tomas Kopecek
f5552da017 PR#3096: hub: document packageListRemove method
Merges #3096
https://pagure.io/koji/pull-request/3096
2021-10-26 10:13:32 +02:00
Ken Dreyer
8d9633cff7 hub: document packageListRemove method
Update the packageListRemove RPC docstring to describe all parameters
and the return value.

Remove the statement about prefering the block and unblock functions.
In many cases it's simpler and faster to put fewer packages into a tag
than to block many extraneous packages in a tag.
2021-10-25 13:13:35 -04:00
Tomas Kopecek
068ccedd0b PR#3077: Remove translation stub functions
Merges #3077
https://pagure.io/koji/pull-request/3077

Fixes: #3072
https://pagure.io/koji/issue/3072
Clean translation stubs
2021-10-21 15:31:20 +02:00
Jana Cupova
32b5377392 Remove translation stub functions
Fixes: https://pagure.io/koji/issue/3072
2021-10-21 13:25:16 +02:00
Tomas Kopecek
9e542f509a PR#3086: hub: document listPackages method
Merges #3086
https://pagure.io/koji/pull-request/3086
2021-10-21 12:59:25 +02:00
Ken Dreyer
9ad3637cae hub: document listPackages method
Update the listPackages RPC docstring to describe all parameters and the
return value.
2021-10-21 12:59:20 +02:00
Tomas Kopecek
1925b0c7b8 fix tests 2021-10-21 12:58:29 +02:00
Tomas Kopecek
f09771d471 PR#3093: Fix log_output default value
Merges #3093
https://pagure.io/koji/pull-request/3093

Fixes: #2806
https://pagure.io/koji/issue/2806
dist-repo can run write-signed-rpms first
2021-10-21 12:56:14 +02:00
Jana Cupova
75b8e37569 Fix log_output default value
Fixes: https://pagure.io/koji/issue/2806
2021-10-21 12:17:41 +02:00
Tomas Kopecek
03dafc423a PR#3085: cli: improve help text for add-tag --parent
Merges #3085
https://pagure.io/koji/pull-request/3085
2021-10-20 17:20:18 +02:00
Ken Dreyer
cfaa6aa7fc cli: improve help text for add-tag --parent
Update the --help text to clarify that the --parent option will add a
parent tag at the highest priority (0).
2021-10-20 11:15:40 -04:00
Tomas Kopecek
9400ed2aa7 PR#3040: Restart kojid and kojira services automatically
Merges #3040
https://pagure.io/koji/pull-request/3040

Fixes #3084
https://pagure.io/koji/issue/3084
2021-10-20 16:14:27 +02:00
Vasil Velichkov
c21f102114 Restart kojid and kojira services automatically
Wait 60sec before restarting the service
2021-10-20 16:14:20 +02:00
Tomas Kopecek
a90552afdb PR#3043: basic security checks with bandit
Merges #3043
https://pagure.io/koji/pull-request/3043

Fixes: #3042
https://pagure.io/koji/issue/3042
Basic bandit checking
2021-10-20 15:20:22 +02:00
Tomas Kopecek
8cc777c094 fix test 2021-10-20 15:20:14 +02:00
Tomas Kopecek
a3ea37b173 remove unused imports 2021-10-20 15:20:14 +02:00
Tomas Kopecek
3ec6e87d5b replace urlopen with requests.get 2021-10-20 15:20:14 +02:00
Tomas Kopecek
ba2e1e520b basic security checks with bandit
Fixes: https://pagure.io/koji/issue/3042
2021-10-20 15:20:14 +02:00
Tomas Kopecek
0e2ebb4e25 Revert "PR#2944: decode protonmsg props field when loading from db"
This reverts commit 34d1c8eb9e, reversing
changes made to fdccd38148.

Proper solution was part of https://pagure.io/koji/pull-request/2955, so
this merge was a mistake. Reverting.
2021-10-20 13:00:04 +02:00
Tomas Kopecek
34d1c8eb9e PR#2944: decode protonmsg props field when loading from db
Merges #2944
https://pagure.io/koji/pull-request/2944
2021-10-19 13:11:27 +02:00
Mike McLean
b4b83c8251 decode protonmsg props field when loading from db 2021-10-19 13:11:20 +02:00
Tomas Kopecek
fdccd38148 PR#3066: method call json default option set up to str
Merges #3066
https://pagure.io/koji/pull-request/3066

Fixes: #3065
https://pagure.io/koji/issue/3065
`brew call --json ` breaks with DateTime values
2021-10-19 12:41:04 +02:00