Commit graph

6406 commits

Author SHA1 Message Date
Ken Dreyer
95dfece2a0 doc: explain IMA signing vs usual RPM signing 2022-01-07 12:46:14 +01:00
Tomas Kopecek
cc08fe1926 PR#3196: hub: default with_blocked=True in listPackages
Merges #3196
https://pagure.io/koji/pull-request/3196

Fixes: #3193
https://pagure.io/koji/issue/3193
listPackages should return blocked packages by default
2022-01-07 12:37:08 +01:00
Ken Dreyer
241840bbda hub: default with_blocked=True in listPackages
Commit 355c713044 introduced a regression
in the listPackages RPC, where it no longer returns blocked packages by
default.

To restore backwards compatibility, set the with_blocked argument to
True by default.
2022-01-07 12:37:02 +01:00
Tomas Kopecek
5db5fd8b03 fix bandit env 2022-01-03 10:31:54 +01:00
Tomas Kopecek
4d9f9f2482 PR#3195: Link to overview video
Merges #3195
https://pagure.io/koji/pull-request/3195
2022-01-03 09:03:23 +01:00
Tomas Kopecek
1fbc08988d Link to overview video 2021-12-23 11:32:52 +01:00
Tomas Kopecek
a131f83891 PR#3123: Centralize name/id lookup clauses
Merges #3123
https://pagure.io/koji/pull-request/3123

Fixes: #3122
https://pagure.io/koji/issue/3122
hub: the tagInfo option of get_tag should be tolerant with a sensible dict
2021-12-21 14:46:22 +01:00
Mike McLean
7615b8aa85 actually execute the insert 2021-12-21 14:46:15 +01:00
Mike McLean
dee3405eb7 add explicit error case 2021-12-21 14:46:15 +01:00
Mike McLean
2bc2cce3c8 fix table name 2021-12-21 14:46:15 +01:00
Mike McLean
529eada38d require table arg in name_or_id_clause() to simplify code 2021-12-21 14:46:15 +01:00
Mike McLean
784a561505 another unit test 2021-12-21 14:46:15 +01:00
Mike McLean
8299bc78b5 unit tests for lookup_name 2021-12-21 14:46:15 +01:00
Mike McLean
5770b7e360 expand get_channel unit tests 2021-12-21 14:46:15 +01:00
Mike McLean
920f9b01be use name_or_id_clause in get_channel 2021-12-21 14:46:15 +01:00
Mike McLean
bcf423362b use name_or_id_clause in get_external_repos 2021-12-21 14:46:15 +01:00
Mike McLean
c87eba6bcd use name_or_id_clause in get_build_targets 2021-12-21 14:46:15 +01:00
Mike McLean
f87d1c3479 use name_or_id_clause in get_host 2021-12-21 14:46:15 +01:00
Mike McLean
5ee9c7396a use name_or_id_clause in get_tag 2021-12-21 14:46:15 +01:00
Mike McLean
e5fff34d0f fix unit tests 2021-12-21 14:46:15 +01:00
Mike McLean
98d3abd01a add name_or_id_clause function 2021-12-21 14:46:15 +01:00
Tomas Kopecek
b69f4b36e0 PR#3186: Don't fail on missing buildroot tag
Merges #3186
https://pagure.io/koji/pull-request/3186

Fixes: #3185
https://pagure.io/koji/issue/3185
buildtag policy test fails for some CGs
2021-12-21 12:32:04 +01:00
Tomas Kopecek
dd1843207b Don't fail on missing buildroot tag
Fixes: https://pagure.io/koji/issue/3185
2021-12-21 12:32:01 +01:00
Tomas Kopecek
55a6e06d79 PR#3189: buildtag_inherits_from docs
Merges #3189
https://pagure.io/koji/pull-request/3189

Fixes: #3187
https://pagure.io/koji/issue/3187
document buildtag_inherits_from policy test
2021-12-21 12:31:11 +01:00
Tomas Kopecek
b1791e1166 buildtag_inherits_from docs 2021-12-21 12:29:56 +01:00
Tomas Kopecek
f85f8951e0 PR#3104: Make setup.py executable
Merges #3104
https://pagure.io/koji/pull-request/3104
2021-12-20 09:10:46 +01:00
Otto Urpelainen
761d9c139a Make setup.py executable
In order use setup.py locally, it needs to be executable.
Also, it is easier to call with a hashbang.
2021-12-20 09:10:40 +01:00
Tomas Kopecek
caf5fdd541 PR#3159: Taginfo page shows packages with/without blocked
Merges #3159
https://pagure.io/koji/pull-request/3159

Fixes: #1350
https://pagure.io/koji/issue/1350
taginfo (koji-web) Packages count incl. blocked packages
2021-12-20 09:08:54 +01:00
Jana Cupova
355c713044 Taginfo page shows packages with/without blocked
Fixes: https://pagure.io/koji/issue/1350
2021-12-20 09:08:47 +01:00
Tomas Kopecek
fd516dffd8 PR#3168: protonmsg: allow users to specify router-specific topic prefixes
Merges #3168
https://pagure.io/koji/pull-request/3168

Fixes #3169
https://pagure.io/koji/issue/3169
2021-12-20 08:44:32 +01:00
Ken Dreyer
dbacf1f985 protonmsg: allow users to specify router-specific topic prefixes
Prior to this change, Koji would always send messages with a hard-coded
topic:// prefix.

This works fine for ActiveMQ 5 and Artemis, but RabbitMQ does not
support that syntax. Instead, RabbitMQ brokers expect clients to use
topic addresses with a "/topic/" prefix.

The RFE for RabbitMQ to support "topic://" prefixes is
https://github.com/rabbitmq/rabbitmq-server/issues/2583

In the meantime, allow users to specify "topic://" or "/topic/"
explicitly in their configuration.

For backwards-compatibility, if the user chose neither "topic://" nor
"/topic/", prepend the "topic://" string, preserving the plugin's
existing behavior.

(Note: ActiveMQ 5 advertises its expected topic:// prefix in the initial
connection properties, so we could read that value dynamically, but
RabbitMQ and Artemis do not send an expected topic prefix connection
properties, so we just make the user choose explicitly here.)
2021-12-20 08:44:27 +01:00
Tomas Kopecek
dc47bcc8cc PR#3108: Remove rename-channel CLI and use editChannel in renameChannel
Merges #3108
https://pagure.io/koji/pull-request/3108

Fixes: #3035
https://pagure.io/koji/issue/3035
Remove deprecated rename_channel
2021-12-15 15:28:26 +01:00
Jana Cupova
18b136d386 Remove rename-channel CLI and use editChannel in renameChannel
Fixes: https://pagure.io/koji/issue/3035
2021-12-15 15:28:19 +01:00
Tomas Kopecek
109feb5629 PR#3158: Deprecated remove-channel CLI and removeChannel API
Merges #3158
https://pagure.io/koji/pull-request/3158

Fixes: #1206
https://pagure.io/koji/issue/1206
removeChannel behavior affected by host history feature
2021-12-15 15:26:23 +01:00
Jana Cupova
c7fd26aeda Deprecated remove-channel CLI and removeChannel API
Fixes: https://pagure.io/koji/issue/1206
2021-12-15 15:26:11 +01:00
Tomas Kopecek
a227cce7a5 PR#3166: kojira: don't fail on deleted items
Merges #3166
https://pagure.io/koji/pull-request/3166
2021-12-15 15:24:03 +01:00
Tomas Kopecek
6b64222ab7 kojira: don't fail on deleted items
py2 relict - dict.values() is now iterator, so
RuntimeError: dictionary changed size during iteration
can be raised when needed repo was deleted during the iteration.

Simple fix to use copy instead of iterator will fix this.
2021-12-15 15:23:56 +01:00
Tomas Kopecek
c85b1efbb7 PR#3113: error function instead of print with sys.exit in CLI commands
Merges #3113
https://pagure.io/koji/pull-request/3113

Fixes: #3112
https://pagure.io/koji/issue/3112
Use error function instead of print with sys.exit in cli commands
2021-12-15 15:19:24 +01:00
Jana Cupova
5232ea5aa1 error function instead of print with sys.exit in CLI commands
Fixes: https://pagure.io/koji/issue/3112
2021-12-15 15:19:18 +01:00
Tomas Kopecek
6fd7845be3 PR#3180: Add unit test for get_options
Merges #3180
https://pagure.io/koji/pull-request/3180

Fixes: #3181
https://pagure.io/koji/issue/3181
Coverage get_options (cli/koji) options
2021-12-15 15:12:18 +01:00
Jana Cupova
8d7b9508f1 Add unit test for get_options
Fixes: https://pagure.io/koji/issue/3181
2021-12-15 15:12:12 +01:00
Tomas Kopecek
e23e7d6cac PR#3164: [hub] only raise error when authtype is not proxyauthtype
Merges #3164
https://pagure.io/koji/pull-request/3164

Fixes: #3163
https://pagure.io/koji/issue/3163
AllowProxyAuthType needs to be on even for same auth mechanisms
2021-12-15 15:04:25 +01:00
Yuming Zhu
969f102598 [hub] only raise error when authtype is not proxyauthtype
fixes: #3163
2021-12-15 15:04:20 +01:00
Tomas Kopecek
850bea59fc PR#3098: Add all options to hub_conf.rst
Merges #3098
https://pagure.io/koji/pull-request/3098

Fixes: #3073
https://pagure.io/koji/issue/3073
Documentation page for hub config options
2021-12-15 14:09:23 +01:00
Jana Cupova
89d14f2093 Add all options to hub_conf.rst
Fixes: https://pagure.io/koji/issue/3073
2021-12-15 14:09:15 +01:00
Tomas Kopecek
892f891cbd PR#3172: Return mistakenly dropped option (--keytab)
Merges #3172
https://pagure.io/koji/pull-request/3172

Fixes: #3171
https://pagure.io/koji/issue/3171
Return dropped option --keytab
2021-12-14 14:16:13 +01:00
Tomas Kopecek
a3edb7a4b9 Return mistakenly dropped option (--keytab)
PR https://pagure.io/koji/pull-request/3051 was wrongly merged
https://pagure.io/koji/c/071533206e6d29f665d7a5864eda75087488a3ce?branch=master
and deleted wrong line. Reverting it.

Fixes: https://pagure.io/koji/issue/3171
2021-12-14 14:16:05 +01:00
Tomas Kopecek
e149e6b24d PR#3116: RLIMIT_OFILE alias for RLIMIT_NOFILE
Merges #3116
https://pagure.io/koji/pull-request/3116

Fixes: #3101
https://pagure.io/koji/issue/3101
RLIMIT_OFILE option is old
2021-12-13 17:25:51 +01:00
Jana Cupova
d80f956dc1 RLIMIT_OFILE alias for RLIMIT_NOFILE
Fixes: https://pagure.io/koji/issue/3101
2021-12-13 17:25:43 +01:00
Tomas Kopecek
d768d5d37e PR#3117: Deprecated hub option DisableGSSAPIProxyDNFallback
Merges #3117
https://pagure.io/koji/pull-request/3117

Fixes: #3100
https://pagure.io/koji/issue/3100
Deprecated DisableGSSAPIProxyDNFallback option on Hub
2021-12-13 17:20:35 +01:00