Commit graph

6507 commits

Author SHA1 Message Date
Alex Iribarren
9bc9680285 Fix parsing of URLs with port numbers 2022-03-25 15:37:37 +01:00
Tomas Kopecek
6444cf144b PR#3298: Use buildins.type when option is called type in readTaggedRPMS
Merges #3298
https://pagure.io/koji/pull-request/3298

Fixes: #3283
https://pagure.io/koji/issue/3283
readTaggedRPMS has conflict with param type and type function
2022-03-25 14:48:51 +01:00
Jana Cupova
a0b8ec8bfd Use builtins.type when option is called type in readTaggedRPMS
Fixes: https://pagure.io/koji/issue/3283
2022-03-24 13:05:30 +01:00
Tomas Kopecek
44f1eb9d11 PR#3300: Same format output for list-builroot with verbose for py3/py2
Merges #3300
https://pagure.io/koji/pull-request/3300

Fixes: #3299
https://pagure.io/koji/issue/3299
CLI list-buildroot with verbose print different format of message on py3 and py2
2022-03-24 13:00:01 +01:00
Jana Cupova
49f5f72a9f Same format output for list-builroot with verbose for py3/py2
Fixes: https://pagure.io/koji/issue/3299
2022-03-24 12:59:58 +01:00
Tomas Kopecek
16c2e6e576 PR#3297: doc: fix readTaggedRPMs rpmsigs option description
Merges #3297
https://pagure.io/koji/pull-request/3297

Fixes: #3231
https://pagure.io/koji/issue/3231
listTaggedRPMS documentation inconsistent with behaviour
2022-03-24 11:18:33 +01:00
Tomas Kopecek
3131a64178 doc: fix readTaggedRPMs rpmsigs option description
Related: https://pagure.io/koji/issue/3231
2022-03-23 14:02:29 +01:00
Tomas Kopecek
2394af63d9 PR#3234: Check ccache size before trying to use it
Merges #3234
https://pagure.io/koji/pull-request/3234

Fixes: #3233
https://pagure.io/koji/issue/3233
Kojid not able to authenticate when ccache is empty
2022-03-22 10:25:03 +01:00
Daniel Juarez
e596ca6fcb Check ccache size before trying to use it 2022-03-22 10:24:54 +01:00
Tomas Kopecek
1a71dcef81 PR#3270: Increase CLI test cases
Merges #3270
https://pagure.io/koji/pull-request/3270
2022-03-21 14:42:14 +01:00
Jana Cupova
a8f11fbf9c Increase CLI test cases 2022-03-21 14:42:08 +01:00
Tomas Kopecek
ba407086fb PR#3208: hub: improve inheritance priority collision error message
Merges #3208
https://pagure.io/koji/pull-request/3208
2022-03-21 14:39:45 +01:00
Ken Dreyer
ddb46d744b hub: improve inheritance priority collision error message
When users set multiple parents to the same priority in
setInheritanceData(), we raise an error because this is an invalid
configuration.

Improve the error message to make it easier for humans to understand the
problem and explain which tag ID ints are parents or children.
2022-03-21 14:39:05 +01:00
Tomas Kopecek
f5fe7a550e PR#3269: return 400 codes when client fails to send a full request
Merges #3269
https://pagure.io/koji/pull-request/3269

Fixes: #3268
https://pagure.io/koji/issue/3268
Some network errors cannot be retried
2022-03-21 14:34:37 +01:00
Mike McLean
f89794ce07 also raise 400 errors when we can't read the client upload stream 2022-03-21 14:34:30 +01:00
Mike McLean
37b108bf24 fix indent 2022-03-21 14:34:30 +01:00
Mike McLean
3ece0d8e05 return 400 codes when client fails to send a full request
Fixes: https://pagure.io/koji/issue/3268
2022-03-21 14:34:30 +01:00
Tomas Kopecek
c5749fc414 PR#3265: Set dst permissions same as src permissions
Merges #3265
https://pagure.io/koji/pull-request/3265

Fixes: #3260
https://pagure.io/koji/issue/3260
Koji 1.28.0 writes RPMs with mode 0600 (not accessible for distRepo tasks via NFS)
2022-03-21 14:33:50 +01:00
Jana Cupova
b3258c4273 Set dst permissions same as src permissions
Fixes: https://pagure.io/koji/issue/3260
2022-03-21 14:33:43 +01:00
Tomas Kopecek
4429b88385 PR#3255: allow untag-build for blocked packages
Merges #3255
https://pagure.io/koji/pull-request/3255

Fixes: #3134
https://pagure.io/koji/issue/3134
Allow untagging "invisible" tagged builds
2022-03-21 14:32:30 +01:00
Jana Cupova
d561ded4fa allow untag-build for blocked packages
https://pagure.io/koji/issue/3134
2022-03-21 14:32:23 +01:00
Tomas Kopecek
2a6f186210 PR#3252: Fix tag and target shows as string, not as dict to string
Merges #3252
https://pagure.io/koji/pull-request/3252

Fixes: #3251
https://pagure.io/koji/issue/3251
webUI shows tag and targets on webUI as dict, when user create task with dict param
2022-03-21 14:30:10 +01:00
Jana Cupova
8f91020a01 Fix tag and target shows as string, not as dict to string
Fixes: https://pagure.io/koji/issue/3251
2022-03-21 14:30:03 +01:00
Tomas Kopecek
47a80cf0ff PR#3238: Remove koji.listFaults
Merges #3238
https://pagure.io/koji/pull-request/3238

Fixes: #3083
https://pagure.io/koji/issue/3083
Remove deprecated listFaults
2022-03-21 14:29:18 +01:00
Jana Cupova
995b57c961 Remove koji.listFaults
Fixes: https://pagure.io/koji/issue/3083
2022-03-21 14:29:11 +01:00
Tomas Kopecek
bd1b996e69 PR#3237: Remove taskReport API call
Merges #3237
https://pagure.io/koji/pull-request/3237

Fixes: #3032
https://pagure.io/koji/issue/3032
Remove deprecated taskReport
2022-03-21 14:28:35 +01:00
Jana Cupova
dc58186d1f Remove taskReport API call
Fixes: https://pagure.io/koji/issue/3032
2022-03-21 14:28:29 +01:00
Alex Iribarren
68040263d3 Fix syntax error
Fixes: https://pagure.io/koji/issue/3264
2022-02-25 08:47:38 +01:00
Tomas Kopecek
77aec93b98 Revert "refactor exceptions to koji.exceptions"
This reverts commit 1e00081991.
2022-02-21 12:33:25 +01:00
Tomas Kopecek
fd84571f82 Revert "add "NoSuch" custom exceptions"
This reverts commit 3ff8eef322.
2022-02-21 12:33:18 +01:00
Tomas Kopecek
a99c695728 PR#3240: [WIP] Koji 1.28.0 release notes
Merges #3240
https://pagure.io/koji/pull-request/3240

Fixes: #3224
https://pagure.io/koji/issue/3224
1.28 release notes
2022-02-21 12:27:47 +01:00
Tomas Kopecek
a9e440e725 fix typo 2022-02-10 15:45:01 +01:00
Tomas Kopecek
7081ce90db Koji 1.28.0 release notes
Fixes: https://pagure.io/koji/issue/3224
2022-02-10 15:45:01 +01:00
Ken Dreyer
3ff8eef322 add "NoSuch" custom exceptions
Add more custom exception classes. This will allow to programmatically
determine the error causes from complex RPCs.

This commit simply defines the new classes and fault codes. Nothing in
Koji's codebase uses these exceptions yet. We'll begin to raise these
exceptions after this is widely deployed for clients in the field.
2022-02-10 15:44:04 +01:00
Ken Dreyer
1e00081991 refactor exceptions to koji.exceptions
Move Koji's custom exceptions classes to a dedicated koji.exceptions
library. This organizes the code so it's easier to maintain, and matches
patterns in other well-known projects, like requests.exceptions or
cryptography.exceptions.
2022-02-10 15:44:04 +01:00
Tomas Kopecek
e73b0680ae PR#3247: Fix makedirs for existing dirs
Merges #3247
https://pagure.io/koji/pull-request/3247

Fixes: #3097
https://pagure.io/koji/issue/3097
Write signed copies atomically
2022-02-07 15:09:37 +01:00
Jana Cupova
968eb61055 Fix makedirs for existing dirs
Fixes: https://pagure.io/koji/issue/3097
2022-02-07 15:04:34 +01:00
Tomas Kopecek
25d4f48697 PR#3203: Hide sensitive values in urrlib3 exceptions
Merges #3203
https://pagure.io/koji/pull-request/3203

Fixes: #2801
https://pagure.io/koji/issue/2801
some failures can reveal session-id and session-key on output
2022-02-07 11:11:26 +01:00
Tomas Kopecek
06b5f7c188 Hide sensitive values in urrlib3 exceptions
Fixes: https://pagure.io/koji/issue/2801
2022-02-07 11:10:19 +01:00
Tomas Kopecek
f2d35fe0a7 PR#3245: Escape builds, tasks and tags name
Merges #3245
https://pagure.io/koji/pull-request/3245

Fixes: #3155
https://pagure.io/koji/issue/3155
Remove regexp validation from webui
2022-02-07 10:47:53 +01:00
Jana Cupova
ca7e67d808 Escape builds, tasks and tags name
Fixes: https://pagure.io/koji/issue/3155
2022-02-07 10:45:27 +01:00
Tomas Kopecek
3faca02c28 PR#3239: Write signed copies atomically
Merges #3239
https://pagure.io/koji/pull-request/3239

Fixes: #3097
https://pagure.io/koji/issue/3097
Write signed copies atomically
2022-02-07 10:13:05 +01:00
Jana Cupova
c1920b330a Write signed copies atomically
Fixes: https://pagure.io/koji/issue/3097
2022-02-07 10:12:57 +01:00
Tomas Kopecek
db6931b735 PR#3228: api: checksum_type filter for listArchives
Merges #3228
https://pagure.io/koji/pull-request/3228

Fixes: #3227
https://pagure.io/koji/issue/3227
listArchives should allow also checksum_type specification.
2022-02-07 10:10:31 +01:00
Tomas Kopecek
01c0f91d62 update docstring 2022-02-07 10:10:23 +01:00
Tomas Kopecek
66a94f045e api: checksum_type filter for listArchives
Related: https://pagure.io/koji/issue/3227
2022-02-07 10:10:23 +01:00
Tomas Kopecek
7fe0d10d60 PR#3173: db: logging option for cursor
Merges #3173
https://pagure.io/koji/pull-request/3173

Fixes: #2837
https://pagure.io/koji/issue/2837
failed queries are always logged as errors, even when expected
2022-02-07 10:07:59 +01:00
Tomas Kopecek
6aaa6b3248 rename option 2022-02-07 10:07:26 +01:00
Tomas Kopecek
0449aa4829 fix tests 2022-02-07 10:01:21 +01:00
Tomas Kopecek
e7db7d8b53 db: logging option for cursor
In some cases we expect query to fail (LOCK NOWAIT) but it still
clutters the logs. Option for not logging cursor-level errors.

Fixes: https://pagure.io/koji/issue/2837
2022-02-07 10:01:21 +01:00