Tomas Kopecek
fd516dffd8
PR#3168: protonmsg: allow users to specify router-specific topic prefixes
...
Merges #3168
https://pagure.io/koji/pull-request/3168
Fixes #3169
https://pagure.io/koji/issue/3169
2021-12-20 08:44:32 +01:00
Ken Dreyer
dbacf1f985
protonmsg: allow users to specify router-specific topic prefixes
...
Prior to this change, Koji would always send messages with a hard-coded
topic:// prefix.
This works fine for ActiveMQ 5 and Artemis, but RabbitMQ does not
support that syntax. Instead, RabbitMQ brokers expect clients to use
topic addresses with a "/topic/" prefix.
The RFE for RabbitMQ to support "topic://" prefixes is
https://github.com/rabbitmq/rabbitmq-server/issues/2583
In the meantime, allow users to specify "topic://" or "/topic/"
explicitly in their configuration.
For backwards-compatibility, if the user chose neither "topic://" nor
"/topic/", prepend the "topic://" string, preserving the plugin's
existing behavior.
(Note: ActiveMQ 5 advertises its expected topic:// prefix in the initial
connection properties, so we could read that value dynamically, but
RabbitMQ and Artemis do not send an expected topic prefix connection
properties, so we just make the user choose explicitly here.)
2021-12-20 08:44:27 +01:00
Tomas Kopecek
dc47bcc8cc
PR#3108: Remove rename-channel CLI and use editChannel in renameChannel
...
Merges #3108
https://pagure.io/koji/pull-request/3108
Fixes : #3035
https://pagure.io/koji/issue/3035
Remove deprecated rename_channel
2021-12-15 15:28:26 +01:00
Jana Cupova
18b136d386
Remove rename-channel CLI and use editChannel in renameChannel
...
Fixes: https://pagure.io/koji/issue/3035
2021-12-15 15:28:19 +01:00
Tomas Kopecek
109feb5629
PR#3158: Deprecated remove-channel CLI and removeChannel API
...
Merges #3158
https://pagure.io/koji/pull-request/3158
Fixes : #1206
https://pagure.io/koji/issue/1206
removeChannel behavior affected by host history feature
2021-12-15 15:26:23 +01:00
Jana Cupova
c7fd26aeda
Deprecated remove-channel CLI and removeChannel API
...
Fixes: https://pagure.io/koji/issue/1206
2021-12-15 15:26:11 +01:00
Tomas Kopecek
a227cce7a5
PR#3166: kojira: don't fail on deleted items
...
Merges #3166
https://pagure.io/koji/pull-request/3166
2021-12-15 15:24:03 +01:00
Tomas Kopecek
6b64222ab7
kojira: don't fail on deleted items
...
py2 relict - dict.values() is now iterator, so
RuntimeError: dictionary changed size during iteration
can be raised when needed repo was deleted during the iteration.
Simple fix to use copy instead of iterator will fix this.
2021-12-15 15:23:56 +01:00
Tomas Kopecek
c85b1efbb7
PR#3113: error function instead of print with sys.exit in CLI commands
...
Merges #3113
https://pagure.io/koji/pull-request/3113
Fixes : #3112
https://pagure.io/koji/issue/3112
Use error function instead of print with sys.exit in cli commands
2021-12-15 15:19:24 +01:00
Jana Cupova
5232ea5aa1
error function instead of print with sys.exit in CLI commands
...
Fixes: https://pagure.io/koji/issue/3112
2021-12-15 15:19:18 +01:00
Tomas Kopecek
6fd7845be3
PR#3180: Add unit test for get_options
...
Merges #3180
https://pagure.io/koji/pull-request/3180
Fixes : #3181
https://pagure.io/koji/issue/3181
Coverage get_options (cli/koji) options
2021-12-15 15:12:18 +01:00
Jana Cupova
8d7b9508f1
Add unit test for get_options
...
Fixes: https://pagure.io/koji/issue/3181
2021-12-15 15:12:12 +01:00
Tomas Kopecek
e23e7d6cac
PR#3164: [hub] only raise error when authtype is not proxyauthtype
...
Merges #3164
https://pagure.io/koji/pull-request/3164
Fixes : #3163
https://pagure.io/koji/issue/3163
AllowProxyAuthType needs to be on even for same auth mechanisms
2021-12-15 15:04:25 +01:00
Yuming Zhu
969f102598
[hub] only raise error when authtype is not proxyauthtype
...
fixes : #3163
2021-12-15 15:04:20 +01:00
Tomas Kopecek
850bea59fc
PR#3098: Add all options to hub_conf.rst
...
Merges #3098
https://pagure.io/koji/pull-request/3098
Fixes : #3073
https://pagure.io/koji/issue/3073
Documentation page for hub config options
2021-12-15 14:09:23 +01:00
Jana Cupova
89d14f2093
Add all options to hub_conf.rst
...
Fixes: https://pagure.io/koji/issue/3073
2021-12-15 14:09:15 +01:00
Tomas Kopecek
892f891cbd
PR#3172: Return mistakenly dropped option (--keytab)
...
Merges #3172
https://pagure.io/koji/pull-request/3172
Fixes : #3171
https://pagure.io/koji/issue/3171
Return dropped option --keytab
2021-12-14 14:16:13 +01:00
Tomas Kopecek
a3edb7a4b9
Return mistakenly dropped option (--keytab)
...
PR https://pagure.io/koji/pull-request/3051 was wrongly merged
https://pagure.io/koji/c/071533206e6d29f665d7a5864eda75087488a3ce?branch=master
and deleted wrong line. Reverting it.
Fixes: https://pagure.io/koji/issue/3171
2021-12-14 14:16:05 +01:00
Tomas Kopecek
e149e6b24d
PR#3116: RLIMIT_OFILE alias for RLIMIT_NOFILE
...
Merges #3116
https://pagure.io/koji/pull-request/3116
Fixes : #3101
https://pagure.io/koji/issue/3101
RLIMIT_OFILE option is old
2021-12-13 17:25:51 +01:00
Jana Cupova
d80f956dc1
RLIMIT_OFILE alias for RLIMIT_NOFILE
...
Fixes: https://pagure.io/koji/issue/3101
2021-12-13 17:25:43 +01:00
Tomas Kopecek
d768d5d37e
PR#3117: Deprecated hub option DisableGSSAPIProxyDNFallback
...
Merges #3117
https://pagure.io/koji/pull-request/3117
Fixes : #3100
https://pagure.io/koji/issue/3100
Deprecated DisableGSSAPIProxyDNFallback option on Hub
2021-12-13 17:20:35 +01:00
Jana Cupova
f4616d4ee2
Deprecated hub option DisableGSSAPIProxyDNFallback
...
Fixes: https://pagure.io/koji/issue/3100
2021-12-13 17:20:22 +01:00
Tomas Kopecek
f2f4a3dcdf
PR#3137: www: rpminfo/fileinfo/imageinfo/archiveinfo page shows human-readable filesize
...
Merges #3137
https://pagure.io/koji/pull-request/3137
Fixes : #2943
https://pagure.io/koji/issue/2943
www: rpminfo page does not show human-readable filesize
2021-12-13 17:05:26 +01:00
Jana Cupova
d370e42c64
www: rpminfo/fileinfo/imageinfo/archiveinfo page shows human-readable filesize
...
Fixes: https://pagure.io/koji/issue/2943
2021-12-13 17:05:17 +01:00
Tomas Kopecek
af87214371
PR#3146: CLI mock-config: when topdir option, remove topurl value
...
Merges #3146
https://pagure.io/koji/pull-request/3146
Fixes : #2675
https://pagure.io/koji/issue/2675
CLI mock-config with option --topdir does not make any change on mock config
2021-12-13 17:02:03 +01:00
Jana Cupova
f528fd9ca4
CLI mock-config: when topdir option, remove topurl value
...
Fixes: https://pagure.io/koji/issue/2675
2021-12-13 17:00:22 +01:00
Tomas Kopecek
0b911ed0c4
PR#3145: Deprecated force option in groupPackageListRemove call
...
Merges #3145
https://pagure.io/koji/pull-request/3145
Fixes : #3131
https://pagure.io/koji/issue/3131
API call groupPackageListRemove never uses force parameter
2021-12-13 16:38:28 +01:00
Jana Cupova
178cb8a398
Deprecated force option in groupPackageListRemove call
...
Fixes: https://pagure.io/koji/issue/3131
2021-12-13 16:38:18 +01:00
Tomas Kopecek
ab99347007
PR#3105: Deprecated --paths option in list-buildroot
...
Merges #3105
https://pagure.io/koji/pull-request/3105
Fixes : #2473
https://pagure.io/koji/issue/2473
list-buildroots --paths option not reflected
2021-12-13 16:35:00 +01:00
Jana Cupova
54055c8ed0
Deprecated --paths option in list-buildroot
...
Fixes: https://pagure.io/koji/issue/2473
2021-12-13 16:34:53 +01:00
Tomas Kopecek
d83a7631eb
PR#3177: Drop RHEL6 references
...
Merges #3177
https://pagure.io/koji/pull-request/3177
Fixes : #3165
https://pagure.io/koji/issue/3165
Drop RHEL6 references
2021-12-13 13:24:47 +01:00
Jana Cupova
22c5e8dad6
Drop RHEL6 references
...
Fixes: https://pagure.io/koji/issue/3165
2021-12-10 13:55:26 +01:00
Tomas Kopecek
c160e483ce
PR#3028: Add limits on name values
...
Merges #3028
https://pagure.io/koji/pull-request/3028
Fixes : #2117
https://pagure.io/koji/issue/2117
limits on name values
2021-12-09 14:07:41 +01:00
Jana Cupova
74ac826a87
Add limits on name values
...
Fixes: https://pagure.io/koji/issue/2117
2021-12-09 07:11:57 +01:00
Tomas Kopecek
95717ba28d
PR#3174: hub: document getBuildLogs method
...
Merges #3174
https://pagure.io/koji/pull-request/3174
2021-12-08 10:27:36 +01:00
Ken Dreyer
2418d91473
hub: document getBuildLogs method
...
Update the getBuildLogs RPC docstring to describe the "build"
parameters and the return type. Highlight that this call is only
relevant for completed builds, not incomplete builds.
2021-12-07 14:55:09 -05:00
Tomas Kopecek
11ffdf6480
PR#3157: Pytest instead of nose in unittest
...
Merges #3157
https://pagure.io/koji/pull-request/3157
Fixes : #3140
https://pagure.io/koji/issue/3140
library nose not supported python 3.10
2021-12-06 12:17:35 +01:00
Jana Cupova
c310d6692d
Pytest instead of nose in unittest
...
Fixes: https://pagure.io/koji/issue/3140
2021-12-06 12:17:29 +01:00
Tomas Kopecek
bbaadef417
PR#3119: AuthExpire returns code 1 in kojid
...
Merges #3119
https://pagure.io/koji/pull-request/3119
Fixes : #3084
https://pagure.io/koji/issue/3084
Clean up daemon exit codes
2021-12-06 10:18:19 +01:00
Jana Cupova
2d820f4b7d
AuthExpire returns code 1 in kojid
...
Fixes: https://pagure.io/koji/issue/3084
2021-12-06 10:18:11 +01:00
Tomas Kopecek
f979899e5c
PR#3161: hub: fix spelling in comments for archive handling
...
Merges #3161
https://pagure.io/koji/pull-request/3161
2021-12-06 09:03:51 +01:00
Ken Dreyer
73781b6a9c
hub: fix spelling in comments for archive handling
...
Fix some spelling errors in the comments for the code that handles
archives.
2021-12-02 12:30:59 -05:00
Tomas Kopecek
d0507c4d2d
PR#3115: Add and update CLI unit tests
...
Merges #3115
https://pagure.io/koji/pull-request/3115
Fixes : #729
https://pagure.io/koji/issue/729
Goal: 60% coverage for cli commands
2021-11-29 15:39:17 +01:00
Jana Cupova
c3e89500f2
Add and upfate CLI unit tests
...
Fixes: https://pagure.io/koji/issue/729
2021-11-29 15:39:10 +01:00
Tomas Kopecek
ae15fa34ba
PR#3150: Rewrite Acceptable keys to Requested keys in missing_signatures log
...
Merges #3150
https://pagure.io/koji/pull-request/3150
Fixes : #3149
https://pagure.io/koji/issue/3149
Rename 'Acceptable keys' in missing signatures.log to more understandable name
2021-11-29 15:28:20 +01:00
Jana Cupova
082f15eae5
Rewrite Acceptable keys to Requested keys in missing_signatures log
...
Fixes: https://pagure.io/koji/issue/3149
2021-11-29 15:28:13 +01:00
Tomas Kopecek
c96f07bdb0
PR#3142: devtools: print fakeweb listening URL
...
Merges #3142
https://pagure.io/koji/pull-request/3142
2021-11-23 09:24:16 +01:00
Ken Dreyer
4a440297ef
devtools: print fakeweb listening URL
...
Show the user the full URL to paste into the browser.
2021-11-23 09:24:09 +01:00
Tomas Kopecek
12f52aa0a2
PR#3138: doc: improve protonmsg SSL parameter descriptions
...
Merges #3138
https://pagure.io/koji/pull-request/3138
2021-11-22 14:18:08 +01:00
Ken Dreyer
e784c25541
doc: improve protonmsg SSL parameter descriptions
...
Explain that the "cert" is a combination of public certificate and key
file.
Explain that "cacert" is the CA that signed the amqps broker's
certificate.
2021-11-22 14:18:02 +01:00
