Commit graph

7612 commits

Author SHA1 Message Date
Tomas Kopecek
f5c9ca95f6 PR#4068: Rework mocking of QueryProcessor in DBQueryTestCase
Merges #4068
https://pagure.io/koji/pull-request/4068

Fixes: #4071
https://pagure.io/koji/issue/4071
DBQueryTestCase class doesn't work for other hub modules

Relates: #2758
https://pagure.io/koji/issue/2758
DBQueryTest doesn't clean mock env
2024-04-15 11:08:38 +02:00
Mike McLean
2485b87294 more missing tearDowns 2024-04-15 11:08:29 +02:00
Mike McLean
f49ee80a7b fix missing tearDown methods for numerous tests 2024-04-15 11:08:29 +02:00
Mike McLean
a807137c3c rework DBQueryTestCase mocking
Mocking kojihub.kojihub.QueryProcessor doesn't affect other import
paths, e.g. in other kojihub modules
2024-04-15 11:08:29 +02:00
Tomas Kopecek
4df957cb3d PR#4069: add requirement: defusedxml in setup.py
Merges #4069
https://pagure.io/koji/pull-request/4069

Fixes: #4067
https://pagure.io/koji/issue/4067
defusedxml missing from setup.py
2024-04-12 12:10:12 +02:00
Yuming Zhu
ad7cea732d add requirement: defusedxml in setup.py
fixes: #4067
2024-04-12 12:10:05 +02:00
Tomas Kopecek
6e2e795be2 PR#4046: kiwi: Generate full logs with debug information
Merges #4046
https://pagure.io/koji/pull-request/4046

Fixes #4048
https://pagure.io/koji/issue/4048
2024-04-10 14:41:22 +02:00
Neal Gompa
baa5a735e1 kiwi: Generate full logs with debug information
Without this flag, we do not have logs that include the details of
what happened during the build.
2024-04-10 14:41:15 +02:00
Tomas Kopecek
d331654069 PR#4012: rmtree: use fork
Merges #4012
https://pagure.io/koji/pull-request/4012

Fixes: #3755
https://pagure.io/koji/issue/3755
koji-gc occasionally gets Directory not empty fault on delete

Fixes: #2481
https://pagure.io/koji/issue/2481
koji.util.rmtree() is not multi-process/thread safe
2024-04-10 11:20:23 +02:00
Mike McLean
4dd0e24b00 correct a few comment lines 2024-04-10 11:20:15 +02:00
Mike McLean
ce4718f1fb fix samefile check and relative path test 2024-04-10 11:20:15 +02:00
Mike McLean
e8ae18fcc8 Align our cwd tracking with os 2024-04-10 11:20:15 +02:00
Mike McLean
895d0cf8ec avoid double fork in kojira rmtree 2024-04-10 11:20:15 +02:00
Mike McLean
f9eefde102 cleanup 2024-04-10 11:20:15 +02:00
Mike McLean
c0917955c0 more testcases 2024-04-10 11:20:15 +02:00
Mike McLean
4fddafc54d rmtree: use fork
These changes work around a thread safety issue in our rmtree
implementation, which uses chdir to traverse the directory tree.
Using chdir resolves issues deleting paths longer than PATH_MAX, but
makes the code inherently unsafe in a threaded environment.

Now, the main rmtree function uses fork to perform the actions in a
dedicated process.
To avoid possible locking issues with the logging module, we introduce a
simple proxy logger for the subprocess.

Fixes: https://pagure.io/koji/issue/3755

For historical context see:
https://pagure.io/koji/issue/201
https://pagure.io/koji/issue/2481
https://pagure.io/koji/issue/2714
2024-04-10 11:20:15 +02:00
Tomas Kopecek
c4b50c65c7 PR#4044: Update getNextTask for scheduler
Merges #4044
https://pagure.io/koji/pull-request/4044

Fixes: #4028
https://pagure.io/koji/issue/4028
Clean getNextTask
2024-03-28 15:58:15 +01:00
Mike McLean
9c8b9a1556 skip updateBuildroots if we have just taken a task 2024-03-28 15:58:07 +01:00
Mike McLean
1d0d4f2683 add unit tests and drop obsolete ones 2024-03-28 15:58:07 +01:00
Mike McLean
5c383b6175 clean up logging 2024-03-28 15:58:07 +01:00
Mike McLean
3554a1fb43 update getNextTask to use host.getTasks 2024-03-28 15:58:07 +01:00
Tomas Kopecek
3315e3c379 PR#4000: Fix remove-tag-inheritance with priority
Merges #4000
https://pagure.io/koji/pull-request/4000

Fixes: #2804
https://pagure.io/koji/issue/2804
allow duplicate parents with different priorities in the same inheritance level

Fixes: #3985
https://pagure.io/koji/issue/3985
remove-tag-inheritance ignores priority
2024-03-26 15:11:34 +01:00
Jana Cupova
63a6f43d8a Fix remove-tag-inheritance with priority
Fix remote-tag-inheritance with priority

Fixes: https://pagure.io/koji/issue/3985
2024-03-26 15:11:24 +01:00
Tomas Kopecek
41ab495f28 PR#4043: --limit from scheduler-logs/info
Merges #4043
https://pagure.io/koji/pull-request/4043

Fixes: #4042
https://pagure.io/koji/issue/4042
scheduler-logs/info don't limit returned records
2024-03-26 12:28:16 +01:00
Tomas Kopecek
2c9f69524a fix flake8 2024-03-26 12:27:31 +01:00
Tomas Kopecek
2c2e9209d1 fix typo 2024-03-20 14:11:43 +01:00
Tomas Kopecek
2468cb989d modify for 1.34.1 2024-03-20 13:48:59 +01:00
Mike McLean
030a54b8d4 use hub version check for compat code 2024-03-20 13:48:58 +01:00
Tomas Kopecek
fe3474c0e8 better compatibility errors 2024-03-20 13:48:58 +01:00
Tomas Kopecek
f3306a371b backward compatibility 2024-03-20 13:48:58 +01:00
Tomas Kopecek
43b173bb17 --limit from scheduler-logs/info
Related: https://pagure.io/koji/issue/4042
2024-03-20 13:48:58 +01:00
Tomas Kopecek
91f410f8fb PR#4025: docs: mock's configuration
Merges #4025
https://pagure.io/koji/pull-request/4025

Fixes: #4019
https://pagure.io/koji/issue/4019
RLIMITS settings for nspawn
2024-03-19 11:10:03 +01:00
Mike McLean
88ea24441d doc updates 2024-03-19 11:09:54 +01:00
Tomas Kopecek
54f32e8266 docs: mock's configuration
Related: https://pagure.io/koji/issue/4019
2024-03-19 11:09:54 +01:00
Tomas Kopecek
296cf75468 PR#4052: fix formatting of rpm in title
Merges #4052
https://pagure.io/koji/pull-request/4052

Fixes #4053
https://pagure.io/koji/issue/4053
2024-03-19 10:53:32 +01:00
Mike McLean
2af702b71c fix formatting of rpm in title 2024-03-19 10:53:24 +01:00
Tomas Kopecek
d7d4e4f1d2 PR#4026: Better index for rpm lookup
Merges #4026
https://pagure.io/koji/pull-request/4026

Fixes: #4022
https://pagure.io/koji/issue/4022
rpminfo_unique_nvra_not_draft index is insufficient for rpm lookups
2024-03-19 10:52:47 +01:00
Tomas Kopecek
d0c1b4d37d Better index for rpm lookup
Related: https://pagure.io/koji/issue/4022
2024-03-19 10:52:33 +01:00
Tomas Kopecek
c44be86c40 PR#4023: split out buildroot log watching logic
Merges #4023
https://pagure.io/koji/pull-request/4023

Fixes: #4009
https://pagure.io/koji/issue/4009
RFE: Grab /var/log/dnf5.log from Mock buildroot

Relates: #3875
https://pagure.io/koji/issue/3875
Log the macros enabled in side tag
2024-03-13 10:09:25 +01:00
Mike McLean
aa370c20a2 capture dnf logs
Fixes https://pagure.io/koji/issue/4009
2024-03-13 10:09:15 +01:00
Mike McLean
9694f07aef reduce log noise a bit 2024-03-13 10:09:15 +01:00
Mike McLean
60b71020f0 split out buildroot log watching logic 2024-03-13 10:09:15 +01:00
Mike McLean
c51ae5d6b3 typo in BuildMavenTask 2024-03-13 10:09:15 +01:00
Mike McLean
27160b1a58 also use in appliance/livecd/liveimage 2024-03-13 10:09:15 +01:00
Mike McLean
c08b3fd042 rename var 2024-03-13 10:09:15 +01:00
Tomas Kopecek
91f176ccb5 Track uploads in BuildRoot and log mock config
Related: https://pagure.io/koji/issue/3875
2024-03-13 10:09:15 +01:00
Tomas Kopecek
eba8de2473 PR#3970: Add CLI with users with given permission
Merges #3970
https://pagure.io/koji/pull-request/3970

Fixes: #3950
https://pagure.io/koji/issue/3950
Add command to list users with a particular permission
2024-03-11 13:12:33 +01:00
Jana Cupova
c62e3467b5 Add CLI with users with given permission
Fixes: https://pagure.io/koji/issue/3950
2024-03-11 13:12:20 +01:00
Tomas Kopecek
7d126abe91 PR#4032: implicit task refusals
Merges #4032
https://pagure.io/koji/pull-request/4032

https://pagure.io/koji/issue/4035
2024-03-06 11:14:20 +01:00
Mike McLean
c00e9b3c2e unit test 2024-03-06 11:14:12 +01:00