Commit graph

5260 commits

Author SHA1 Message Date
Kevin Fenzi
fa8ac96d54 clean_old option was duplicated on clean_empty
The --no-old option wouldn't work because the check was checking for
--no-empty, and --no-empty was disabling both checks. :)

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-06-23 12:32:51 +02:00
Tomas Kopecek
b3049b0ebf PR#2331: hub: document listChannels arguments
Merges #2331
https://pagure.io/koji/pull-request/2331
2020-06-23 12:24:12 +02:00
Ken Dreyer
993be46a4c hub: document listChannels arguments
Describe the arguments and return value for the listChannels() method.
2020-06-23 12:24:04 +02:00
Tomas Kopecek
40d205b73f PR#2318: make mock depsolver policy configurable
Merges #2318
https://pagure.io/koji/pull-request/2318

Fixes: #826
https://pagure.io/koji/issue/826
Make mock depsolver policy configurable
2020-06-23 12:21:15 +02:00
Tomas Kopecek
ac38549992 make mock depsolver policy configurable
Fixes: https://pagure.io/koji/issue/826
2020-06-23 09:02:15 +02:00
Tomas Kopecek
62998b0885 PR#1932: per-tag settings for mock's sign plugin
Merges #1932
https://pagure.io/koji/pull-request/1932

Fixes: #84
https://pagure.io/koji/issue/84
[Feature Request] Allow koji-builder to use Mock's sign plugin to automatically sign package after build
2020-06-19 13:30:07 +02:00
Tomas Kopecek
ae1561876c flake8 fix 2020-06-19 13:23:59 +02:00
Tomas Kopecek
baa14dd38e update docs 2020-06-19 13:21:53 +02:00
Tomas Kopecek
8e7b616ca4 fix option names 2020-06-19 13:21:53 +02:00
Tomas Kopecek
477fb48b67 per-tag settings for mock's sign plugin
Based on amessina's patch

Fixes: https://pagure.io/koji/issue/84
2020-06-19 13:21:53 +02:00
Tomas Kopecek
c06404246e PR#2328: koji-gc: fix flake8
Merges #2328
https://pagure.io/koji/pull-request/2328
2020-06-18 15:53:22 +02:00
Tomas Kopecek
4f925cec2b koji-gc: fix flake8 2020-06-18 15:51:42 +02:00
Tomas Kopecek
19b491ec47 PR#2218: Drop py2 support for hub/web
Merges #2218
https://pagure.io/koji/pull-request/2218

Fixes: #1942
https://pagure.io/koji/issue/1942
Drop py2 support for hub/web
2020-06-18 15:41:44 +02:00
Tomas Kopecek
51358cfd09 simplify py3 tests 2020-06-18 15:41:35 +02:00
Tomas Kopecek
af311184fc dropping six from hub/web 2020-06-18 15:41:35 +02:00
Tomas Kopecek
83d425f976 drop py2 hub and web from spec
Fixes: https://pagure.io/koji/issue/1942
2020-06-18 15:41:35 +02:00
Tomas Kopecek
ac0e8812d5 PR#2316: kojira: replace deprecated Thread.isAlive()
Merges #2316
https://pagure.io/koji/pull-request/2316

Fixes: #2312
https://pagure.io/koji/issue/2312
kojiria uses depreciated isAlive() call
2020-06-18 15:36:03 +02:00
Tomas Kopecek
2baa24bd4e kojira: replace deprecated Thread.isAlive()
From py 2.7 exists an alias is_alive, so it is safe to replace it.

Fixes: https://pagure.io/koji/issue/2312
2020-06-18 15:35:51 +02:00
Tomas Kopecek
70fa7017e0 PR#2309: hub: simplify recipients condition in build_notification()
Merges #2309
https://pagure.io/koji/pull-request/2309
2020-06-18 15:22:52 +02:00
Ken Dreyer
d7d745295a hub: simplify recipients condition in build_notification()
If get_notification_recipients() returns a non-empty list of recipients,
then the build_notification() method creates a new buildNotification task.

Simplify the conditional that checks the get_notification_recipients()
return value so that it is easier to read. Python treats an empty list
as False and a non-empty list as True, so we don't need to explicitly
test the list length here.

The purpose of this change is to make this code easier to read and
understand.
2020-06-18 15:22:44 +02:00
Tomas Kopecek
64147a3322 PR#2326: sidetag: parenthesis typo
Merges #2326
https://pagure.io/koji/pull-request/2326

Fixes: #2321
https://pagure.io/koji/issue/2321
Give koji admins the permission to remove-side-tag of others
2020-06-18 13:06:53 +02:00
Tomas Kopecek
b61df1bcc5 sidetag: parenthesis typo
Related: https://pagure.io/koji/issue/2321
2020-06-18 13:05:29 +02:00
Tomas Kopecek
474f346d48 PR#2322: Side tags: allow admin ops and misc fixes
Merges #2322
https://pagure.io/koji/pull-request/2322

Fixes: #2321
https://pagure.io/koji/issue/2321
Give koji admins the permission to remove-side-tag of others
2020-06-17 11:53:08 +02:00
Nils Philippsen
cad3e63ee5 Allow admins to operate on all sidetags
Fixes: #2321

Signed-off-by: Nils Philippsen <nils@redhat.com>
2020-06-17 11:52:58 +02:00
Nils Philippsen
a8c72a7740 Actually return results from is_sidetag()/_owner()
Signed-off-by: Nils Philippsen <nils@redhat.com>
2020-06-17 11:52:58 +02:00
Tomas Kopecek
fe596571e6 PR#2323: kojira: Fix logic detecting directories
Merges #2323
https://pagure.io/koji/pull-request/2323

Fixes #2324
https://pagure.io/koji/issue/2324
2020-06-17 10:18:37 +02:00
Nils Philippsen
ffd282031d Fix logic detecting directories
Signed-off-by: Nils Philippsen <nils@redhat.com>
2020-06-16 17:39:01 +02:00
Tomas Kopecek
cc5adaeb61 PR#2276: document merge modes
Merges #2276
https://pagure.io/koji/pull-request/2276

Fixes: #2099
https://pagure.io/koji/issue/2099
Document merge modes
2020-06-16 13:28:34 +02:00
Tomas Kopecek
196ee64f58 extend docs 2020-06-16 13:28:26 +02:00
Tomas Kopecek
089bc38320 document merge modes
Fixes: https://pagure.io/koji/issue/2099
2020-06-16 13:28:26 +02:00
Tomas Kopecek
f3633d7072 PR#2310: hub: fix "opt-outs" comment in get_notification_recipients()
Merges #2310
https://pagure.io/koji/pull-request/2310
2020-06-16 12:31:47 +02:00
Ken Dreyer
4e9a1590f3 hub: fix "opt-outs" comment in get_notification_recipients()
Fix a typo in the comment that describes the block of code that
assembles the set of opt-outs.
2020-06-16 12:31:36 +02:00
Tomas Kopecek
e58c813faf PR#2256: Don't break on deleted tag
Merges #2256
https://pagure.io/koji/pull-request/2256

Fixes: #1965
https://pagure.io/koji/issue/1965
koji-gc can fail on deleted tag
2020-06-16 11:22:25 +02:00
Tomas Kopecek
bf45a59bac Don't break on renamed tag
Fixes: https://pagure.io/koji/issue/1965
2020-06-16 11:21:11 +02:00
Tomas Kopecek
68f39fedc7 PR#2154: kojira: swap first_seen with latest mtime for repo
Merges #2154
https://pagure.io/koji/pull-request/2154

Fixes: #2139
https://pagure.io/koji/issue/2139
Revamp first_seen in kojira
2020-06-16 11:17:33 +02:00
Tomas Kopecek
0f69eabee1 kojira: swap first_seen with latest mtime for repo
first_seen is measured from start of the kojira process. This is
inconsistent between runs and short-lived processes will never delete
some repos. Replace it with mtime of repo directory, it still should be
sufficient indicator of age (if it exists).

Fixes: https://pagure.io/koji/issue/2139
2020-06-16 11:17:24 +02:00
Tomas Kopecek
2437d0c891 PR#2275: hub: default policy allow packagelist changes with 'tag' permission
Merges #2275
https://pagure.io/koji/pull-request/2275

Fixes: #2011
https://pagure.io/koji/issue/2011
package list changes doesn't honor tag permission
2020-06-16 11:04:23 +02:00
Tomas Kopecek
47210e44bf hub: default policy allow packagelist changes with 'tag' permission
Fixes: https://pagure.io/koji/issue/2011
2020-06-16 11:04:14 +02:00
Tomas Kopecek
1fe319d905 PR#2255: cli: output extra['rpm.macro.*'] to mock-config
Merges #2255
https://pagure.io/koji/pull-request/2255

Fixes: #1859
https://pagure.io/koji/issue/1859
RPM macros defined in tag extra data not shown in mock config
2020-06-16 10:15:14 +02:00
Tomas Kopecek
2bb460bc23 cli: output extra['rpm.macro.*'] to mock-config
Fixes: https://pagure.io/koji/issue/1859
2020-06-16 10:13:12 +02:00
Tomas Kopecek
c4f30abd58 PR#2253: koji-gc: set smtp_host to localhost by default
Merges #2253
https://pagure.io/koji/pull-request/2253

Fixes: #2252
https://pagure.io/koji/issue/2252
koji-gc: sending mail will fail if no smtp_host specified
2020-06-16 10:04:46 +02:00
Yu Ming Zhu
53982e3b6c koji-gc: set smtp_host to localhost by default
fixes: #2252
2020-06-16 10:04:35 +02:00
Tomas Kopecek
eb8d7f92a8 PR#2308: hub: return empty list in get_notification_recipients()
Merges #2308
https://pagure.io/koji/pull-request/2308

Fixes: #2307
https://pagure.io/koji/issue/2307
get_notification_recipients() can return None, leading to build_notification() crash
2020-06-16 09:58:40 +02:00
Ken Dreyer
4fb79b9e9f hub: return empty list in get_notification_recipients()
If we find no recipients, return an empty list, rather than None.

This fixes a crash in build_notifications() where we expect to call
len() on the return value from get_notification_recipients().

Fixes: https://pagure.io/koji/issue/2307
2020-06-16 09:58:28 +02:00
Mike McLean
e4726c368d PR#2293: disable notifications by default in [un]tagBuildBypass calls
Merges #2293
https://pagure.io/koji/pull-request/2293

Fixes: #2292
https://pagure.io/koji/issue/2292
Disable notifications by default in tagBuildBypass and untagBuildBypass
2020-06-11 14:42:42 -04:00
Mike McLean
0b1482d924 disable notifications by default in [un]tagBuildBypass calls
Fixes https://pagure.io/koji/issue/2292
2020-06-11 14:42:38 -04:00
Tomas Kopecek
2ed90d0600 PR#2303: hub: query_buildroots fix query behaviour
Merges #2303
https://pagure.io/koji/pull-request/2303

Fixes: #2302
https://pagure.io/koji/issue/2302
hub: query_buildroots - behave like queryset
2020-06-10 11:09:18 +02:00
Tomas Kopecek
efecdad43a hub: query_buildroots fix query behaviour
Fixes: https://pagure.io/koji/issue/2302
2020-06-10 11:06:32 +02:00
Mike McLean
9fa07f65c0 PR#2299: hub: query_buildroots have to return ASAP
Merges #2299
https://pagure.io/koji/pull-request/2299

Fixes: #2298
https://pagure.io/koji/issue/2298
query_buildroots can cause an enormous intermediate tables
2020-06-09 13:00:44 -04:00
Tomas Kopecek
db41061111 hub: query_buildroots have to return ASAP
If candidate_buildroot_ids are pruned to zero in some point,
query_buildroots have to return. Otherwise big working queryset will be
created eating resources and returning empty list anyway.

Fixes: https://pagure.io/koji/issue/2298
2020-06-09 16:06:26 +02:00