Tomas Kopecek
fc81129563
fix unreachable code
2017-10-30 16:53:59 -04:00
Mike McLean
ff57765c86
PR#656: remove unused calls
...
Merges #656
https://pagure.io/koji/pull-request/656
2017-10-30 16:49:03 -04:00
Tomas Kopecek
a12925fb72
remove unused calls
2017-10-30 16:48:59 -04:00
Mike McLean
3c84b33b3a
PR#652: add unittests for koji commands
...
Merges #652
https://pagure.io/koji/pull-request/652
Related: #640
https://pagure.io/koji/issue/640
Goal: 30% coverage for cli commands
2017-10-30 16:13:44 -04:00
Franz Chih-Ping Hsieh
85f489ee98
rename testcase class name
2017-10-30 16:13:40 -04:00
Franz Chih-Ping Hsieh
cb0d9ba37d
add unittests for koji command line:
...
- call
- hello / moshimoshi
- maven-chain
- resubmit
2017-10-30 16:13:40 -04:00
Franz Chih-Ping Hsieh
17f006511d
add unittests for koji commands
...
- assign-task
- wrapper-rpm
2017-10-30 16:13:40 -04:00
Mike McLean
423eac9e7f
PR#658: consolidate safe_rmtree, rmtree and shutil.rmtree
...
Merges #658
https://pagure.io/koji/pull-request/658
Fixes : #648
https://pagure.io/koji/issue/648
Consolidate rmtree usage
2017-10-30 12:09:08 -04:00
Mike McLean
b2f2ea83ed
also use rmtree in delete_build/reset_build
2017-10-30 12:09:04 -04:00
Tomas Kopecek
f4e3f7bccf
safe_rmtree: more constraints on tests
2017-10-30 12:09:04 -04:00
Tomas Kopecek
b5b6c50e79
safe_rmtree: fix tests for backward-compatibility
2017-10-30 12:09:04 -04:00
Mike McLean
b848458251
safe_rmtree: make return value consistent with past behavior
2017-10-30 12:09:04 -04:00
Mike McLean
a2d9d756fe
drop stale comment and avoid bare except in safe_rmtree
2017-10-30 12:09:04 -04:00
Mike McLean
4c1396b955
update rmtree patch in unit test for recycle_build
2017-10-30 12:09:04 -04:00
Tomas Kopecek
5b23fb1629
consolidate safe_rmtree, rmtree and shutil.rmtree
...
shutil.rmtree should be avoided in almost all cases
safe_rmtree has its usage in tasks module, but innards are replaced with
koji.util.rmtree, so we don't have two implementations of same task
Related: https://pagure.io/koji/issue/648
2017-10-30 12:09:04 -04:00
Mike McLean
70988911ea
PR#660: more runroot tests
...
Merges #660
https://pagure.io/koji/pull-request/660
Fixes : #641
https://pagure.io/koji/issue/641
Goal: 95% coverage for plugins
2017-10-30 10:47:05 -04:00
Tomas Kopecek
f639b99a71
more runroot tests
...
Related: https://pagure.io/koji/issue/641
2017-10-30 13:20:37 +01:00
Mike McLean
dec0c7b77f
PR#633: unify runroot CLI interface
...
Merges #633
https://pagure.io/koji/pull-request/633
Fixes : #564
https://pagure.io/koji/issue/564
Add --nowait option for koji runroot
2017-10-27 20:46:05 -04:00
Tomas Kopecek
eb2460f132
remove unused import
2017-10-27 20:46:00 -04:00
Mike McLean
81711cb8ac
clean up runroot unit test
2017-10-27 20:46:00 -04:00
Tomas Kopecek
f7f8b046ce
correct default for --wait
2017-10-27 20:46:00 -04:00
Tomas Kopecek
21427c0e2c
unify runroot CLI interface
...
Related: https://pagure.io/koji/issue/564
2017-10-27 20:46:00 -04:00
Mike McLean
c88c958f8c
PR#649: delete build directory if cg_import fails
...
Merges #649
https://pagure.io/koji/pull-request/649
Fixes : #584
https://pagure.io/koji/issue/584
stray files from broken cg imports
2017-10-27 17:20:49 -04:00
Tomas Kopecek
fe4c83a229
typo fix + tests
2017-10-27 17:20:40 -04:00
Tomas Kopecek
facb8eca6f
delete build directory if cg_import fails
...
Related: https://pagure.io/koji/issue/584
2017-10-27 17:20:40 -04:00
Mike McLean
fdc1cff3f5
PR#653: Add krb_canon_host option
...
Merges #653
https://pagure.io/koji/pull-request/653
Fixes : #599
https://pagure.io/koji/issue/599
correctly canonicalize hostname for krb auth
2017-10-27 16:03:16 -04:00
Mike McLean
d8fb302780
add krb_canon_host example in koji.conf
2017-10-27 15:32:25 -04:00
Mike McLean
900767cf4b
add krb_canon_host option to various clients
2017-10-27 15:32:25 -04:00
Mike McLean
edda41100c
krb_canon_host option to canonicalize hostname via dns
2017-10-27 15:32:25 -04:00
Mike McLean
a4e4174182
PR#657: protonmsg: include the arch in the headers of rpm sign messages
...
Merges #657
https://pagure.io/koji/pull-request/657
2017-10-26 11:09:18 -04:00
Mike Bonnet
661dd3a70c
protonmsg: include the arch in the headers of rpm sign messages
...
Including the arch in the headers may be useful for filtering.
2017-10-25 12:01:08 -04:00
Mike McLean
aa7a507fb0
PR#651: protonmsg: don't send rpm.sign messages when the sigkey is empty
...
Merges #651
https://pagure.io/koji/pull-request/651
2017-10-24 21:20:28 -04:00
Mike Bonnet
c6a1e0952a
protonmsg: don't send rpm.sign messages when the sigkey is empty
...
When a build completes, we store the original, unsigned rpm headers
to disk. This results in the postRPMSign callback being called, and
a rpm.sign message being sent with an empty sigkey. The intended
sematics of the rpm.sign message is to notify a service when an rpm
has been signed. Therefore, we should not be sending a message when
the sigkey is empty.
2017-10-24 21:20:24 -04:00
Mike McLean
282a0479a7
PR#654: Update links in docs to point to correct pages
...
Merges #654
https://pagure.io/koji/pull-request/654
2017-10-24 20:55:38 -04:00
Igor Wodiany
be9b15698d
Update links in docs to point to correct pages
...
On the documentation's index page two links point to the websites that
no longer exist. This commit updates links so they point to the new
websites.
2017-10-24 22:49:18 +01:00
Mike McLean
21fefc4c77
PR#631: cg_import fails immediately if build directory already exists
...
Merges #631
https://pagure.io/koji/pull-request/631
Merges #425
https://pagure.io//koji/issue/425
2017-10-17 16:41:24 -04:00
Brendan Reilly
036377352c
Changed check to correct build import dir
2017-10-17 16:41:18 -04:00
Brendan Reilly
57dbc9ac01
cg_import fails immediately if build directory already exists
2017-10-17 16:41:18 -04:00
Mike McLean
84d0f8ece8
PR#601: replace pycurl with requests
...
Merges #601
https://pagure.io/koji/pull-request/601
Fixes : #600
https://pagure.io/koji/issue/600
Remove pycurl dependency
2017-10-16 10:03:46 -04:00
Tomas Kopecek
d756d8c5bd
remove python3 typo
2017-10-16 10:03:42 -04:00
Tomas Kopecek
bf0552e6de
use contextlib wrapper for older python-requests
2017-10-16 10:03:42 -04:00
Tomas Kopecek
7e2cb6b156
replace pycurl with requests
...
Related: https://pagure.io/koji/issue/600
2017-10-16 10:03:42 -04:00
Mike McLean
6bc248cd09
PR#608: tests for handling user groups
...
Merges #608
https://pagure.io/koji/pull-request/608
Fixes : #604
https://pagure.io/koji/issue/604
getGroupMembers API call should raise GenericError exception for non existing groupname
Fixes : #607
https://pagure.io/koji/issue/607
dropGroupMember API call should raise GenericError exception for username which is not in group
Fixes : #603
https://pagure.io/koji/issue/603
addGroupMember API call should raise GenericError exception for non existing username or groupname
2017-10-12 18:07:11 -04:00
Tomas Kopecek
5139031d85
tests for handling user groups
...
Related: https://pagure.io/koji/issue/603
Related: https://pagure.io/koji/issue/604
Related: https://pagure.io/koji/issue/607
2017-10-12 18:07:06 -04:00
Mike McLean
fe24d164f8
PR#637: set timezone to US/Eastern when test_build_notification executing
...
Merges #637
https://pagure.io/koji/pull-request/637
2017-10-12 10:40:51 -04:00
Yuming Zhu
659a63a167
set timezone to US/Eastern when test_build_notification executing
...
following PR#628
2017-10-12 10:40:47 -04:00
Mike McLean
ff396155f2
PR#636: use urlparse.parse_qs instead of deprecated cgi.parse_qs
...
Merges #636
https://pagure.io/koji/pull-request/636
Fixes #635
https://pagure.io/koji/issue/635
2017-10-12 10:37:34 -04:00
Mike McLean
1a028c670a
PR#628: add a unit test for buildNotification task
...
Merges #628
https://pagure.io/koji/pull-request/628
2017-10-11 16:41:26 -04:00
Mike McLean
00e059c0c0
unit test for buildNotification task handler
2017-10-11 16:36:40 -04:00
Mike McLean
80ca9ff294
handle callbacks depth-first in DataWalker
2017-10-11 16:36:40 -04:00