robojerk/codeql-action
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
3061 commits 0 branches 1 tag 471 MiB
Commit graph

3061 commits

This branch
This branch
All branches
Author SHA1 Message Date
Andrew Eisenberg
1a17c59fb0 More renaming 
Avoid usage of "Feature Flag" unless we are talking specifically about
the response from github features api. Otherwise, use terms like
"Toggleable features".

Note both "toggleable" and "togglable" appear to be valid spellings of
the word. I chose the first for no good reason.
 2022-10-07 11:33:32 -07:00
Andrew Eisenberg
b27aed78f5 Extract GitHubFeatureFlags to a separate class 
Internal refactoring so that `GitHubFeatureFlags` is
private only. The public facing class is `Features`.
 2022-10-06 18:00:40 -07:00
Andrew Eisenberg
5915e70486 Address comments from review 2022-10-06 13:14:06 -07:00
Andrew Eisenberg
6de05e4b24 Rename FeatureFlag -> Feature 2022-10-06 13:06:10 -07:00
Andrew Eisenberg
b16314e16c Address comments from review 
- Change env var name for `MlPoweredQueriesEnabled`
- Throw error if minimumVersion is specified, but CodeQL argument is not
  supplied.
- Fix failing tests. Note that I removed a config-utils test because it
  is no longer relevant since we handle codeql minimum versions in the
  `getValue` function.
 2022-10-06 12:29:58 -07:00
Andrew Eisenberg
e5c3375225 Refactor handling of feature flags 
This commit centralizes how feature flags are handled. All feature flags
must now add an entry in the `featureFlagConfig` dictionary. This
dictionary associates the flag with an environment variable name and
optionally a minimum version for CodeQL.

The new logic is:

- if the environment variable is set to false: disabled
- if the minimum version requirement specified and met: disabled
- if the environment variable is set to true: enable
- Otherwise check feature flag enablement from the server
 2022-10-05 16:40:56 -07:00
Angela P Wen
24c8de16fa
Correctly report CodeQL version when using cache (#1259) 
* Correctly report CodeQL version when using cache

* Add JS generated files

* Add test for return value of `setupCodeQL`

* Fill in missing return value comment
 2022-10-05 09:16:42 -07:00
Andrew Eisenberg
f359ba7af1
Merge pull request #1281 from github/aeisenberg/cli-config-processing 
Add logging statements declaring state of the cli_config_file_enabled
 2022-10-04 12:30:23 -07:00
Andrew Eisenberg
5960ce1190 Extract logging statements to separate function 2022-10-03 09:35:40 -07:00
Andrew Eisenberg
59fbe34861 Avoid using single value as array 
The user config parser in the CLI doesn't yet support it.
 2022-10-02 17:13:04 -07:00
Andrew Eisenberg
6ace05baa3 Add logging statements declaring state of the cli_config_file_enabled 
It's possible to determine this otherwise, but this makes it easier to
spot.
 2022-10-01 12:03:01 -07:00
Edoardo Pirovano
4cf80047d0
Merge pull request #1280 from github/edoardo/add-timeout 
TRAP Caching: Add timeouts to upload/download operations
 2022-09-30 14:13:18 +01:00
Edoardo Pirovano
c0641ea1d3
TRAP Caching: Add timeouts to upload/download operations 2022-09-30 13:18:46 +01:00
github-actions[bot]
61b87c69a6
Update supported GitHub Enterprise Server versions. (#1275) 
Co-authored-by: GitHub <noreply@github.com>
 2022-09-29 22:37:10 +00:00
Angela P Wen
57719e015c
Don't check for Go logs on failure (#1279) 2022-09-29 14:23:35 -07:00
Chuan-kai Lin
0831a67a20
Merge pull request #1277 from github/mergeback/v2.1.26-to-main-e0e5ded3 
Mergeback v2.1.26 refs/heads/releases/v2 into main
 2022-09-29 12:37:55 -07:00
github-actions[bot]
ffa74c5cb3 Update checked-in dependencies 2022-09-29 17:59:28 +00:00
github-actions[bot]
885b397f2e Update changelog and version after v2.1.26 2022-09-29 17:46:49 +00:00
Chuan-kai Lin
e0e5ded33c
Merge pull request #1276 from github/update-v2.1.26-97054749 
Merge main into releases/v2
 2022-09-29 10:44:20 -07:00
github-actions[bot]
c60b8543e6 Update changelog for v2.1.26 2022-09-29 16:06:08 +00:00
Andrew Eisenberg
97054749c9
Merge pull request #1274 from github/aeisenberg/update-checks-script 
Update the checks script
 2022-09-29 08:34:28 -07:00
Andrew Eisenberg
fb0f74784f Update the checks script 
Avoid requiring test-setup-python-scripts checks.
 2022-09-28 16:04:46 -07:00
Angela P Wen
3400e51bc8
Add dotnet env variable to workflow (#1273) 2022-09-28 12:45:19 -07:00
Andrew Eisenberg
74740eef3d
Merge pull request #1270 from github/aeisenberg/cli-config-feature-flag 
Add the `CliConfigFileEnabled` feature flag
 2022-09-28 12:43:09 -07:00
Andrew Eisenberg
1ec8ea99ee Merge branch 'main' into aeisenberg/cli-config-feature-flag 2022-09-28 10:39:05 -07:00
Chuan-kai Lin
2466f0ce2c
Merge pull request #1267 from github/cklin/codeql-cli-2.11.0 
Update default CodeQL version to 2.11.0
 2022-09-28 09:41:38 -07:00
Chuan-kai Lin
a711c7623d Update default CodeQL version to 2.11.0 2022-09-28 09:04:11 -07:00
Henry Mercer
39064e0f9b
Merge pull request #1272 from github/update-supported-enterprise-server-versions 
Update supported GitHub Enterprise Server versions.
 2022-09-28 10:52:55 +01:00
Edoardo Pirovano
28c63d131f
Merge pull request #1268 from jsoref/rev-parse 
Correct program name
 2022-09-28 09:59:29 +01:00
Josh Soref
a4e4529299 Correct program name 2022-09-27 22:08:31 -04:00
GitHub
cc4ee05a07 Update supported GitHub Enterprise Server versions. 2022-09-28 00:21:45 +00:00
Angela P Wen
1f0700d1c0
Update unset environment variables PR check (#1269) 
* Only test Java for CLI v2.5+

* Improve bash code style

* Set Actions error messages

Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
 2022-09-27 15:55:05 -07:00
Andrew Eisenberg
cab46c529f Update src/util.test.ts 2022-09-27 15:49:25 -07:00
Andrew Eisenberg
e37b0d6470 Add the CliConfigFileEnabled feature flag 
Also, wire it up to the `useCodeScanningConfigInCli` function.
 2022-09-27 07:58:31 -07:00
Edoardo Pirovano
314ede696b
Merge pull request #1266 from github/edoardo/fix-unit-test 
Fix broken unit test
 2022-09-26 15:56:10 +01:00
Edoardo Pirovano
b96c7546c1
Fix broken unit test 2022-09-26 15:17:36 +01:00
Edoardo Pirovano
4c8f13758e
Merge pull request #1265 from github/edoardo/minimum-cache-size 
TRAP Caching: Skip uploading of small caches
 2022-09-23 15:49:56 +01:00
Edoardo Pirovano
b98b2def63
TRAP Caching: Skip uploading of small caches 2022-09-23 15:22:31 +01:00
Henry Mercer
a643eb3621
Merge pull request #1263 from github/mergeback/v2.1.25-to-main-86f3159a 
Mergeback v2.1.25 refs/heads/releases/v2 into main
 2022-09-21 21:03:20 +01:00
github-actions[bot]
6188cbdeb9 Update checked-in dependencies 2022-09-21 19:05:30 +00:00
github-actions[bot]
4706007119 Update changelog and version after v2.1.25 2022-09-21 18:42:24 +00:00
Henry Mercer
86f3159a69
Merge pull request #1261 from github/update-v2.1.25-ff5ca122 
Merge main into releases/v2
 2022-09-21 19:31:24 +01:00
github-actions[bot]
d1e2e02bee Update changelog for v2.1.25 2022-09-21 15:40:11 +00:00
Henry Mercer
ff5ca122ed
Merge pull request #1257 from github/rasmuswl/fix-ubuntu22.04-venv-creation 
python-setup: Fix venv creation in Ubuntu 22.04
 2022-09-21 16:27:55 +01:00
Rasmus Wriedt Larsen
32ca2cf500
Apply suggestions from code review 
Co-authored-by: Henry Mercer <henrymercer@github.com>
 2022-09-21 16:06:07 +02:00
Rasmus Wriedt Larsen
b2fc1e178e
python-setup: Disable python2 tests on ubuntu-22.04 2022-09-21 15:36:13 +02:00
Rasmus Wriedt Larsen
8a893ddf18
python-setup: Flush even more 2022-09-21 15:36:13 +02:00
Rasmus Wriedt Larsen
93ba53f2de
add missing spaces 2022-09-21 15:36:13 +02:00
Rasmus Wriedt Larsen
1fa5d72846
python-setup: Fail early if installing for Python 2, and python2 not available 2022-09-21 14:50:13 +02:00
Rasmus Wriedt Larsen
417059fdb2
Merge pull request #1258 from github/rasmuswl/poetry-v1.2 
python-setup: Add support for Poetry 1.2
 2022-09-21 14:03:27 +02:00