Commit graph

3408 commits

Author SHA1 Message Date
Franz Chih-Ping Hsieh
ac88d5aa91 avoid using backslash and fix typo issue. 2018-03-01 16:01:47 -05:00
Franz Chih-Ping Hsieh
47c85e8833 Use function.cmp_to_key to wrap cmp function only in Python3 2018-03-01 16:01:47 -05:00
Franz Chih-Ping Hsieh
442ec600a7 add unit test for taskinfo() in koji-web. 2018-03-01 16:01:47 -05:00
Franz Chih-Ping Hsieh
be6dab466f Replace cmp with key in sorted() for python3 support
Fixes: #713
https://pagure.io/koji/issue/713
2018-03-01 16:01:47 -05:00
Franz Chih-Ping Hsieh
e8ce7943a6 add unit test for _write_maven_repo_metadata() function in kojihub 2018-03-01 16:01:47 -05:00
Franz Hsieh
2c04c4f960 replace cmp keyword parameter with key in sorted() for python3 support
related: #713
https://pagure.io/koji/issue/713
2018-03-01 16:01:47 -05:00
Mike McLean
c0760613cf PR#748: hub: make list_archives to accept strict argument
Merges #748
https://pagure.io/koji/pull-request/748

Fixes: #721
https://pagure.io/koji/issue/721
listArchives API call should raise GenericError exception for non existing build id
2018-03-01 10:30:31 -05:00
Yuming Zhu
35dd4c942b hub: make list_archives to accept strict argument
fixes: #721
2018-03-01 10:30:27 -05:00
Mike McLean
d4a87c0dad PR#769: handle None in place of string in buildNotification
Merges #769
https://pagure.io/koji/pull-request/769

Fixes: #724
https://pagure.io/koji/issue/724
buildNotification of wrapperRPM fails because of task["label"] is None
2018-03-01 10:19:22 -05:00
Tomas Kopecek
1ad0a569b5 handle None in place of string in buildNotification
Fixes: https://pagure.io/koji/issue/724
2018-03-01 10:19:18 -05:00
Mike McLean
d75fb585da PR#824: Add internal_dev_setup option to runroot config
Merges #824
https://pagure.io/koji/pull-request/824
2018-03-01 09:20:42 -05:00
Mike McLean
082f43ba3a update unit tests 2018-02-28 12:22:05 -05:00
Mike McLean
3dda2f5dbf handle internal_dev_setup opt earlier 2018-02-28 12:22:05 -05:00
Mike McLean
c3e8a2ecc7 stabilize mock config ordering 2018-02-28 12:22:05 -05:00
Mike McLean
90f95da316 test internal_dev_setup option for getMockConfig 2018-02-28 12:22:05 -05:00
Mike McLean
c7e16a993d basic unit test for genMockConfig 2018-02-28 12:22:05 -05:00
Mike McLean
cfca804acd fix unit test 2018-02-28 08:19:29 -05:00
Mike McLean
30749fa2d0 add internal_dev_setup option to runroot plugin 2018-02-28 08:19:29 -05:00
Mike McLean
113ddea6f0 internal_dev_setup option for BuildRoot class 2018-02-28 08:19:29 -05:00
Mike McLean
e780a611a6 make internal_dev_setup an option in getMockConfig 2018-02-28 08:19:29 -05:00
Mike McLean
2f60081b35 PR#804: hub: fix KeyError in get_notification_recipients
Merges #804
https://pagure.io/koji/pull-request/804

Fixes: #803
https://pagure.io/koji/issue/803
Email notifications makes build tasks fail with "KeyError: 'users_usertype'"
2018-02-28 08:07:22 -05:00
Yuming Zhu
77af6d6688 hub: fix KeyError in get_notification_recipients 2018-02-28 08:07:17 -05:00
Mike McLean
29aeb5f0a7 PR#802: omit the last dot of cname when krb_canon_host=True
Merges #802
https://pagure.io/koji/pull-request/802

Fixes: #801
https://pagure.io/koji/issue/801
cname ends with dot when krb_canon_host=True
2018-02-28 07:41:28 -05:00
Yuming Zhu
16a94a5762 omit the last dot of cname when krb_canon_host=True
fixes: #801
relates: #653
2018-02-28 07:41:19 -05:00
Mike McLean
e01cb9b346 PR#820: compressed xml archive type
Merges #820
https://pagure.io/koji/pull-request/820
2018-02-26 15:24:30 -05:00
Mike McLean
c00084285d give the archivetype a unique name 2018-02-26 15:24:25 -05:00
Mike McLean
d1b2e16915 compressed xml archive type 2018-02-26 15:24:25 -05:00
Mike McLean
3c8d5ee3f3 PR#743: Fix key access mechanism in _build_image
Merges #743
https://pagure.io/koji/pull-request/743

Fixes: #742
https://pagure.io/koji/issue/742
dict key access fail in koji_cli.commands._build_image
2018-02-26 15:20:05 -05:00
Franz Chih-Ping Hsieh
36ed909cbb fix typo, tailing white space, unused parameter 2018-02-26 15:19:59 -05:00
Franz Chih-Ping Hsieh
f0fcb0177f add unit tests for spin-* commands 2018-02-26 15:19:59 -05:00
Franz Chih-Ping Hsieh
fce85a67c0 correct dict key check mechanism
Fixes: #742
https://pagure.io/koji/issue/742
2018-02-26 15:19:59 -05:00
Mike McLean
20f6fec390 PR#800: Don't allow combination of --mine and task-ids
Merges #800
https://pagure.io/koji/pull-request/800
2018-02-20 10:57:26 -05:00
Tomas Kopecek
7e643ce695 Don't allow combination of --mine and task-ids 2018-02-20 10:55:36 -05:00
Mike McLean
a6e41fe5ed PR#812: Fix AttributeError during archive import
Merges #812
https://pagure.io/koji/pull-request/812

Fixes: #811
https://pagure.io/koji/issue/811
AttributeError: 'dict' object has no attribute 'hub.checked_md5'
2018-02-20 10:34:43 -05:00
Mikolaj Izdebski
276d519ef8 Fix AttributeError during archive import
Fixes #811

Signed-off-by: Mikolaj Izdebski <mizdebsk@redhat.com>
2018-02-20 10:34:38 -05:00
Mike McLean
d1db97b3a2 PR#796: Fix comparison with Enum value
Merges #796
https://pagure.io/koji/pull-request/796

Fixes: #813
https://pagure.io/koji/issue/813
cg imports fail with "Unsupported checksum type"
2018-02-20 10:25:54 -05:00
Patrick Uiterwijk
0c4f702bc7 Fix comparison with Enum value
The CHECKSUM_TYPES[...] call returns the index in the Enum field, not a string,
which meant that the comparison would never work.

Reported-by: Clement Verna <cverna@tutanota.com>
Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
2018-02-20 10:25:44 -05:00
Mike McLean
50c28bb41d PR#695: blacklist tags for kojira
Merges #695
https://pagure.io/koji/pull-request/695

Fixes: #694
https://pagure.io/koji/issue/694
Give kojira a blacklist of targets that it shouldn't bother with
2018-02-20 09:43:55 -05:00
Mike McLean
fa98fe7c59 fix unit test 2018-02-20 09:43:30 -05:00
Tomas Kopecek
3294301f45 blacklist tags for kojira
Fixes: https://pagure.io/koji/issue/694

(adjusted for conflicts with PR#797 -mikem)
2018-02-20 09:43:30 -05:00
Mike McLean
96a52c28c2 PR#773: create/edit notification checks for duplicity
Merges #773
https://pagure.io/koji/pull-request/773

Fixes: #687
https://pagure.io/koji/issue/687
createNotification doesn't check existing ones
2018-02-20 09:39:33 -05:00
Tomas Kopecek
d58989d777 tests for notifications 2018-02-20 09:39:27 -05:00
Tomas Kopecek
ad62cce51e create/edit notification checks for duplicity
createNotification and updateNotification allows to have more
notification on same event/e-mail. This doesn't make much sense, so add
limitations to have only one combination.

As postgresql ignore NULL values in constraints, it is done on
application-level.

Fixes: https://pagure.io/koji/issue/687
2018-02-20 09:39:27 -05:00
Mike McLean
0abe23959a PR#799: Fix values for non-existent options
Merges #799
https://pagure.io/koji/pull-request/799
2018-02-19 17:11:36 -05:00
Mike McLean
6b09de74d3 make default user value consistent 2018-02-19 17:10:34 -05:00
Tomas Kopecek
a954bfb84b Fix values for non-existent options 2018-02-19 17:10:34 -05:00
Mike McLean
6e65174c86 PR#805: fix duplicated args "parent" in waittest task
Merges #805
https://pagure.io/koji/pull-request/805
2018-02-19 17:02:29 -05:00
Yuming Zhu
62e94c100c fix duplicated args - parent in waittest task 2018-02-19 17:02:16 -05:00
Mike McLean
8cfb6032b4 PR#806: honour runroot --quiet for old-style call
Merges #806
https://pagure.io/koji/pull-request/806

Fixes: #807
https://pagure.io/koji/issue/807
runroot CLI ignores --quiet
2018-02-19 12:26:50 -05:00
Tomas Kopecek
eaa158ab51 honour runroot --quiet for old-style call
Fixes: https://pagure.io/koji/issue/807
2018-02-19 12:26:45 -05:00